for testing and deploying your application
for finding and fixing issues
for empowering human code reviews
<?php
use Illuminate\Queue\Jobs\Job;
class UpdateLeagueMovieEarnings {
You can fix this by adding a namespace to your class:
namespace YourVendor; class YourClass { }
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.
/**
* Update LeagueMovie with the latest earnings if applicable
*
* @param Job $job
* @param $data
*/
public function fire(Job $job, $data) {
/** @type LeagueMovie $leagueMovie */
$leagueMovie = LeagueMovie::findOrFail($data['league_movie_id']);
/** @type MovieEarning $earnings */
$earnings = MovieEarning::findOrFail($data['earnings_id']);
if ( // Sanity checks
$leagueMovie->movie_id == $earnings->movie_id
&& $leagueMovie->league->end_date > $earnings->date
&& (! $leagueMovie->latestEarnings || $leagueMovie->latestEarnings->date < $earnings->date)
) {
$leagueMovie->latest_earnings_id = $earnings->id;
$leagueMovie->save();
// Possibly TODO: Update team's total earnings if that gets cached
}
$job->delete();
t2t2 /
draft
You can fix this by adding a namespace to your class:
When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries.