MovieScraperWorker

Complexity

Total Complexity

11

Size/Duplication

Total Lines	132
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes

0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	fire()	0	9	1
B	getMovies()	0	38	5
A	scanDatabaseForChanges()	0	11	1
A	updateMovies()	0	12	2
A	addMovies()	0	5	1

<?php

use Goutte\Client;
use Illuminate\Database\Eloquent\Collection as EloquentCollection;
use Illuminate\Queue\Jobs\Job;
use Illuminate\Support\Collection;
use Symfony\Component\DomCrawler\Crawler;

class MovieScraperWorker {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	/**
	 * HTTP client for requests
	 *
	 * @var Client
	 */
	protected $client;

	/**
	 * URL to scrape
	 *
	 * @var string
	 */
	protected $url = 'http://pro.boxoffice.com/statistics/release-calendar?display_all=yes';

	/**
	 * @param Client $client
	 */
	function __construct(Client $client) {

It is generally recommended to explicitly declare the visibility for methods.

		$this->client = $client;
	}

	/**
	 * Scrape for new movie data
	 *
	 * @param Job $job
	 * @param     $data
	 */
	public function fire(Job $job, $data) {

The parameter $data is not used and could be removed.

		$movies = $this->getMovies();

		$this->scanDatabaseForChanges($movies);

It seems like $movies defined by $this->getMovies() on line 39 can also be of type array<integer,array>; however, MovieScraperWorker::scanDatabaseForChanges() does only seem to accept object<Illuminate\Support\Collection>, maybe add an additional type check?

		Log::info('Releases researched', [count($movies)]);

		$job->delete();
	}

	/**
	 * Get the upcoming movies
	 *
	 * @return Collection|array[]
	 */
	private function getMovies() {
		// Limit the scraped movie release date to the max length of the league
		$limit = Carbon::now()->addWeeks(Config::get('draft.maximum_weeks'));

		$crawler = $this->client->request('GET', $this->url, []);
		// Generate a list of movies
		$movies = $crawler->filter('.data_table tbody tr')->each(function (Crawler $node) use ($limit) {

			$cols = $node->children();

			$release_date = Carbon::createFromFormat('M j, Y|', trim($cols->eq(0)->text()));
			if ($release_date->gt($limit)) {
				return false;
			}

			try {
				$info = [
					'release'      => $release_date,
					'name'         => $cols->eq(1)->children()->eq(0)->text(),
					'boxoffice_id' => str_replace('/statistics/movies/', '', $cols->eq(1)->children()->eq(0)
					                                                              ->attr('href'))
				];

			} catch (Exception $e) {
				return false;
			}
			// If anything is missing, return false
			$valid = array_reduce($info, function ($state, $item) {
					return $state && $item;
				}, true);

			return $valid ? $info : false;
		});

		$movies = new Collection(array_filter($movies));

		return $movies;
	}

	/**
	 * Scan database for new movies and add them to the database
	 *
	 * @param Collection $movies

There is no parameter named $movies. Was it maybe removed?

	 */
	private function scanDatabaseForChanges(Collection $new_data) {

The parameter $new_data is not named in camelCase.

		$new_data = $new_data->keyBy('boxoffice_id');

		$movies = Movie::whereIn('boxoffice_id', $new_data->keys())->get();

		$movies_by_id = $movies->keyBy('boxoffice_id');
		$new_movies = new Collection(array_diff_key($new_data->toArray(), $movies_by_id->toArray()));

		$this->updateMovies($new_data, $movies_by_id);
		$this->addMovies($new_movies);
	}

	/**
	 * Update current movies with new data
	 *
	 * @param Collection         $new_data
	 * @param EloquentCollection $current_data
	 */
	private function updateMovies(Collection $new_data, EloquentCollection $current_data) {

The parameter $new_data is not named in camelCase.

The parameter $current_data is not named in camelCase.

		$current_data->map(function(Movie $movie) use($new_data) {
			$data = $new_data->get($movie->boxoffice_id);

			$movie->name = $data['name'];
			$movie->release = $data['release'];

			if($movie->isDirty()) {
				$movie->save();
			}
		});
	}

	/**
	 * Add new movies
	 *
	 * @param Collection $new_movies
	 */
	private function addMovies(Collection $new_movies) {

The parameter $new_movies is not named in camelCase.

		$new_movies->map(function($data) {
			$movie = Movie::create($data);

$movie is not used, you could remove the assignment.

		});
	}


}