EventSourcedFixture::givenEvents() - Code Metrics - Inspection of "Fix PHP 5.4 build" - szjani/predaddy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — bugfix/5.4build ( 31a631 )

by Szurovecz

created 2016-06-23 19:58 UTC

EventSourcedFixture::givenEvents() B

↳ Parent: EventSourcedFixture

Complexity

Conditions	6
Paths	11

Size

Total Lines	17
Code Lines	12

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	1

Metric	Value
c	2
b	0
f	1
dl	0
loc	17
rs	8.8571
cc	6
eloc	12
nc	11
nop	1

<?php
/*
 * Copyright (c) 2012-2014 Janos Szurovecz
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy of
 * this software and associated documentation files (the "Software"), to deal in
 * the Software without restriction, including without limitation the rights to
 * use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 * of the Software, and to permit persons to whom the Software is furnished to do
 * so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace predaddy\util\test;

use precore\util\UUID;
use predaddy\domain\AbstractDomainEvent;
use predaddy\domain\GenericAggregateId;
use predaddy\domain\DomainEvent;
use predaddy\domain\eventsourcing\EventSourcingRepository;
use predaddy\domain\EventStore;
use predaddy\domain\NullAggregateId;
use predaddy\inmemory\InMemoryEventStore;

/**
 * Class EventSourcedFixture
 *
 * @package predaddy\util\test
 * @author Janos Szurovecz <[email protected]>
 */
final class EventSourcedFixture extends Fixture
{
    /**
     * @var EventStore
     */
    private $eventStore;

    /**
     * @var DomainEvent[]
     */
    private $given = [];

    public function __construct($aggregateClass)
    {
        $this->eventStore = new InMemoryEventStore();
        parent::__construct($aggregateClass, new EventSourcingRepository($this->eventStore));
    }

    /**
     * These events will be initialize the AR. It works only with ES aggregates.
     *
     * @param DomainEvent $events
     * @return EventSourcedFixture
     */
    public function givenEvents(DomainEvent $events)
    {
        $this->given = func_get_args();
        foreach ($this->given as $event) {
            if ($this->getAggregateId() === null) {
                $aggregateId = $event->aggregateId() !== null && !$event->aggregateId()->equals(NullAggregateId::instance())
                    ? $event->aggregateId()
                    : new GenericAggregateId(UUID::randomUUID()->toString(), $this->getAggregateClass());
                $this->setAggregateId($aggregateId);
            }
            if ($event instanceof AbstractDomainEvent) {
                AbstractDomainEvent::initEvent($event, $this->getAggregateId(), $event->identifier());
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
            }
            $this->eventStore->persist($event);
        }
        return $this;
    }
}


1			<?php
2			/*
3			* Copyright (c) 2012-2014 Janos Szurovecz
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy of
6			* this software and associated documentation files (the "Software"), to deal in
7			* the Software without restriction, including without limitation the rights to
8			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
9			* of the Software, and to permit persons to whom the Software is furnished to do
10			* so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in all
13			* copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21			* SOFTWARE.
22			*/
23
24			namespace predaddy\util\test;
25
26			use precore\util\UUID;
27			use predaddy\domain\AbstractDomainEvent;
28			use predaddy\domain\GenericAggregateId;
29			use predaddy\domain\DomainEvent;
30			use predaddy\domain\eventsourcing\EventSourcingRepository;
31			use predaddy\domain\EventStore;
32			use predaddy\domain\NullAggregateId;
33			use predaddy\inmemory\InMemoryEventStore;
34
35			/**
36			* Class EventSourcedFixture
37			*
38			* @package predaddy\util\test
39			* @author Janos Szurovecz <[email protected]>
40			*/
41			final class EventSourcedFixture extends Fixture
42			{
43			/**
44			* @var EventStore
45			*/
46			private $eventStore;
47
48			/**
49			* @var DomainEvent[]
50			*/
51			private $given = [];
52
53			public function __construct($aggregateClass)
54			{
55			$this->eventStore = new InMemoryEventStore();
56			parent::__construct($aggregateClass, new EventSourcingRepository($this->eventStore));
57			}
58
59			/**
60			* These events will be initialize the AR. It works only with ES aggregates.
61			*
62			* @param DomainEvent $events
63			* @return EventSourcedFixture
64			*/
65			public function givenEvents(DomainEvent $events)
66			{
67			$this->given = func_get_args();
68			foreach ($this->given as $event) {
69			if ($this->getAggregateId() === null) {
70			$aggregateId = $event->aggregateId() !== null && !$event->aggregateId()->equals(NullAggregateId::instance())
71			? $event->aggregateId()
72			: new GenericAggregateId(UUID::randomUUID()->toString(), $this->getAggregateClass());
73			$this->setAggregateId($aggregateId);
74			}
75			if ($event instanceof AbstractDomainEvent) {
76			AbstractDomainEvent::initEvent($event, $this->getAggregateId(), $event->identifier());
			0 ignored issues – show Bug introduced 2016-06-14 07:59 UTC by Report Bug Copy Issue Report It seems like `$this->getAggregateId()` can be `null`; however, `initEvent()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
77			}
78			$this->eventStore->persist($event);
79			}
80			return $this;
81			}
82			}
83

szjani / predaddy

GitHub Access Token became invalid

Push — bugfix/5.4build ( 31a631 )

EventSourcedFixture::givenEvents() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like