predaddy\commandhandling\CommandBusBuilder

Complexity

Total Complexity

4

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	init()	0	6	1
A	defaultHandlerDescFactory()	0	4	1
A	defaultName()	0	4	1
A	build()	0	4	1

<?php

For compatibility and reusability of your code, PSR1 recommends that a file should introduce either new symbols (like classes, functions, etc.) or have side-effects (like outputting something, or including other files), but not both at the same time. The first symbol is defined on line 38 and the first side effect is on line 81.

/*
 * Copyright (c) 2014 Janos Szurovecz
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy of
 * this software and associated documentation files (the "Software"), to deal in
 * the Software without restriction, including without limitation the rights to
 * use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 * of the Software, and to permit persons to whom the Software is furnished to do
 * so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace predaddy\commandhandling;

use predaddy\messagehandling\annotation\AnnotatedMessageHandlerDescriptorFactory;
use predaddy\messagehandling\SimpleMessageBusBuilder;

/**
 * Builder for {@link CommandBus}.
 *
 * It's highly recommended to use an {@link CommandFunctionDescriptorFactory} instance.
 * In that case, messages must implement {@link Command} interface.
 *
 * @package predaddy\commandhandling
 * @author Janos Szurovecz <szjani@szjani.hu>
 */
class CommandBusBuilder extends SimpleMessageBusBuilder
{
    const DEFAULT_NAME = 'command-bus';

    /**
     * @var AnnotatedMessageHandlerDescriptorFactory
     */
    private static $defaultHandlerDescFactory;

Consider using a different property name as you override a private property of the parent class.

    /**
     * Should not be called!
     */
    public static function init()
    {
        self::$defaultHandlerDescFactory = new AnnotatedMessageHandlerDescriptorFactory(
            new CommandFunctionDescriptorFactory()
        );
    }

    /**
     * @return AnnotatedMessageHandlerDescriptorFactory
     */
    protected static function defaultHandlerDescFactory()
    {
        return self::$defaultHandlerDescFactory;
    }

    /**
     * @return string
     */
    protected static function defaultName()
    {
        return self::DEFAULT_NAME;
    }

    /**
     * @return CommandBus
     */
    public function build()
    {
        return new CommandBus($this);
    }
}
CommandBusBuilder::init();