EventSourcingRepository::load() - Code Metrics - Inspection of "Fix PHP 5.4 build" - szjani/predaddy - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 3.0 ( 6209fa...31a631 )

by Szurovecz

created 2016-06-23 20:04 UTC

EventSourcingRepository::load() A

↳ Parent: EventSourcingRepository

Complexity

Conditions	4
Paths	6

Size

Total Lines	20
Code Lines	16

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	20
rs	9.2
cc	4
eloc	16
nc	6
nop	1

<?php
/*
 * Copyright (c) 2012-2014 Janos Szurovecz
 *
 * Permission is hereby granted, free of charge, to any person obtaining a copy of
 * this software and associated documentation files (the "Software"), to deal in
 * the Software without restriction, including without limitation the rights to
 * use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
 * of the Software, and to permit persons to whom the Software is furnished to do
 * so, subject to the following conditions:
 *
 * The above copyright notice and this permission notice shall be included in all
 * copies or substantial portions of the Software.
 *
 * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
 * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
 * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
 * AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
 * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
 * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 * SOFTWARE.
 */

namespace predaddy\domain\eventsourcing;

use InvalidArgumentException;
use precore\lang\Object;
use precore\lang\ObjectClass;
use precore\util\Preconditions;
use predaddy\domain\AggregateId;
use predaddy\domain\AggregateRoot;
use predaddy\domain\EventStore;
use predaddy\domain\Repository;

/**
 * Should be used for event sourcing.
 *
 * @author Janos Szurovecz <[email protected]>
 */
class EventSourcingRepository extends Object implements Repository
{
    /**
     * @var EventStore
     */
    private $eventStore;

    /**
     * @param EventStore $eventStore
     */
    public function __construct(EventStore $eventStore)
    {
        $this->eventStore = $eventStore;
    }

    /**
     * @return EventStore
     */
    public function getEventStore()
    {
        return $this->eventStore;
    }

    /**
     * Initializes the stored aggregate with its events persisted in event store.
     *
     * @param AggregateId $aggregateId
     * @return EventSourcedAggregateRoot
     * @throws InvalidArgumentException If the $aggregateId is invalid
     */
    public function load(AggregateId $aggregateId)
    {
        $aggregateRootClass = ObjectClass::forName($aggregateId->aggregateClass());
        $aggregate = null;
        $stateHash = null;
        if ($this->eventStore instanceof SnapshotEventStore) {
            $aggregate = $this->eventStore->loadSnapshot($aggregateId);
            $stateHash = $aggregate === null
                ? null
                : $aggregate->stateHash();
        }
        $events = $this->eventStore->getEventsFor($aggregateId, $stateHash);
        if ($aggregate === null) {
            Preconditions::checkArgument($events->valid(), 'Aggregate with ID [%s] does not exist', $aggregateId);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            $aggregate = $aggregateRootClass->newInstanceWithoutConstructor();
        }
        $aggregateRootClass->cast($aggregate);
        $aggregate->loadFromHistory($events);
        return $aggregate;
    }

    /**
     * Persisting the given $aggregateRoot.
     *
     * @param AggregateRoot $aggregateRoot
     */
    public function save(AggregateRoot $aggregateRoot)
    {
    }
}


1			<?php
2			/*
3			* Copyright (c) 2012-2014 Janos Szurovecz
4			*
5			* Permission is hereby granted, free of charge, to any person obtaining a copy of
6			* this software and associated documentation files (the "Software"), to deal in
7			* the Software without restriction, including without limitation the rights to
8			* use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies
9			* of the Software, and to permit persons to whom the Software is furnished to do
10			* so, subject to the following conditions:
11			*
12			* The above copyright notice and this permission notice shall be included in all
13			* copies or substantial portions of the Software.
14			*
15			* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
16			* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
17			* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
18			* AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
19			* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
20			* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
21			* SOFTWARE.
22			*/
23
24			namespace predaddy\domain\eventsourcing;
25
26			use InvalidArgumentException;
27			use precore\lang\Object;
28			use precore\lang\ObjectClass;
29			use precore\util\Preconditions;
30			use predaddy\domain\AggregateId;
31			use predaddy\domain\AggregateRoot;
32			use predaddy\domain\EventStore;
33			use predaddy\domain\Repository;
34
35			/**
36			* Should be used for event sourcing.
37			*
38			* @author Janos Szurovecz <[email protected]>
39			*/
40			class EventSourcingRepository extends Object implements Repository
41			{
42			/**
43			* @var EventStore
44			*/
45			private $eventStore;
46
47			/**
48			* @param EventStore $eventStore
49			*/
50			public function __construct(EventStore $eventStore)
51			{
52			$this->eventStore = $eventStore;
53			}
54
55			/**
56			* @return EventStore
57			*/
58			public function getEventStore()
59			{
60			return $this->eventStore;
61			}
62
63			/**
64			* Initializes the stored aggregate with its events persisted in event store.
65			*
66			* @param AggregateId $aggregateId
67			* @return EventSourcedAggregateRoot
68			* @throws InvalidArgumentException If the $aggregateId is invalid
69			*/
70			public function load(AggregateId $aggregateId)
71			{
72			$aggregateRootClass = ObjectClass::forName($aggregateId->aggregateClass());
73			$aggregate = null;
74			$stateHash = null;
75			if ($this->eventStore instanceof SnapshotEventStore) {
76			$aggregate = $this->eventStore->loadSnapshot($aggregateId);
77			$stateHash = $aggregate === null
78			? null
79			: $aggregate->stateHash();
80			}
81			$events = $this->eventStore->getEventsFor($aggregateId, $stateHash);
82			if ($aggregate === null) {
83			Preconditions::checkArgument($events->valid(), 'Aggregate with ID [%s] does not exist', $aggregateId);
			0 ignored issues – show Bug introduced 2016-06-14 07:59 UTC by Report Bug Copy Issue Report The method `valid` does only exist in `Iterator`, but not in `Countable`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
84			$aggregate = $aggregateRootClass->newInstanceWithoutConstructor();
85			}
86			$aggregateRootClass->cast($aggregate);
87			$aggregate->loadFromHistory($events);
88			return $aggregate;
89			}
90
91			/**
92			* Persisting the given $aggregateRoot.
93			*
94			* @param AggregateRoot $aggregateRoot
95			*/
96			public function save(AggregateRoot $aggregateRoot)
97			{
98			}
99			}
100

szjani / predaddy

GitHub Access Token became invalid

Push — 3.0 ( 6209fa...31a631 )

EventSourcingRepository::load() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like