Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
| 1 | <?php |
||
| 17 | class UserController extends Controller |
||
| 18 | { |
||
| 19 | /** |
||
| 20 | * @Route("/users", name="admin_users") |
||
| 21 | * @Method("GET") |
||
| 22 | */ |
||
| 23 | 1 | View Code Duplication | public function usersAction(Request $request) |
| 34 | |||
| 35 | /** |
||
| 36 | * @Route("/users/managers", name="admin_users_managers") |
||
| 37 | * @Method("GET") |
||
| 38 | */ |
||
| 39 | View Code Duplication | public function usersManagersAction(Request $request) |
|
| 50 | |||
| 51 | /** |
||
| 52 | * @Route("/estates/{slug}", name="admin_estates_manager") |
||
| 53 | */ |
||
| 54 | 1 | View Code Duplication | public function showEstatesManagerAction(Request $request, $slug) |
| 65 | |||
| 66 | /** |
||
| 67 | * @Route("/users/lock_user/{username}", name="lock_user") |
||
| 68 | * @Method("GET") |
||
| 69 | * @Security("has_role('ROLE_ADMIN')") |
||
| 70 | */ |
||
| 71 | 1 | View Code Duplication | public function lockUserAction(Request $request, $username) |
| 79 | |||
| 80 | /** |
||
| 81 | * @Route("/users/unlock_user/{username}", name="unlock_user") |
||
| 82 | * @Method("GET") |
||
| 83 | * @Security("has_role('ROLE_ADMIN')") |
||
| 84 | */ |
||
| 85 | 1 | View Code Duplication | public function unlockUserAction(Request $request, $username) |
| 93 | |||
| 94 | /** |
||
| 95 | * @Route("/users/do_manager/{username}", name="do_manager") |
||
| 96 | * @Method("GET") |
||
| 97 | * @Security("has_role('ROLE_ADMIN')") |
||
| 98 | */ |
||
| 99 | 1 | View Code Duplication | public function doManagerAction(Request $request, $username) |
| 107 | |||
| 108 | /** |
||
| 109 | * @Route("/users/do_user/{username}", name="do_user") |
||
| 110 | * @Method("GET") |
||
| 111 | * @Security("has_role('ROLE_ADMIN')") |
||
| 112 | */ |
||
| 113 | 2 | public function doUserAction(Request $request, $username) |
|
| 123 | } |
||
| 124 | |||
| 125 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.