SiteController::addEstateToFavoritesAction() - Code Metrics - Inspection of "Dev" - syrotchukandrew/rainbow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#2)

by Kate

created 2016-03-18 10:37 UTC

SiteController::addEstateToFavoritesAction() A

↳ Parent: SiteController

Complexity

Conditions	2
Paths	2

Size

Total Lines	11
Code Lines	7

Duplication

Lines	11
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	6

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	11
loc	11
ccs	0
cts	10
cp	0
rs	9.4285
cc	2
eloc	7
nc	2
nop	3
crap	6

<?php
/**
 * Created by PhpStorm.
 * User: kate
 * Date: 17.02.16
 * Time: 9:30
 */

namespace AppBundle\Controller;

use AppBundle\Entity\Comment;
use AppBundle\Entity\MenuItem;
use AppBundle\Entity\Estate;
use AppBundle\Entity\User;
use AppBundle\Entity\Category;
use AppBundle\Form\CommentType;
use AppBundle\Form\SearchType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\Response;


class SiteController extends Controller
{
    /**
     * @Route("/", name="homepage")
     */
    public function indexAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $estates = $em->getRepository('AppBundle:Estate')->getEstateExclusiveWithFiles();
        $breadcrumbs = $this->get("white_october_breadcrumbs");
        $breadcrumbs->addItem("Homepage");
        return $this->render("AppBundle::site/index.html.twig", array('estates' => $estates));
    }

    /**
     * @Route("/menu", name="menu")
     */
    public function menuAction(Request $request)

    {
        $em = $this->getDoctrine()->getManager();
        $categoryEntity = $em->getRepository('AppBundle\Entity\Category');
        $categories = $categoryEntity->childrenHierarchy();
        return $this->render("AppBundle::includes/menu.html.twig", ['links' => $categories]);
    }

    /**
     * @Route("/show_category/{slug}", name="show_category")
     * @ParamConverter("category", class="AppBundle\Entity\Category", options={"mapping": {"slug": "title"}})
     */
    public function showCategoryAction(Request $request, Category $category)
    {
        $em = $this->getDoctrine()->getManager();
        $estates = $em->getRepository('AppBundle\Entity\Estate')->getEstateFromCategory($category->getTitle());
        $breadcrumbs = $this->get("white_october_breadcrumbs");
        $node = $category;
        while ($node) {
            $breadcrumbs->prependItem($node->getTitle());
            $node = $node->getParent();
        }
        $breadcrumbs->prependItem("Homepage");

        return $this->render("AppBundle::site/index.html.twig", array('estates' => $estates));
    }

    /**
     * @Route("/show_estate/{slug}", name="show_estate")
     */
    public function showEstateAction(Request $request, $slug)
    {
        $em = $this->getDoctrine()->getManager();
        $estate = $em->getRepository('AppBundle\Entity\Estate')->getEstateWithDistrictComment($slug);
        $breadcrumbs = $this->get("white_october_breadcrumbs");
        $node = $estate->getCategory();
        $breadcrumbs->prependItem($estate->getTitle());
        while ($node) {
            $breadcrumbs->prependItem($node->getTitle());
            $node = $node->getParent();
        }
        $breadcrumbs->prependItem("Homepage");
        $comment = new Comment();
        $commentForm = $this->createForm(CommentType::class, $comment, [
            'method' => 'POST',
        ])
            ->add('addComment', SubmitType::class, ['label' => 'common.save',
                'attr' => ['class' => 'btn btn-primary']
            ]);
        $commentForm->handleRequest($request);
        if ($commentForm->isSubmitted() && $commentForm->isValid()) {
            $comment->setEstate($estate);
            if ($this->getUser()->hasRole('ROLE_ADMIN')) {
                $comment->setEnabled(true);
            } else {
                $comment->setEnabled(false);
            }
            $em = $this->getDoctrine()->getManager();
            $em->persist($comment);
            $em->flush();
            $this->get('session')->getFlashBag()->add('success', 'site.flush_comment');
            return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
        }
        return $this->render('AppBundle:site:show_estate.html.twig', array('estate' => $estate,
            'commentForm' => $commentForm->createView()));
    }

    /**
     * @Route("/search", name="site_search")
     * */
    public function searchAction(Request $request)
    {
        $finalCategories = $this->container->get('app.final_category_finder')->findFinalCategories();
        $searchForm = $this->createForm(SearchType::class, null, array(
            'action' => $this->generateUrl('site_search'),
            'categories_choices' => $finalCategories
        ))
            ->add('search', SubmitType::class, ['label' => 'Искать',
                'attr' => ['class' => 'btn btn-default']
            ]);

        $searchForm->handleRequest($request);
        if ($searchForm->isValid() && $searchForm->isSubmitted()) {
            $estates = $this->get('app.search')->searchEstate($searchForm->getData());
            // return new Response();

            return $this->render('AppBundle:site:index.html.twig', array('estates' => $estates));
        }

        return $this->render('@App/site/search.html.twig', array(
            'form' => $searchForm->createView(),
        ));
    }

    /**
     * @Route(name="show_menu_item")
     */
    public function showMenuItemAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager();
        $menuitems = $em->getRepository('AppBundle:MenuItem')->findAll();
        return $this->render('AppBundle:includes:menu_items.html.twig', array('items' => $menuitems));
    }

    /**
     * @Route("/description_menu/{id}", name="show_description_menu_item")
     * @ParamConverter("MenuItem", options={"mapping": {"id": "id"}})
     */
    public function showDescriptionMenuItem(Request $request, MenuItem $menuItem)
    {
        return $this->render('AppBundle:site:show_description_menu_item.html.twig', array('item' => $menuItem));
    }

    /**
     * @Route("/add_favorites/{estate}/{user}", name = "add_estate_to_favorites")
     * @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
     * @ParamConverter("user", class="AppBundle\Entity\User", options={"mapping": {"user": "id"}})
     */
    public function addEstateToFavoritesAction(Estate $estate, User $user, Request $request)

    {
        $em = $this->getDoctrine()->getManager();
        if (!$user->hasEstate($estate)) {
            $user->addEstate($estate);
            $em->persist($user);
            $em->flush();
        }

        return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
    }

    /**
     * @Route("/delete_favorites/{estate}/{user}", name = "delete_estate_from_favorites")
     * @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
     * @ParamConverter("user", class="AppBundle\Entity\User", options={"mapping": {"user": "id"}})
     */
    public function deleteEstateFromFavoritesAction(Estate $estate, User $user, Request $request)

    {
        $em = $this->getDoctrine()->getManager();
        if ($user->hasEstate($estate)) {
            $user->removeEstate($estate);
            $em->persist($user);
            $em->flush();
        }

        return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
    }

    /**
     * @Route("/pdf/{estate}", name = "pdf_estate")
     * @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
     */
    public function pdfEstateAction(Estate $estate, Request $request)
    {
        $comment = new Comment();
        $commentForm = $this->createForm(CommentType::class, $comment, [
            'method' => 'POST',
        ])
            ->add('addComment', SubmitType::class, ['label' => 'common.save',
                'attr' => ['class' => 'btn btn-primary']
            ]);
        $html = $this->renderView('@App/site/pdf.html.twig', array(
            'estate' => $estate,
            'commentForm' => $commentForm->createView()
        ));

        return new Response(
            $this->get('knp_snappy.pdf')->getOutputFromHtml($html, array(
                'images' => true,
            )),
            200,
            array(
                'Content-Type' => 'application/pdf',
                'Content-Disposition' => 'attachment; filename="file.pdf"'
            )
        );
    }


}

1		<?php
2		/**
3		* Created by PhpStorm.
4		* User: kate
5		* Date: 17.02.16
6		* Time: 9:30
7		*/
8
9		namespace AppBundle\Controller;
10
11		use AppBundle\Entity\Comment;
12		use AppBundle\Entity\MenuItem;
13		use AppBundle\Entity\Estate;
14		use AppBundle\Entity\User;
15		use AppBundle\Entity\Category;
16		use AppBundle\Form\CommentType;
17		use AppBundle\Form\SearchType;
18		use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
19		use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
20		use Symfony\Bundle\FrameworkBundle\Controller\Controller;
21		use Symfony\Component\Form\Extension\Core\Type\SubmitType;
22		use Symfony\Component\HttpFoundation\Request;
23		use Symfony\Component\HttpFoundation\Response;
24
25
26		class SiteController extends Controller
27		{
28		/**
29		* @Route("/", name="homepage")
30		*/
31		public function indexAction(Request $request)
32		{
33		$em = $this->getDoctrine()->getManager();
34		$estates = $em->getRepository('AppBundle:Estate')->getEstateExclusiveWithFiles();
35		$breadcrumbs = $this->get("white_october_breadcrumbs");
36		$breadcrumbs->addItem("Homepage");
37		return $this->render("AppBundle::site/index.html.twig", array('estates' => $estates));
38		}
39
40		/**
41		* @Route("/menu", name="menu")
42		*/
43	View Code Duplication	public function menuAction(Request $request)
		0 ignored issues – show Duplication introduced 2016-03-10 09:56 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
44		{
45		$em = $this->getDoctrine()->getManager();
46		$categoryEntity = $em->getRepository('AppBundle\Entity\Category');
47		$categories = $categoryEntity->childrenHierarchy();
48		return $this->render("AppBundle::includes/menu.html.twig", ['links' => $categories]);
49		}
50
51		/**
52		* @Route("/show_category/{slug}", name="show_category")
53		* @ParamConverter("category", class="AppBundle\Entity\Category", options={"mapping": {"slug": "title"}})
54		*/
55		public function showCategoryAction(Request $request, Category $category)
56		{
57		$em = $this->getDoctrine()->getManager();
58		$estates = $em->getRepository('AppBundle\Entity\Estate')->getEstateFromCategory($category->getTitle());
59		$breadcrumbs = $this->get("white_october_breadcrumbs");
60		$node = $category;
61		while ($node) {
62		$breadcrumbs->prependItem($node->getTitle());
63		$node = $node->getParent();
64		}
65		$breadcrumbs->prependItem("Homepage");
66
67		return $this->render("AppBundle::site/index.html.twig", array('estates' => $estates));
68		}
69
70		/**
71		* @Route("/show_estate/{slug}", name="show_estate")
72		*/
73		public function showEstateAction(Request $request, $slug)
74		{
75		$em = $this->getDoctrine()->getManager();
76		$estate = $em->getRepository('AppBundle\Entity\Estate')->getEstateWithDistrictComment($slug);
77		$breadcrumbs = $this->get("white_october_breadcrumbs");
78		$node = $estate->getCategory();
79		$breadcrumbs->prependItem($estate->getTitle());
80		while ($node) {
81		$breadcrumbs->prependItem($node->getTitle());
82		$node = $node->getParent();
83		}
84		$breadcrumbs->prependItem("Homepage");
85		$comment = new Comment();
86		$commentForm = $this->createForm(CommentType::class, $comment, [
87		'method' => 'POST',
88		])
89		->add('addComment', SubmitType::class, ['label' => 'common.save',
90		'attr' => ['class' => 'btn btn-primary']
91		]);
92		$commentForm->handleRequest($request);
93		if ($commentForm->isSubmitted() && $commentForm->isValid()) {
94		$comment->setEstate($estate);
95		if ($this->getUser()->hasRole('ROLE_ADMIN')) {
96		$comment->setEnabled(true);
97		} else {
98		$comment->setEnabled(false);
99		}
100		$em = $this->getDoctrine()->getManager();
101		$em->persist($comment);
102		$em->flush();
103		$this->get('session')->getFlashBag()->add('success', 'site.flush_comment');
104		return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
105		}
106		return $this->render('AppBundle:site:show_estate.html.twig', array('estate' => $estate,
107		'commentForm' => $commentForm->createView()));
108		}
109
110		/**
111		* @Route("/search", name="site_search")
112		* */
113		public function searchAction(Request $request)
114		{
115		$finalCategories = $this->container->get('app.final_category_finder')->findFinalCategories();
116		$searchForm = $this->createForm(SearchType::class, null, array(
117		'action' => $this->generateUrl('site_search'),
118		'categories_choices' => $finalCategories
119		))
120		->add('search', SubmitType::class, ['label' => 'Искать',
121		'attr' => ['class' => 'btn btn-default']
122		]);
123
124		$searchForm->handleRequest($request);
125		if ($searchForm->isValid() && $searchForm->isSubmitted()) {
126		$estates = $this->get('app.search')->searchEstate($searchForm->getData());
127		// return new Response();
		0 ignored issues – show Unused Code Comprehensibility introduced 2016-03-15 08:41 UTC by Report Bug Copy Issue Report `56%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
128		return $this->render('AppBundle:site:index.html.twig', array('estates' => $estates));
129		}
130
131		return $this->render('@App/site/search.html.twig', array(
132		'form' => $searchForm->createView(),
133		));
134		}
135
136		/**
137		* @Route(name="show_menu_item")
138		*/
139		public function showMenuItemAction(Request $request)
140		{
141		$em = $this->getDoctrine()->getManager();
142		$menuitems = $em->getRepository('AppBundle:MenuItem')->findAll();
143		return $this->render('AppBundle:includes:menu_items.html.twig', array('items' => $menuitems));
144		}
145
146		/**
147		* @Route("/description_menu/{id}", name="show_description_menu_item")
148		* @ParamConverter("MenuItem", options={"mapping": {"id": "id"}})
149		*/
150		public function showDescriptionMenuItem(Request $request, MenuItem $menuItem)
151		{
152		return $this->render('AppBundle:site:show_description_menu_item.html.twig', array('item' => $menuItem));
153		}
154
155		/**
156		* @Route("/add_favorites/{estate}/{user}", name = "add_estate_to_favorites")
157		* @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
158		* @ParamConverter("user", class="AppBundle\Entity\User", options={"mapping": {"user": "id"}})
159		*/
160	View Code Duplication	public function addEstateToFavoritesAction(Estate $estate, User $user, Request $request)
		0 ignored issues – show Duplication introduced 2016-03-16 19:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
161		{
162		$em = $this->getDoctrine()->getManager();
163		if (!$user->hasEstate($estate)) {
164		$user->addEstate($estate);
165		$em->persist($user);
166		$em->flush();
167		}
168
169		return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
170		}
171
172		/**
173		* @Route("/delete_favorites/{estate}/{user}", name = "delete_estate_from_favorites")
174		* @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
175		* @ParamConverter("user", class="AppBundle\Entity\User", options={"mapping": {"user": "id"}})
176		*/
177	View Code Duplication	public function deleteEstateFromFavoritesAction(Estate $estate, User $user, Request $request)
		0 ignored issues – show Duplication introduced 2016-03-16 19:36 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
178		{
179		$em = $this->getDoctrine()->getManager();
180		if ($user->hasEstate($estate)) {
181		$user->removeEstate($estate);
182		$em->persist($user);
183		$em->flush();
184		}
185
186		return $this->redirectToRoute('show_estate', array('slug' => $estate->getSlug()));
187		}
188
189		/**
190		* @Route("/pdf/{estate}", name = "pdf_estate")
191		* @ParamConverter("estate", class="AppBundle\Entity\Estate", options={"mapping": {"estate": "slug"}})
192		*/
193		public function pdfEstateAction(Estate $estate, Request $request)
194		{
195		$comment = new Comment();
196		$commentForm = $this->createForm(CommentType::class, $comment, [
197		'method' => 'POST',
198		])
199		->add('addComment', SubmitType::class, ['label' => 'common.save',
200		'attr' => ['class' => 'btn btn-primary']
201		]);
202		$html = $this->renderView('@App/site/pdf.html.twig', array(
203		'estate' => $estate,
204		'commentForm' => $commentForm->createView()
205		));
206
207		return new Response(
208		$this->get('knp_snappy.pdf')->getOutputFromHtml($html, array(
209		'images' => true,
210		)),
211		200,
212		array(
213		'Content-Type' => 'application/pdf',
214		'Content-Disposition' => 'attachment; filename="file.pdf"'
215		)
216		);
217		}
218
219
220		}

syrotchukandrew / rainbow

Pull Request — master (#2)

SiteController::addEstateToFavoritesAction() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like