AppBundle\Controller\Admin\AdminCategoryController

Complexity

Total Complexity

5

Size/Duplication

Total Lines	48
Duplicated Lines	52.08 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

0%

Importance

Changes	2
Bugs	0	Features	2

3 Methods

Rating	Name	Duplication	Size	Complexity
A	categoriesAction()	0	6	1
A	newCategoryRootAction()	17	17	3
A	createDeleteForm()	8	8	1

<?php

namespace AppBundle\Controller\Admin;

use AppBundle\Entity\Category;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
use Symfony\Bundle\FrameworkBundle\Controller\Controller;
use Symfony\Component\HttpFoundation\Request;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Method;
use Symfony\Component\Form\Extension\Core\Type\SubmitType;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\ParamConverter;
use Sensio\Bundle\FrameworkExtraBundle\Configuration\Security;
use AppBundle\Form\CategoryType;



/**
 * @Security("has_role('ROLE_MANAGER')")
 * @Route("/admin")
 */
class AdminCategoryController extends Controller
{
    /**
     * @Route("/categories", name="admin_categories")
     * @Method("GET")
     */
    public function categoriesAction(Request $request)
    {
        $em = $this->getDoctrine()->getManager()->getRepository('AppBundle\Entity\Category');
        $categories = $em->childrenHierarchy();
        return $this->render("@App/admin/category/categories.html.twig", ['categories' => $categories]);
    }

    /**
     * @Route("/category_root/new", name="admin_category_root_new")
     * @Method({"GET", "POST"})
     * @Security("has_role('ROLE_ADMIN')")
     */
    public function newCategoryRootAction(Request $request)

This method seems to be duplicated in your project.

    {
        $entityManager = $this->getDoctrine()->getManager();
        $category = new Category();
        $form = $this->createForm(CategoryType::class, $category);
        $form->handleRequest($request);
        if ($form->isSubmitted() && $form->isValid()) {
            $category->setParent(null);
            $entityManager->persist($category);
            $entityManager->flush();
            return $this->redirectToRoute('admin_categories');
        }
        return $this->render('@App/admin/category/new_category_root.html.twig', array(
            'category' => $category,
            'form' => $form->createView(),
        ));
    }




    private function createDeleteForm(Category $category)

This method is not used, and could be removed.

This method seems to be duplicated in your project.

    {
        return $this->createFormBuilder()
            ->setAction($this->generateUrl('admin_district_delete', array('slug' => $category->getSlug())))
            ->setMethod('DELETE')
            ->getForm()
            ;
    }
}