Client::getServiceResponse() - Code Metrics - Inspection of "Merge pull request #35 from Netifriik/master" - syntaxerrors/Steam - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 628a8a...f650aa )

by Travis

created 2016-05-24 13:19 UTC

Client::getServiceResponse() A

↳ Parent: Client

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	1.0156

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	9
ccs	3
cts	4
cp	0.75
rs	9.6666
cc	1
eloc	4
nc	1
nop	1
crap	1.0156

<?php namespace Syntax\SteamApi;

use stdClass;
use GuzzleHttp\Client as GuzzleClient;
use GuzzleHttp\Psr7\Request;
use Exception;
use Illuminate\Support\Facades\Config;
use GuzzleHttp\Exception\ClientErrorResponseException;
use GuzzleHttp\Exception\ServerErrorResponseException;
use Syntax\SteamApi\Exceptions\ApiCallFailedException;
use Syntax\SteamApi\Exceptions\ClassNotFoundException;

/**
 * @method news()
 * @method player($steamId)
 * @method user($steamId)
 * @method userStats($steamId)
 * @method app()
 * @method group()
 */
class Client {

    use SteamId;

    public    $validFormats = ['json', 'xml', 'vdf'];

    protected $url          = 'http://api.steampowered.com/';

    protected $client;

    protected $interface;

    protected $method;

    protected $version      = 'v0002';

    protected $apiKey;

    protected $apiFormat    = 'json';

    protected $steamId;

    protected $isService    = false;

    public function __construct()
    {
        $apiKey = $this->getApiKey();

        $this->client = new GuzzleClient();
        $this->apiKey = $apiKey;

        // Set up the Ids
        $this->setUpFormatted();
    }

    public function get()
    {
        return $this;
    }

    public function getSteamId()
    {
        return $this->steamId;
    }

    /**
     * @param string $arguments
     *
     * @return string
     *
     * @throws ApiArgumentRequired
     * @throws ApiCallFailedException
     */
    protected function setUpService($arguments = null)
    {
        // Services have a different url syntax
        if ($arguments == null) {

            throw new ApiArgumentRequired;
        }

        $parameters = [
            'key'        => $this->apiKey,
            'format'     => $this->apiFormat,
            'input_json' => $arguments,
        ];

        $steamUrl = $this->buildUrl(true);

        // Build the query string
        $parameters = http_build_query($parameters);

        // Send the request and get the results
        $request  = new Request('GET', $steamUrl . '?' . $parameters);
        $response = $this->sendRequest($request);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // Pass the results back
        return $response->body;
    }

    protected function setUpClient(array $arguments = [])
    {
        $versionFlag = ! is_null($this->version);
        $steamUrl    = $this->buildUrl($versionFlag);

        $parameters = [
            'key'    => $this->apiKey,
            'format' => $this->apiFormat
        ];

        if (! empty($arguments)) {
            $parameters = array_merge($arguments, $parameters);
        }

        // Build the query string
        $parameters = http_build_query($parameters);

        // Send the request and get the results
        $request  = new Request('GET', $steamUrl . '?' . $parameters);
        $response = $this->sendRequest($request);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        // Pass the results back
        return $response->body;
    }

    protected function setUpXml(array $arguments = [])
    {
        $steamUrl = $this->buildUrl();

        // Build the query string
        $parameters = http_build_query($arguments);

        // Pass the results back
        return simplexml_load_file($steamUrl . '?' . $parameters);
    }

    /**
     * @param \Guzzle\Http\Message\RequestInterface $request
     *
     * @throws ApiCallFailedException
     * @return stdClass
     */
    protected function sendRequest($request)
    {
        // Try to get the result.  Handle the possible exceptions that can arise
        try {
            $response = $this->client->send($request);

            $result       = new stdClass();
            $result->code = $response->getStatusCode();
            $result->body = json_decode($response->getBody(true));


        } catch (ClientErrorResponseException $e) {

            throw new ApiCallFailedException($e->getMessage(), $e->getResponse()->getStatusCode(), $e);

        } catch (ServerErrorResponseException $e) {

            throw new ApiCallFailedException('Api call failed to complete due to a server error.', $e->getResponse()->getStatusCode(), $e);

        } catch (Exception $e) {
            throw new ApiCallFailedException($e->getMessage(), $e->getCode(), $e);

        }

        // If all worked out, return the result
        return $result;
    }

    private function buildUrl($version = false)
    {
        // Set up the basic url
        $url = $this->url . $this->interface . '/' . $this->method . '/';

        // If we have a version, add it
        if ($version) {
            return $url . $this->version . '/';
        }

        return $url;
    }

    public function __call($name, $arguments)
    {
        // Handle a steamId being passed
        if (! empty($arguments) && count($arguments) == 1) {
            $this->steamId = $arguments[0];

            $this->convertSteamIdTo64();
        }

        // Inside the root steam directory
        $class      = ucfirst($name);
        $steamClass = '\Syntax\SteamApi\Steam\\' . $class;

        if (class_exists($steamClass)) {
            return new $steamClass($this->steamId);
        }

        // Inside a nested directory
        $class      = implode('\\', preg_split('/(?=[A-Z])/', $class, -1, PREG_SPLIT_NO_EMPTY));
        $steamClass = '\Syntax\SteamApi\Steam\\' . $class;

        if (class_exists($steamClass)) {
            return new $steamClass($this->steamId);
        }

        // Nothing found
        throw new ClassNotFoundException($name);
    }

    /**
     * @param Collection $objects
     *
     * @return $this
     */
    protected function sortObjects($objects)
    {
        return $objects->sortBy(function ($object) {
            return $object->name;
        });
    }

    /**
     * @param string $method
     * @param string $version
     */
    protected function setApiDetails($method, $version)
    {
        $this->method  = $method;
        $this->version = $version;
    }

    protected function getServiceResponse($arguments)
    {
        $arguments = json_encode($arguments);

        // Get the client
        $client = $this->setUpService($arguments)->response;

        return $client;
    }

    /**
     * @return string
     * @throws Exceptions\InvalidApiKeyException
     */
    protected function getApiKey()
    {
        $apiKey = \Config::get('steam-api.steamApiKey');

        if ($apiKey == 'YOUR-API-KEY') {
            throw new Exceptions\InvalidApiKeyException();
        }
        if (is_null($apiKey) || $apiKey == '' || $apiKey == []) {
            $apiKey = getenv('apiKey');
        }

        return $apiKey;
    }

    private function convertSteamIdTo64()
    {
        if (is_array($this->steamId)) {
            array_walk($this->steamId, function (&$id) {
                if (strpos($id, ':') !== false) {
                    // Convert the id to all types and grab the 64 bit version
                    $id = $this->convertToAll($id)->id64;
                }
            });
        } elseif (strpos(':', $this->steamId) !== false) {
            // Convert the id to all types and grab the 64 bit version
            $this->steamId = $this->convertToAll($this->steamId)->id64;
        }
    }
}

1		<?php namespace Syntax\SteamApi;
2
3		use stdClass;
4		use GuzzleHttp\Client as GuzzleClient;
5		use GuzzleHttp\Psr7\Request;
6		use Exception;
7		use Illuminate\Support\Facades\Config;
8		use GuzzleHttp\Exception\ClientErrorResponseException;
9		use GuzzleHttp\Exception\ServerErrorResponseException;
10		use Syntax\SteamApi\Exceptions\ApiCallFailedException;
11		use Syntax\SteamApi\Exceptions\ClassNotFoundException;
12
13		/**
14		* @method news()
15		* @method player($steamId)
16		* @method user($steamId)
17		* @method userStats($steamId)
18		* @method app()
19		* @method group()
20		*/
21		class Client {
22
23		use SteamId;
24
25		public $validFormats = ['json', 'xml', 'vdf'];
26
27		protected $url = 'http://api.steampowered.com/';
28
29		protected $client;
30
31		protected $interface;
32
33		protected $method;
34
35		protected $version = 'v0002';
36
37		protected $apiKey;
38
39		protected $apiFormat = 'json';
40
41		protected $steamId;
42
43		protected $isService = false;
44
45	42	public function __construct()
46		{
47	42	$apiKey = $this->getApiKey();
48
49	42	$this->client = new GuzzleClient();
50	42	$this->apiKey = $apiKey;
51
52		// Set up the Ids
53	42	$this->setUpFormatted();
54	42	}
55
56		public function get()
57		{
58		return $this;
59		}
60
61	1	public function getSteamId()
62		{
63	1	return $this->steamId;
64		}
65
66		/**
67		* @param string $arguments
68		*
69		* @return string
70		*
71		* @throws ApiArgumentRequired
72		* @throws ApiCallFailedException
73		*/
74	10	protected function setUpService($arguments = null)
75		{
76		// Services have a different url syntax
77	10	if ($arguments == null) {
		0 ignored issues – show Bug introduced 2015-12-23 10:46 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$arguments` of type `string\|null` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
78		throw new ApiArgumentRequired;
79		}
80
81		$parameters = [
82	10	'key' => $this->apiKey,
83	10	'format' => $this->apiFormat,
84	10	'input_json' => $arguments,
85	10	];
86
87	10	$steamUrl = $this->buildUrl(true);
88
89		// Build the query string
90	10	$parameters = http_build_query($parameters);
91
92		// Send the request and get the results
93	10	$request = new Request('GET', $steamUrl . '?' . $parameters);
94	10	$response = $this->sendRequest($request);
		0 ignored issues – show Documentation introduced 2016-05-22 17:03 UTC by Report Bug Copy Issue Report `$request` is of type `object<GuzzleHttp\Psr7\Request>`, but the function expects a `object<Guzzle\Http\Message\RequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
95
96		// Pass the results back
97		return $response->body;
98		}
99
100	17	protected function setUpClient(array $arguments = [])
101		{
102	17	$versionFlag = ! is_null($this->version);
103	17	$steamUrl = $this->buildUrl($versionFlag);
104
105		$parameters = [
106	17	'key' => $this->apiKey,
107	17	'format' => $this->apiFormat
108	17	];
109
110	17	if (! empty($arguments)) {
111	16	$parameters = array_merge($arguments, $parameters);
112	16	}
113
114		// Build the query string
115	17	$parameters = http_build_query($parameters);
116
117		// Send the request and get the results
118	17	$request = new Request('GET', $steamUrl . '?' . $parameters);
119	17	$response = $this->sendRequest($request);
		0 ignored issues – show Documentation introduced 2016-05-22 18:19 UTC by Report Bug Copy Issue Report `$request` is of type `object<GuzzleHttp\Psr7\Request>`, but the function expects a `object<Guzzle\Http\Message\RequestInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
120
121		// Pass the results back
122	6	return $response->body;
123		}
124
125	4	protected function setUpXml(array $arguments = [])
126		{
127	4	$steamUrl = $this->buildUrl();
128
129		// Build the query string
130	4	$parameters = http_build_query($arguments);
131
132		// Pass the results back
133	4	return simplexml_load_file($steamUrl . '?' . $parameters);
134		}
135
136		/**
137		* @param \Guzzle\Http\Message\RequestInterface $request
138		*
139		* @throws ApiCallFailedException
140		* @return stdClass
141		*/
142	27	protected function sendRequest($request)
143		{
144		// Try to get the result. Handle the possible exceptions that can arise
145		try {
146	27	$response = $this->client->send($request);
147
148	6	$result = new stdClass();
149	6	$result->code = $response->getStatusCode();
150	6	$result->body = json_decode($response->getBody(true));
		0 ignored issues – show Unused Code introduced 2016-05-22 17:03 UTC by Report Bug Copy Issue Report The call to `ResponseInterface::getBody()` has too many arguments starting with `true`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
151
152	27	} catch (ClientErrorResponseException $e) {
		0 ignored issues – show Bug introduced 2016-05-22 17:03 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ClientErrorResponseException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
153		throw new ApiCallFailedException($e->getMessage(), $e->getResponse()->getStatusCode(), $e);
154
155	21	} catch (ServerErrorResponseException $e) {
		0 ignored issues – show Bug introduced 2016-05-22 17:03 UTC by Report Bug Copy Issue Report The class `GuzzleHttp\Exception\ServerErrorResponseException` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
156		throw new ApiCallFailedException('Api call failed to complete due to a server error.', $e->getResponse()->getStatusCode(), $e);
157
158	21	} catch (Exception $e) {
159	21	throw new ApiCallFailedException($e->getMessage(), $e->getCode(), $e);
160
161		}
162
163		// If all worked out, return the result
164	6	return $result;
165		}
166
167	30	private function buildUrl($version = false)
168		{
169		// Set up the basic url
170	30	$url = $this->url . $this->interface . '/' . $this->method . '/';
171
172		// If we have a version, add it
173	30	if ($version) {
174	25	return $url . $this->version . '/';
175		}
176
177	5	return $url;
178		}
179
180	33	public function __call($name, $arguments)
181		{
182		// Handle a steamId being passed
183	33	if (! empty($arguments) && count($arguments) == 1) {
184	27	$this->steamId = $arguments[0];
185
186	27	$this->convertSteamIdTo64();
187	27	}
188
189		// Inside the root steam directory
190	33	$class = ucfirst($name);
191	33	$steamClass = '\Syntax\SteamApi\Steam\\' . $class;
192
193	33	if (class_exists($steamClass)) {
194	28	return new $steamClass($this->steamId);
195		}
196
197		// Inside a nested directory
198	6	$class = implode('\\', preg_split('/(?=[A-Z])/', $class, -1, PREG_SPLIT_NO_EMPTY));
199	6	$steamClass = '\Syntax\SteamApi\Steam\\' . $class;
200
201	6	if (class_exists($steamClass)) {
202	6	return new $steamClass($this->steamId);
203		}
204
205		// Nothing found
206		throw new ClassNotFoundException($name);
207		}
208
209		/**
210		* @param Collection $objects
211		*
212		* @return $this
213		*/
214	2	protected function sortObjects($objects)
215		{
216	2	return $objects->sortBy(function ($object) {
217	2	return $object->name;
218	2	});
219		}
220
221		/**
222		* @param string $method
223		* @param string $version
224		*/
225	10	protected function setApiDetails($method, $version)
226		{
227	10	$this->method = $method;
228	10	$this->version = $version;
229	10	}
230
231	10	protected function getServiceResponse($arguments)
232		{
233	10	$arguments = json_encode($arguments);
234
235		// Get the client
236	10	$client = $this->setUpService($arguments)->response;
237
238		return $client;
239		}
240
241		/**
242		* @return string
243		* @throws Exceptions\InvalidApiKeyException
244		*/
245	42	protected function getApiKey()
246		{
247	42	$apiKey = \Config::get('steam-api.steamApiKey');
248
249	42	if ($apiKey == 'YOUR-API-KEY') {
250		throw new Exceptions\InvalidApiKeyException();
251		}
252	42	if (is_null($apiKey) \|\| $apiKey == '' \|\| $apiKey == []) {
253	42	$apiKey = getenv('apiKey');
254	42	}
255
256	42	return $apiKey;
257		}
258
259	27	private function convertSteamIdTo64()
260		{
261	27	if (is_array($this->steamId)) {
262	1	array_walk($this->steamId, function (&$id) {
263	1	if (strpos($id, ':') !== false) {
264		// Convert the id to all types and grab the 64 bit version
265	1	$id = $this->convertToAll($id)->id64;
266	1	}
267	1	});
268	27	} elseif (strpos(':', $this->steamId) !== false) {
269		// Convert the id to all types and grab the 64 bit version
270		$this->steamId = $this->convertToAll($this->steamId)->id64;
271		}
272		}
273		}

syntaxerrors / Steam

Push — master ( 628a8a...f650aa )

Client::getServiceResponse() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like