Syntax\SteamApi\Steam\Group

Complexity

Total Complexity

2

Size/Duplication

Total Lines	29
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

100%

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	GetGroupSummary()	0	26	2

<?php

namespace Syntax\SteamApi\Steam;

use Syntax\SteamApi\Client;
use Syntax\SteamApi\Containers\Group as GroupContainer;

class Group extends Client
{
    public function GetGroupSummary($group)
    {
        // Set up the api details
        $this->method = 'memberslistxml';

        if (is_numeric($group)) {
            $this->url = 'http://steamcommunity.com/gid/';
        } else {
            $this->url = 'http://steamcommunity.com/groups/';
        }

        $this->url = $this->url . $group;

        // Set up the arguments
        $arguments = [
            'xml' => 1,
        ];

        // Get the client
        $client = $this->setUpXml($arguments);

        // Clean up the games
        $group = new GroupContainer($client);

It seems like $client defined by $this->setUpXml($arguments) on line 29 can be null; however, Syntax\SteamApi\Containers\Group::__construct() does not accept null, maybe add an additional type check?

        return $group;
    }
}