symphonycms / symphony-2

symphony/lib/boot/bundle.php

<?php

    /**
     * @package boot
     */

    // Set appropriate error reporting:
    error_reporting(E_ALL & ~E_NOTICE & ~E_DEPRECATED & ~E_STRICT);

    // Turn off old-style magic:
    ini_set('magic_quotes_runtime', false);

false of type false is incompatible with the type string expected by parameter $newvalue of ini_set().

    // Redirect to installer if it exists
    if (!file_exists(CONFIG)) {

The constant CONFIG was not found. Maybe you did not declare it correctly or list all dependencies?

        $bInsideInstaller = (bool)preg_match('%(/|\\\\)install(/|\\\\)index.php$%', server_safe('SCRIPT_FILENAME'));

        if (!$bInsideInstaller && Symphony::isInstallerAvailable()) {
            header(sprintf('Location: %s/install/', URL));

The constant URL was not found. Maybe you did not declare it correctly or list all dependencies?

            exit;
        } elseif (!$bInsideInstaller) {
            die('<h2>Error</h2><p>Could not locate Symphony configuration file. Please check <code>manifest/config.php</code> exists.</p>');
        }
    } else {
        // Load configuration file:
        include CONFIG;
        Symphony::initialiseConfiguration($settings);
        Symphony::initialiseErrorHandler();
        Symphony::initialiseDatabase();
        Symphony::initialiseExtensionManager();

        // Report all errors
        if (Symphony::Configuration()->get('error_reporting_all', 'symphony') === 'yes') {
            error_reporting(E_ALL);
        }

        // Handle custom admin paths, #702
        $adminPath = Symphony::Configuration()->get('admin-path', 'symphony');
        $adminPath = (is_null($adminPath)) ? 'symphony' :  $adminPath;

Inline shorthand IF statement requires 1 space after ELSE; 2 found

The condition is_null($adminPath) is always false.

        // getCurrentPage() always starts with / #2522
        $adminRegExp = '%^\/' . preg_quote($adminPath) . '\/%';

It seems like $adminPath can also be of type array; however, parameter $str of preg_quote() does only seem to accept string, maybe add an additional type check?

        if (preg_match($adminRegExp, getCurrentPage()) === 1) {
            $_GET['symphony-page'] = preg_replace($adminRegExp, '', getCurrentPage(), 1);

            if ($_GET['symphony-page'] == '') {
                unset($_GET['symphony-page']);
            }

            $_GET['mode'] = $_REQUEST['mode'] = 'administration';
        }

        /**
         * Returns the URL + /symphony. This should be used whenever the a developer
         * wants to link to the Symphony root
         * @since Symphony 2.2
         * @var string
         */
        define_safe('SYMPHONY_URL', URL . '/' . $adminPath);

        /**
         * Overload the default Symphony launcher logic.
         * @delegate ModifySymphonyLauncher
         * @since Symphony 2.5.0
         * @param string $context
         * '/all/'
         */
        Symphony::ExtensionManager()->notifyMembers(
            'ModifySymphonyLauncher', '/all/'
        );

        // Use default launcher:
        if (defined('SYMPHONY_LAUNCHER') === false) {
            define('SYMPHONY_LAUNCHER', 'symphony_launcher');
        }
    }