Issues in content.ajaxlog.php (master) - Issues in master - symphonycms/symphony-2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (3647)

symphony/content/content.ajaxlog.php (5 issues)

Labels

Coding Style 5
Comprehensibility 2

Severity

Informational 5

<?php
/**
 * @package content
 */
/**
 * The AjaxLog page accepts $_POST requests to write information to the
 * Symphony Log.
 */

class contentAjaxLog extends TextPage

{
    public function view()
    {
        if ($_REQUEST['error'] && Symphony::Log()) {
            Symphony::Log()->pushToLog(sprintf(
                    '%s - %s%s%s',
                    'Javascript',
                    $_REQUEST['error'],
                    ($_REQUEST['url'] ? " in file " . $_REQUEST['url'] : null),
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                    ($_REQUEST['line'] ? " on line " . $_REQUEST['line'] : null)
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
                ),
                E_ERROR, true
            );
        }
    }
}


1			<?php
2			/**
3			* @package content
4			*/
5			/**
6			* The AjaxLog page accepts $_POST requests to write information to the
7			* Symphony Log.
8			*/
9
10			class contentAjaxLog extends TextPage
			0 ignored issues – show Coding Style introduced 2019-03-19 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this This class is not in CamelCase format. Classes in PHP are usually named in CamelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. The whole name starts with a capital letter as well. Thus the name database provider becomes `DatabaseProvider`. Loading history...
11			{
12			public function view()
13			{
14			if ($_REQUEST['error'] && Symphony::Log()) {
15			Symphony::Log()->pushToLog(sprintf(
16			'%s - %s%s%s',
17			'Javascript',
18			$_REQUEST['error'],
19			($_REQUEST['url'] ? " in file " . $_REQUEST['url'] : null),
			0 ignored issues – show Coding Style introduced 2019-03-19 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Inline shorthand IF statement requires brackets around comparison Loading history... Coding Style Comprehensibility introduced 2019-03-19 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `in file` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
20			($_REQUEST['line'] ? " on line " . $_REQUEST['line'] : null)
			0 ignored issues – show Coding Style introduced 2019-03-19 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Inline shorthand IF statement requires brackets around comparison Loading history... Coding Style Comprehensibility introduced 2019-03-19 18:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The string literal `on line` does not require double quotes, as per coding-style, please use single quotes. PHP provides two ways to mark string literals. Either with single quotes `'literal'` or with double quotes `"literal"`. The difference between these is that string literals in double quotes may contain variables with are evaluated at run-time as well as escape sequences. String literals in single quotes on the other hand are evaluated very literally and the only two characters that needs escaping in the literal are the single quote itself (`\'`) and the backslash (`\\`). Every other character is displayed as is. Double quoted string literals may contain other variables or more complex escape sequences. <?php $singleQuoted = 'Value'; $doubleQuoted = "\tSingle is $singleQuoted"; print $doubleQuoted; will print an indented: `Single is Value` If your string literal does not contain variables or escape sequences, it should be defined using single quotes to make that fact clear. For more information on PHP string literals and available escape sequences see the PHP core documentation. Loading history...
21			),
22			E_ERROR, true
23			);
24			}
25			}
26			}
27

GitHub Access Token became invalid

Issues (3647)

symphony/content/content.ajaxlog.php (5 issues)

Labels

Severity

Introduced By

symphonycms / symphony-2

GitHub Access Token became invalid

Issues (3647)

symphony/content/content.ajaxlog.php (5 issues)

Labels

Severity

Introduced By

Duplication Side-by-Side

Filter issues like