symphonycms /
symphony-2
| Conditions | 42 |
| Paths | > 20000 |
| Total Lines | 323 |
| Code Lines | 190 |
| Lines | 30 |
| Ratio | 9.29 % |
| Changes | 3 | ||
| Bugs | 0 | Features | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 253 | public function __viewEdit() |
||
| 254 | { |
||
| 255 | $this->setPageType('form'); |
||
| 256 | $fields = array( |
||
| 257 | "title" => null, |
||
| 258 | "handle" => null, |
||
| 259 | "parent" => null, |
||
| 260 | "params" => null, |
||
| 261 | "type" => null, |
||
| 262 | "data_sources" => null |
||
| 263 | ); |
||
| 264 | $existing = $fields; |
||
| 265 | |||
| 266 | $nesting = (Symphony::Configuration()->get('pages_table_nest_children', 'symphony') === 'yes'); |
||
| 267 | |||
| 268 | // Verify page exists: |
||
| 269 | if ($this->_context['action'] === 'edit') { |
||
| 270 | if (!$page_id = (int)$this->_context['id']) { |
||
| 271 | redirect(SYMPHONY_URL . '/blueprints/pages/'); |
||
| 272 | } |
||
| 273 | |||
| 274 | $existing = PageManager::fetchPageByID($page_id); |
||
| 275 | |||
| 276 | if (!$existing) { |
||
| 277 | Administration::instance()->errorPageNotFound(); |
||
| 278 | } else { |
||
| 279 | $existing['type'] = PageManager::fetchPageTypes($page_id); |
||
| 280 | } |
||
| 281 | } |
||
| 282 | |||
| 283 | // Status message: |
||
| 284 | if (isset($this->_context['flag'])) { |
||
| 285 | $flag = $this->_context['flag']; |
||
| 286 | $parent_link_suffix = $message = ''; |
||
| 287 | $time = Widget::Time(); |
||
| 288 | |||
| 289 | if (isset($_REQUEST['parent']) && is_numeric($_REQUEST['parent'])) { |
||
| 290 | $parent_link_suffix = "?parent=" . $_REQUEST['parent']; |
||
| 291 | } elseif ($nesting && isset($existing) && !is_null($existing['parent'])) { |
||
| 292 | $parent_link_suffix = '?parent=' . $existing['parent']; |
||
| 293 | } |
||
| 294 | |||
| 295 | switch ($flag) { |
||
| 296 | case 'saved': |
||
| 297 | $message = __('Page updated at %s.', array($time->generate())); |
||
| 298 | break; |
||
| 299 | case 'created': |
||
| 300 | $message = __('Page created at %s.', array($time->generate())); |
||
| 301 | } |
||
| 302 | |||
| 303 | $this->pageAlert( |
||
| 304 | $message |
||
| 305 | . ' <a href="' . SYMPHONY_URL . '/blueprints/pages/new/' . $parent_link_suffix . '" accesskey="c">' |
||
| 306 | . __('Create another?') |
||
| 307 | . '</a> <a href="' . SYMPHONY_URL . '/blueprints/pages/" accesskey="a">' |
||
| 308 | . __('View all Pages') |
||
| 309 | . '</a>', |
||
| 310 | Alert::SUCCESS |
||
| 311 | ); |
||
| 312 | } |
||
| 313 | |||
| 314 | // Find values: |
||
| 315 | if (isset($_POST['fields'])) { |
||
| 316 | $fields = $_POST['fields']; |
||
| 317 | } elseif ($this->_context['action'] === 'edit') { |
||
| 318 | $fields = $existing; |
||
| 319 | |||
| 320 | if (!is_null($fields['type'])) { |
||
| 321 | $fields['type'] = implode(', ', $fields['type']); |
||
| 322 | } |
||
| 323 | |||
| 324 | $fields['data_sources'] = preg_split('/,/i', $fields['data_sources'], -1, PREG_SPLIT_NO_EMPTY); |
||
| 325 | $fields['events'] = preg_split('/,/i', $fields['events'], -1, PREG_SPLIT_NO_EMPTY); |
||
| 326 | View Code Duplication | } elseif (isset($_REQUEST['parent']) && is_numeric($_REQUEST['parent'])) { |
|
| 327 | $fields['parent'] = $_REQUEST['parent']; |
||
| 328 | } |
||
| 329 | |||
| 330 | $title = $fields['title']; |
||
| 331 | |||
| 332 | if (trim($title) === '') { |
||
| 333 | $title = $existing['title']; |
||
| 334 | } |
||
| 335 | |||
| 336 | $this->setTitle(__( |
||
| 337 | ($title ? '%1$s – %2$s – %3$s' : '%2$s – %3$s'), |
||
| 338 | array( |
||
| 339 | $title, |
||
| 340 | __('Pages'), |
||
| 341 | __('Symphony') |
||
| 342 | ) |
||
| 343 | )); |
||
| 344 | |||
| 345 | $page_id = isset($page_id) ? $page_id : null; |
||
| 346 | |||
| 347 | if (!empty($title)) { |
||
| 348 | $page_url = URL . '/' . PageManager::resolvePagePath($page_id) . '/'; |
||
| 349 | |||
| 350 | $this->appendSubheading($title, array( |
||
| 351 | Widget::Anchor(__('View Page'), $page_url, __('View Page on Frontend'), 'button', null, |
||
| 352 | array('target' => '_blank', 'accesskey' => 'v')) |
||
| 353 | )); |
||
| 354 | } else { |
||
| 355 | $this->appendSubheading(!empty($title) ? $title : __('Untitled')); |
||
| 356 | } |
||
| 357 | |||
| 358 | if (isset($page_id)) { |
||
| 359 | $this->insertBreadcrumbsUsingPageIdentifier($page_id, false); |
||
| 360 | } else { |
||
| 361 | $_GET['parent'] = isset($_GET['parent']) ? $_GET['parent'] : null; |
||
| 362 | $this->insertBreadcrumbsUsingPageIdentifier((int)$_GET['parent'], true); |
||
| 363 | } |
||
| 364 | |||
| 365 | // Title -------------------------------------------------------------- |
||
| 366 | |||
| 367 | $fieldset = new XMLElement('fieldset'); |
||
| 368 | $fieldset->setAttribute('class', 'settings'); |
||
| 369 | $fieldset->appendChild(new XMLElement('legend', __('Page Settings'))); |
||
| 370 | |||
| 371 | $label = Widget::Label(__('Name')); |
||
| 372 | $label->appendChild(Widget::Input( |
||
| 373 | 'fields[title]', General::sanitize($fields['title']) |
||
| 374 | )); |
||
| 375 | |||
| 376 | if (isset($this->_errors['title'])) { |
||
| 377 | $label = Widget::Error($label, $this->_errors['title']); |
||
| 378 | } |
||
| 379 | |||
| 380 | $fieldset->appendChild($label); |
||
| 381 | |||
| 382 | // Handle ------------------------------------------------------------- |
||
| 383 | |||
| 384 | $group = new XMLElement('div'); |
||
| 385 | $group->setAttribute('class', 'two columns'); |
||
| 386 | $column = new XMLElement('div'); |
||
| 387 | $column->setAttribute('class', 'column'); |
||
| 388 | |||
| 389 | $label = Widget::Label(__('Handle')); |
||
| 390 | $label->appendChild(Widget::Input( |
||
| 391 | 'fields[handle]', $fields['handle'] |
||
| 392 | )); |
||
| 393 | |||
| 394 | if (isset($this->_errors['handle'])) { |
||
| 395 | $label = Widget::Error($label, $this->_errors['handle']); |
||
| 396 | } |
||
| 397 | |||
| 398 | $column->appendChild($label); |
||
| 399 | |||
| 400 | // Parent --------------------------------------------------------- |
||
| 401 | |||
| 402 | $label = Widget::Label(__('Parent Page')); |
||
| 403 | |||
| 404 | $where = array( |
||
| 405 | sprintf('id != %d', $page_id) |
||
| 406 | ); |
||
| 407 | $pages = PageManager::fetch(false, array('id'), $where, 'title ASC'); |
||
| 408 | |||
| 409 | $options = array( |
||
| 410 | array('', false, '/') |
||
| 411 | ); |
||
| 412 | |||
| 413 | if (!empty($pages)) { |
||
| 414 | foreach ($pages as $page) { |
||
| 415 | $options[] = array( |
||
| 416 | $page['id'], |
||
| 417 | $fields['parent'] === $page['id'], |
||
| 418 | '/' . PageManager::resolvePagePath($page['id']) |
||
| 419 | ); |
||
| 420 | } |
||
| 421 | |||
| 422 | usort($options, array($this, '__compare_pages')); |
||
| 423 | } |
||
| 424 | |||
| 425 | $label->appendChild(Widget::Select( |
||
| 426 | 'fields[parent]', $options |
||
| 427 | )); |
||
| 428 | $column->appendChild($label); |
||
| 429 | $group->appendChild($column); |
||
| 430 | |||
| 431 | // Parameters --------------------------------------------------------- |
||
| 432 | |||
| 433 | $column = new XMLElement('div'); |
||
| 434 | $column->setAttribute('class', 'column'); |
||
| 435 | |||
| 436 | $label = Widget::Label(__('Parameters')); |
||
| 437 | $label->appendChild(Widget::Input( |
||
| 438 | 'fields[params]', $fields['params'], 'text', array('placeholder' => 'param1/param2') |
||
| 439 | )); |
||
| 440 | $column->appendChild($label); |
||
| 441 | |||
| 442 | // Type ----------------------------------------------------------- |
||
| 443 | |||
| 444 | $label = Widget::Label(__('Type')); |
||
| 445 | $label->appendChild(Widget::Input('fields[type]', $fields['type'])); |
||
| 446 | |||
| 447 | if (isset($this->_errors['type'])) { |
||
| 448 | $label = Widget::Error($label, $this->_errors['type']); |
||
| 449 | } |
||
| 450 | |||
| 451 | $column->appendChild($label); |
||
| 452 | |||
| 453 | $tags = new XMLElement('ul'); |
||
| 454 | $tags->setAttribute('class', 'tags'); |
||
| 455 | $tags->setAttribute('data-interactive', 'data-interactive'); |
||
| 456 | |||
| 457 | $types = PageManager::fetchAvailablePageTypes(); |
||
| 458 | |||
| 459 | foreach ($types as $type) { |
||
| 460 | $tags->appendChild(new XMLElement('li', $type)); |
||
| 461 | } |
||
| 462 | |||
| 463 | $column->appendChild($tags); |
||
| 464 | $group->appendChild($column); |
||
| 465 | $fieldset->appendChild($group); |
||
| 466 | $this->Form->appendChild($fieldset); |
||
| 467 | |||
| 468 | // Events ------------------------------------------------------------- |
||
| 469 | |||
| 470 | $fieldset = new XMLElement('fieldset'); |
||
| 471 | $fieldset->setAttribute('class', 'settings'); |
||
| 472 | $fieldset->appendChild(new XMLElement('legend', __('Page Resources'))); |
||
| 473 | |||
| 474 | $group = new XMLElement('div'); |
||
| 475 | $group->setAttribute('class', 'two columns'); |
||
| 476 | |||
| 477 | $label = Widget::Label(__('Events')); |
||
| 478 | $label->setAttribute('class', 'column'); |
||
| 479 | |||
| 480 | $events = ResourceManager::fetch(ResourceManager::RESOURCE_TYPE_EVENT, array(), array(), 'name ASC'); |
||
| 481 | $options = array(); |
||
| 482 | |||
| 483 | View Code Duplication | if (is_array($events) && !empty($events)) { |
|
| 484 | if (!isset($fields['events'])) { |
||
| 485 | $fields['events'] = array(); |
||
| 486 | } |
||
| 487 | |||
| 488 | foreach ($events as $name => $about) { |
||
| 489 | $options[] = array( |
||
| 490 | $name, |
||
| 491 | in_array($name, $fields['events']), |
||
| 492 | $about['name'] |
||
| 493 | ); |
||
| 494 | } |
||
| 495 | } |
||
| 496 | |||
| 497 | $label->appendChild(Widget::Select('fields[events][]', $options, array('multiple' => 'multiple'))); |
||
| 498 | $group->appendChild($label); |
||
| 499 | |||
| 500 | // Data Sources ------------------------------------------------------- |
||
| 501 | |||
| 502 | $label = Widget::Label(__('Data Sources')); |
||
| 503 | $label->setAttribute('class', 'column'); |
||
| 504 | |||
| 505 | $datasources = ResourceManager::fetch(ResourceManager::RESOURCE_TYPE_DS, array(), array(), 'name ASC'); |
||
| 506 | $options = array(); |
||
| 507 | |||
| 508 | View Code Duplication | if (is_array($datasources) && !empty($datasources)) { |
|
| 509 | if (!isset($fields['data_sources'])) { |
||
| 510 | $fields['data_sources'] = array(); |
||
| 511 | } |
||
| 512 | |||
| 513 | foreach ($datasources as $name => $about) { |
||
| 514 | $options[] = array( |
||
| 515 | $name, |
||
| 516 | in_array($name, $fields['data_sources']), |
||
| 517 | $about['name'] |
||
| 518 | ); |
||
| 519 | } |
||
| 520 | } |
||
| 521 | |||
| 522 | $label->appendChild(Widget::Select('fields[data_sources][]', $options, array('multiple' => 'multiple'))); |
||
| 523 | $group->appendChild($label); |
||
| 524 | $fieldset->appendChild($group); |
||
| 525 | $this->Form->appendChild($fieldset); |
||
| 526 | |||
| 527 | // Controls ----------------------------------------------------------- |
||
| 528 | |||
| 529 | /** |
||
| 530 | * After all Page related Fields have been added to the DOM, just before the |
||
| 531 | * actions. |
||
| 532 | * |
||
| 533 | * @delegate AppendPageContent |
||
| 534 | * @param string $context |
||
| 535 | * '/blueprints/pages/' |
||
| 536 | * @param XMLElement $form |
||
| 537 | * @param array $fields |
||
| 538 | * @param array $errors |
||
| 539 | */ |
||
| 540 | Symphony::ExtensionManager()->notifyMembers( |
||
| 541 | 'AppendPageContent', |
||
| 542 | '/blueprints/pages/', |
||
| 543 | array( |
||
| 544 | 'form' => &$this->Form, |
||
| 545 | 'fields' => &$fields, |
||
| 546 | 'errors' => $this->_errors |
||
| 547 | ) |
||
| 548 | ); |
||
| 549 | |||
| 550 | $div = new XMLElement('div'); |
||
| 551 | $div->setAttribute('class', 'actions'); |
||
| 552 | $div->appendChild(Widget::Input( |
||
| 553 | 'action[save]', ($this->_context['action'] === 'edit' ? __('Save Changes') : __('Create Page')), |
||
| 554 | 'submit', array('accesskey' => 's') |
||
| 555 | )); |
||
| 556 | |||
| 557 | View Code Duplication | if ($this->_context['action'] === 'edit') { |
|
| 558 | $button = new XMLElement('button', __('Delete')); |
||
| 559 | $button->setAttributeArray(array( |
||
| 560 | 'name' => 'action[delete]', |
||
| 561 | 'class' => 'button confirm delete', |
||
| 562 | 'title' => __('Delete this page'), |
||
| 563 | 'accesskey' => 'd', |
||
| 564 | 'data-message' => __('Are you sure you want to delete this page?') |
||
| 565 | )); |
||
| 566 | $div->appendChild($button); |
||
| 567 | } |
||
| 568 | |||
| 569 | $this->Form->appendChild($div); |
||
| 570 | |||
| 571 | if (isset($_REQUEST['parent']) && is_numeric($_REQUEST['parent'])) { |
||
| 572 | $this->Form->appendChild(new XMLElement('input', null, |
||
| 573 | array('type' => 'hidden', 'name' => 'parent', 'value' => $_REQUEST['parent']))); |
||
| 574 | } |
||
| 575 | } |
||
| 576 | |||
| 988 |
Loading history...
There are different options of fixing this problem.
If you want to be on the safe side, you can add an additional type-check:
If you are sure that the expression is traversable, you might want to add a doc comment cast to improve IDE auto-completion and static analysis:
Mark the issue as a false-positive: Just hover the remove button, in the top-right corner of this issue for more options.