GitHub Access Token became invalid

It seems like the GitHub access token used for retrieving details about this repository from GitHub became invalid. This might prevent certain types of inspections from being run (in particular, everything related to pull requests).
Please ask an admin of your repository to re-new the access token on this website.
Completed
Pull Request — integration (#2604)
by Brendan
04:35
created
symphony/lib/toolkit/class.pagemanager.php 1 patch
Doc Comments   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@  discard block
 block discarded – undo
22 22
      * @param array $fields
23 23
      *  Associative array of field names => values for the Page
24 24
      * @throws DatabaseException
25
-     * @return integer|boolean
25
+     * @return false|string
26 26
      *  Returns the Page ID of the created Page on success, false otherwise.
27 27
      */
28 28
     public static function add(array $fields)
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
      *
44 44
      * @param string $handle
45 45
      *  The handle of the page
46
-     * @return integer
46
+     * @return string
47 47
      *  The Page title
48 48
      */
49 49
     public static function fetchTitleFromHandle($handle)
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
      *
63 63
      * @param string $handle
64 64
      *  The handle of the page
65
-     * @return integer
65
+     * @return string
66 66
      *  The Page ID
67 67
      */
68 68
     public static function fetchIDFromHandle($handle)
@@ -116,7 +116,7 @@  discard block
 block discarded – undo
116 116
      *
117 117
      * @param string $name
118 118
      *  Name of the template
119
-     * @return mixed
119
+     * @return string|false
120 120
      *  String, which is the path to the template if the template is found,
121 121
      *  false otherwise
122 122
      */
@@ -512,10 +512,10 @@  discard block
 block discarded – undo
512 512
      *
513 513
      * @param integer|array $page_id
514 514
      *  The ID of the Page, or an array of ID's
515
-     * @param array $select (optional)
515
+     * @param string[] $select (optional)
516 516
      *  Accepts an array of columns to return from `tbl_pages`. If omitted,
517 517
      *  all columns from the table will be returned.
518
-     * @return array|null
518
+     * @return integer|null
519 519
      *  An associative array of Page information with the key being the column
520 520
      *  name from `tbl_pages` and the value being the data. If multiple Pages
521 521
      *  are found, an array of Pages will be returned. If no Pages are found
Please login to merge, or discard this patch.
symphony/lib/toolkit/class.sectionmanager.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -30,7 +30,7 @@  discard block
 block discarded – undo
30 30
      *    An associative of settings for a section with the key being
31 31
      *    a column name from `tbl_sections`
32 32
      * @throws DatabaseException
33
-     * @return integer
33
+     * @return false|string
34 34
      *    The newly created Section's ID
35 35
      */
36 36
     public static function add(array $settings)
@@ -184,7 +184,7 @@  discard block
 block discarded – undo
184 184
      *
185 185
      * @param string $handle
186 186
      *  The handle of the section
187
-     * @return integer
187
+     * @return string
188 188
      *  The Section ID
189 189
      */
190 190
     public static function fetchIDFromHandle($handle)
@@ -277,7 +277,7 @@  discard block
 block discarded – undo
277 277
      * @param integer $field_id
278 278
      *    the field ID of the linked section's linked field.
279 279
      * @throws DatabaseException
280
-     * @return boolean
280
+     * @return PDOStatement
281 281
      */
282 282
     public static function removeSectionAssociation($field_id)
283 283
     {
Please login to merge, or discard this patch.
symphony/content/content.publish.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -127,6 +127,9 @@  discard block
 block discarded – undo
127 127
         return $this->filteringForm;
128 128
     }
129 129
 
130
+    /**
131
+     * @param Section $section
132
+     */
130 133
     public function createFilteringDuplicator($section)
131 134
     {
132 135
         $div = new XMLElement('div');
@@ -145,6 +148,9 @@  discard block
 block discarded – undo
145 148
         $this->filteringForm->appendChild($div);
146 149
     }
147 150
 
151
+    /**
152
+     * @param XMLElement $wrapper
153
+     */
148 154
     private function createFieldFilters(&$wrapper, $section)
149 155
     {
150 156
         $filters = $_GET['filter'];
@@ -284,6 +290,9 @@  discard block
 block discarded – undo
284 290
         return $comparisons;
285 291
     }
286 292
 
293
+    /**
294
+     * @param XMLElement $wrapper
295
+     */
287 296
     private function createFilterSuggestions(&$wrapper, $data)
288 297
     {
289 298
         $ul = new XMLElement('ul');
Please login to merge, or discard this patch.
symphony/lib/toolkit/class.database.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -184,7 +184,7 @@
 block discarded – undo
184 184
      *
185 185
      * @param string $handle
186 186
      *  The handle of the section
187
-     * @return integer
187
+     * @return string
188 188
      *  The Section ID
189 189
      */
190 190
     public static function fetchIDFromHandle($handle)
Please login to merge, or discard this patch.
symphony/lib/toolkit/class.field.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -1222,7 +1222,7 @@  discard block
 block discarded – undo
1222 1222
      * If the date type is set, only the calendar will be shown in the suggestion dropdown.
1223 1223
      *
1224 1224
      * @since Symphony 2.6.0
1225
-     * @return array
1225
+     * @return string[]
1226 1226
      */
1227 1227
     public function fetchSuggestionTypes()
1228 1228
     {
@@ -1337,7 +1337,7 @@  discard block
 block discarded – undo
1337 1337
      * @link http://dev.mysql.com/doc/refman/5.5/en/regexp.html
1338 1338
      * @param string $filter
1339 1339
      *  The full filter, eg. `regexp: ^[a-d]`
1340
-     * @param array $columns
1340
+     * @param string[] $columns
1341 1341
      *  The array of columns that need the given `$filter` applied to. The conditions
1342 1342
      *  will be added using `OR`.
1343 1343
      * @param string $joins
@@ -1508,7 +1508,7 @@  discard block
 block discarded – undo
1508 1508
      *  The data for this field from it's `tbl_entry_data_{id}` table
1509 1509
      * @param integer $entry_id
1510 1510
      *  The optional id of this field entry instance
1511
-     * @return string|array
1511
+     * @return string
1512 1512
      *  The formatted value to be used as the parameter. Note that this can be
1513 1513
      *  an array or a string. When returning multiple values use array, otherwise
1514 1514
      *  use string.
Please login to merge, or discard this patch.
symphony/lib/toolkit/class.mysql.php 1 patch
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -353,7 +353,7 @@  discard block
 block discarded – undo
353 353
      * Returns the last insert ID from the previous query. This is
354 354
      * the value from an auto_increment field.
355 355
      *
356
-     * @return integer
356
+     * @return string
357 357
      *  The last interested row's ID
358 358
      */
359 359
     public function getInsertID()
@@ -380,7 +380,7 @@  discard block
 block discarded – undo
380 380
      *  conflicts. By default this is set to false, which will not update the data and
381 381
      *  would return an SQL error
382 382
      * @throws DatabaseException
383
-     * @return boolean
383
+     * @return PDOStatement
384 384
      */
385 385
     public function insert(array $fields, $table, $updateOnDuplicate=false)
386 386
     {
@@ -443,7 +443,7 @@  discard block
 block discarded – undo
443 443
      *  A WHERE statement for this UPDATE statement, defaults to null
444 444
      *  which will update all rows in the $table
445 445
      * @param array $params
446
-     * @return bool
446
+     * @return PDOStatement
447 447
      */
448 448
     public function update($fields, $table, $where = null, $params = array())
449 449
     {
@@ -469,7 +469,7 @@  discard block
 block discarded – undo
469 469
      *  A WHERE statement for this DELETE statement, defaults to null,
470 470
      *  which will delete all rows in the $table
471 471
      * @throws DatabaseException
472
-     * @return boolean
472
+     * @return PDOStatement
473 473
      */
474 474
     public function delete($table, $where = null, array $params = array())
475 475
     {
@@ -695,7 +695,7 @@  discard block
 block discarded – undo
695 695
      * @throws Exception
696 696
      * @param string $sql
697 697
      *  A string containing SQL queries delimited by `;`
698
-     * @return boolean
698
+     * @return boolean|null
699 699
      *  If one of the queries fails, false will be returned and no further queries
700 700
      *  will be executed, otherwise true will be returned.
701 701
      */
Please login to merge, or discard this patch.
symphony/lib/toolkit/class.general.php 1 patch
Doc Comments   +12 added lines, -8 removed lines patch added patch discarded remove patch
@@ -104,7 +104,7 @@  discard block
 block discarded – undo
104 104
      * @param boolean $isFile (optional)
105 105
      *  if this is true, the method will attempt to read from a file, `$data`
106 106
      *  instead.
107
-     * @param mixed $xsltProcessor (optional)
107
+     * @param XsltProcess $xsltProcessor (optional)
108 108
      *  if set, the validation will be done using this XSLT processor rather
109 109
      *  than the built in XML parser. the default is null.
110 110
      * @param string $encoding (optional)
@@ -491,7 +491,7 @@  discard block
 block discarded – undo
491 491
      *  the string to operate on
492 492
      * @param integer $val
493 493
      *  the number to compare lengths with
494
-     * @return string|boolean
494
+     * @return string
495 495
      *  the resulting string or false on failure.
496 496
      */
497 497
     public static function substrmin($str, $val)
@@ -508,7 +508,7 @@  discard block
 block discarded – undo
508 508
      *  the string to operate on
509 509
      * @param integer $val
510 510
      *  the number to compare lengths with
511
-     * @return string|boolean
511
+     * @return string
512 512
      *  the resulting string or false on failure.
513 513
      */
514 514
     public static function substrmax($str, $val)
@@ -523,7 +523,7 @@  discard block
 block discarded – undo
523 523
      *  the string to extract the characters from.
524 524
      * @param integer $num
525 525
      *  the number of characters to extract.
526
-     * @return string|boolean
526
+     * @return string
527 527
      *  a string containing the last `$num` characters of the
528 528
      *  input string, or false on failure.
529 529
      */
@@ -540,7 +540,7 @@  discard block
 block discarded – undo
540 540
      *  the string to extract the characters from.
541 541
      * @param integer $num
542 542
      *  the number of characters to extract.
543
-     * @return string|boolean
543
+     * @return string
544 544
      *  a string containing the last `$num` characters of the
545 545
      *  input string, or false on failure.
546 546
      */
@@ -737,6 +737,10 @@  discard block
 block discarded – undo
737 737
     public static function getPostData()
738 738
     {
739 739
         if (!function_exists('merge_file_post_data')) {
740
+
741
+            /**
742
+             * @param string $type
743
+             */
740 744
             function merge_file_post_data($type, array $file, &$post)
741 745
             {
742 746
                 foreach ($file as $key => $value) {
@@ -955,7 +959,7 @@  discard block
 block discarded – undo
955 959
      *  the path of the file to write.
956 960
      * @param mixed $data
957 961
      *  the data to write to the file.
958
-     * @param integer|null $perm (optional)
962
+     * @param integer $perm (optional)
959 963
      *  the permissions as an octal number to set set on the resulting file.
960 964
      *  this defaults to 0644 (if omitted or set to null)
961 965
      * @param string $mode (optional)
@@ -1156,7 +1160,7 @@  discard block
 block discarded – undo
1156 1160
      * @param mixed $strip_root (optional)
1157 1161
      *  If null, the full path to the file will be returned, otherwise the value
1158 1162
      *  of `strip_root` will be removed from the file path.
1159
-     * @param array $exclude (optional)
1163
+     * @param string[] $exclude (optional)
1160 1164
      *  ignore directories listed in this array. this defaults to an empty array.
1161 1165
      * @param boolean $ignore_hidden (optional)
1162 1166
      *  ignore hidden directory (i.e.directories that begin with a period). this defaults
@@ -1208,7 +1212,7 @@  discard block
 block discarded – undo
1208 1212
      * @param string $dir (optional)
1209 1213
      *  the path of the directory to construct the multi-dimensional array
1210 1214
      *  for. this defaults to '.'.
1211
-     * @param array|string $filters (optional)
1215
+     * @param string $filters (optional)
1212 1216
      *  either a regular expression to filter the files by or an array of
1213 1217
      *  files to include.
1214 1218
      * @param boolean $recurse (optional)
Please login to merge, or discard this patch.
install/lib/Installer.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -75,7 +75,7 @@
 block discarded – undo
75 75
     /**
76 76
      * Overrides the default `initialiseLog()` method and writes logs to  `manifest/logs/install`
77 77
      *
78
-     * @param null $filename
78
+     * @param string $filename
79 79
      * @return boolean|void
80 80
      * @throws Exception
81 81
      */
Please login to merge, or discard this patch.
install/lib/InstallerPage.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -141,6 +141,9 @@
 block discarded – undo
141 141
         }
142 142
     }
143 143
 
144
+    /**
145
+     * @param string $message
146
+     */
144 147
     private function __appendError(array $codes, XMLElement &$element, $message = null)
145 148
     {
146 149
         if (is_null($message)) {
Please login to merge, or discard this patch.