DynamicXMLDatasource

Complexity

Total Complexity

34

Size/Duplication

Total Lines	198
Duplicated Lines	0 %

Importance

Changes

0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
F	execute()	0	186	32

<?php

/**
 * @package data-sources
 */
/**
 * The `DynamicXMLDatasource` allows a user to retrieve XML from an URL.
 * This datasource supports namespaces, partial results using XPath and
 * caching the result for a number of minutes.
 *
 * @since Symphony 2.3
 *
 * @deprecated As of Symphony 2.6.0 this class is deprecated. Please
 * use the Remote Datasource extensions since it provides more features and
 * is more robust. It should be completely removed in Symphony 3.
 *
 */

require_once TOOLKIT . '/class.gateway.php';

The constant TOOLKIT was not found. Maybe you did not declare it correctly or list all dependencies?

require_once TOOLKIT . '/class.xsltprocess.php';
require_once CORE . '/class.cacheable.php';

The constant CORE was not found. Maybe you did not declare it correctly or list all dependencies?

class DynamicXMLDatasource extends Datasource
{
    public function __construct($env = null, $process_params = true)
    {
        if (Symphony::Log()) {
            Symphony::Log()->pushDeprecateWarningToLog('new DynamicXMLDatasource()', 'new RemoteDatasource()', array(
                'alternative-format' => __('Please install the Remote Datasource extension and use `%s` instead.'),
            ));
        }
        parent::__construct($env, $process_params);
    }

    public function execute(array &$param_pool = null)
    {
        $result = new XMLElement($this->dsParamROOTELEMENT);

The property dsParamROOTELEMENT does not exist on DynamicXMLDatasource. Did you maybe forget to declare it?

        $this->dsParamURL = $this->parseParamURL($this->dsParamURL);

The property dsParamURL does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if (isset($this->dsParamXPATH)) {
            $this->dsParamXPATH = $this->__processParametersInString($this->dsParamXPATH, $this->_env);

The property dsParamXPATH does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        $stylesheet = new XMLElement('xsl:stylesheet');
        $stylesheet->setAttributeArray(array('version' => '1.0', 'xmlns:xsl' => 'http://www.w3.org/1999/XSL/Transform'));

        $output = new XMLElement('xsl:output');
        $output->setAttributeArray(array('method' => 'xml', 'version' => '1.0', 'encoding' => 'utf-8', 'indent' => 'yes', 'omit-xml-declaration' => 'yes'));
        $stylesheet->appendChild($output);

        $template = new XMLElement('xsl:template');
        $template->setAttribute('match', '/');

        $instruction = new XMLElement('xsl:copy-of');

        // Namespaces
        if (isset($this->dsParamFILTERS) && is_array($this->dsParamFILTERS)) {
            foreach ($this->dsParamFILTERS as $name => $uri) {
                $instruction->setAttribute('xmlns' . ($name ? ":{$name}" : null), $uri);
            }
        }

        // XPath
        $instruction->setAttribute('select', $this->dsParamXPATH);

        $template->appendChild($instruction);
        $stylesheet->appendChild($template);

        $stylesheet->setIncludeHeader(true);

        $xsl = $stylesheet->generate(true);

        $cache_id = md5($this->dsParamURL . serialize($this->dsParamFILTERS) . $this->dsParamXPATH);

        $cache = new Cacheable(Symphony::Database());

Symphony::Database() of type MySQL is incompatible with the type iCache expected by parameter $cacheProvider of Cacheable::__construct().

        $cachedData = $cache->read($cache_id);
        $writeToCache = false;
        $valid = true;
        $creation = DateTimeObj::get('c');
        $timeout = (isset($this->dsParamTIMEOUT)) ? (int)max(1, $this->dsParamTIMEOUT) : 6;

The property dsParamTIMEOUT does not exist on DynamicXMLDatasource. Did you mean dsParamLIMIT?

        // Execute if the cache doesn't exist, or if it is old.
        if (
            (!is_array($cachedData) || empty($cachedData)) // There's no cache.
            || (time() - $cachedData['creation']) > ($this->dsParamCACHE * 60) // The cache is old.

The property dsParamCACHE does not exist on DynamicXMLDatasource. Did you mean dsParamXPATH?

        ) {
            if (Mutex::acquire($cache_id, $timeout, TMP)) {

The method acquire() does not exist on Mutex.

The constant TMP was not found. Maybe you did not declare it correctly or list all dependencies?

                $ch = new Gateway;
                $ch->init($this->dsParamURL);
                $ch->setopt('TIMEOUT', $timeout);
                $ch->setopt('HTTPHEADER', array('Accept: text/xml, */*'));

                $data = $ch->exec();
                $info = $ch->getInfoLast();

                Mutex::release($cache_id, TMP);

The method release() does not exist on Mutex.

                $data = trim($data);
                $writeToCache = true;

                // Handle any response that is not a 200, or the content type does not include XML, plain or text
                if ((int)$info['http_code'] !== 200 || !preg_match('/(xml|plain|text)/i', $info['content_type'])) {
                    $writeToCache = false;

The assignment to $writeToCache is dead and can be removed.

                    $result->setAttribute('valid', 'false');

                    // 28 is CURLE_OPERATION_TIMEOUTED
                    if ($info['curl_error'] == 28) {
                        $result->appendChild(
                            new XMLElement('error',
                                sprintf('Request timed out. %d second limit reached.', $timeout)
                            )
                        );
                    } else {
                        $result->appendChild(
                            new XMLElement('error',
                                sprintf('Status code %d was returned. Content-type: %s', $info['http_code'], $info['content_type'])
                            )
                        );
                    }

                    return $result;

                    // Handle where there is `$data`
                } elseif (strlen($data) > 0) {
                    // If the XML doesn't validate..
                    if (!General::validateXML($data, $errors, false, new XsltProcess)) {
                        $writeToCache = false;
                    }

                    // If the `$data` is invalid, return a result explaining why
                    if ($writeToCache === false) {
                        $element = new XMLElement('errors');

                        $result->setAttribute('valid', 'false');

                        $result->appendChild(new XMLElement('error', __('Data returned is invalid.')));

                        foreach ($errors as $e) {
                            if (strlen(trim($e['message'])) == 0) {
                                continue;
                            }

                            $element->appendChild(new XMLElement('item', General::sanitize($e['message'])));
                        }

                        $result->appendChild($element);

                        return $result;
                    }

                    // If `$data` is empty, set the `force_empty_result` to true.
                } elseif (strlen($data) == 0) {
                    $this->_force_empty_result = true;
                }

                // Failed to acquire a lock
            } else {
                $result->appendChild(
                    new XMLElement('error', __('The %s class failed to acquire a lock, check that %s exists and is writable.', array(
                        '<code>Mutex</code>',
                        '<code>' . TMP . '</code>'
                    )))
                );
            }

            // The cache is good, use it!
        } else {
            $data = trim($cachedData['data']);
            $creation = DateTimeObj::get('c', $cachedData['creation']);
        }

        // If `$writeToCache` is set to false, invalidate the old cache if it existed.
        if (is_array($cachedData) && !empty($cachedData) && $writeToCache === false) {
            $data = trim($cachedData['data']);
            $valid = false;
            $creation = DateTimeObj::get('c', $cachedData['creation']);

            if (empty($data)) {
                $this->_force_empty_result = true;
            }
        }

        // If `force_empty_result` is false and `$result` is an instance of
        // XMLElement, build the `$result`.
        if (!$this->_force_empty_result && is_object($result)) {
            $proc = new XsltProcess;
            $ret = $proc->process($data, $xsl);

The variable $data does not seem to be defined for all execution paths leading up to this point.

            if ($proc->isErrors()) {
                $result->setAttribute('valid', 'false');
                $error = new XMLElement('error', __('Transformed XML is invalid.'));
                $result->appendChild($error);
                $element = new XMLElement('errors');

                foreach ($proc->getError() as $e) {
                    if (strlen(trim($e['message'])) == 0) {
                        continue;
                    }

                    $element->appendChild(new XMLElement('item', General::sanitize($e['message'])));
                }

                $result->appendChild($element);
            } elseif (strlen(trim($ret)) == 0) {

It seems like $ret can also be of type false; however, parameter $str of trim() does only seem to accept string, maybe add an additional type check?

                $this->_force_empty_result = true;
            } else {
                if ($writeToCache) {
                    $cache->write($cache_id, $data, $this->dsParamCACHE);
                }

                $result->setValue(PHP_EOL . str_repeat("\t", 2) . preg_replace('/([\r\n]+)/', "$1\t", $ret));
                $result->setAttribute('status', ($valid === true ? 'fresh' : 'stale'));
                $result->setAttribute('creation', $creation);

It seems like $creation can also be of type false; however, parameter $value of XMLElement::setAttribute() does only seem to accept string, maybe add an additional type check?

            }
        }

        return $result;
    }
}