SectionEvent::processSendMailFilter()

Complexity

Conditions	15
Paths	1020

Size

Total Lines	111
Code Lines	60

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function processSendMailFilter(XMLElement $result, array $send_email, array &$fields, Section $section, Entry $entry)
    {
        $fields['recipient']        = self::replaceFieldToken($send_email['recipient'], $fields);
        $fields['recipient']        = preg_split('/\,/i', $fields['recipient'], -1, PREG_SPLIT_NO_EMPTY);
        $fields['recipient']        = array_map('trim', $fields['recipient']);

It seems like $fields['recipient'] can also be of type false; however, parameter $arr1 of array_map() does only seem to accept array, maybe add an additional type check?

        $fields['subject']          = self::replaceFieldToken($send_email['subject'], $fields, __('[Symphony] A new entry was created on %s', array(Symphony::Configuration()->get('sitename', 'general'))));
        $fields['body']             = self::replaceFieldToken($send_email['body'], $fields, null, false, false);
        $fields['sender-email']     = self::replaceFieldToken($send_email['sender-email'], $fields);
        $fields['sender-name']      = self::replaceFieldToken($send_email['sender-name'], $fields);

        $fields['reply-to-name']    = self::replaceFieldToken($send_email['reply-to-name'], $fields);
        $fields['reply-to-email']   = self::replaceFieldToken($send_email['reply-to-email'], $fields);

        $edit_link = SYMPHONY_URL . '/publish/' . $section->get('handle') . '/edit/' . $entry->get('id').'/';

Are you sure $entry->get('id') of type null|array|mixed can be used in concatenation?

The constant SYMPHONY_URL was not found. Maybe you did not declare it correctly or list all dependencies?

Are you sure $section->get('handle') of type string|array can be used in concatenation?

        $language = Symphony::Configuration()->get('lang', 'symphony');
        $template_path = Event::getNotificationTemplate($language);

It seems like $language can also be of type array; however, parameter $language of Event::getNotificationTemplate() does only seem to accept string, maybe add an additional type check?

        $body = sprintf(file_get_contents($template_path), $section->get('name'), $edit_link);

It seems like $template_path can also be of type false; however, parameter $filename of file_get_contents() does only seem to accept string, maybe add an additional type check?

It seems like $section->get('name') can also be of type array; however, parameter $args of sprintf() does only seem to accept string, maybe add an additional type check?

        if (is_array($fields['body'])) {

The condition is_array($fields['body']) is always false.

            foreach ($fields['body'] as $field_handle => $value) {
                $body .= "// $field_handle" . PHP_EOL . $value . PHP_EOL . PHP_EOL;
            }
        } else {
            $body .= $fields['body'];
        }

        // Loop over all the recipients and attempt to send them an email
        // Errors will be appended to the Event XML
        $errors = array();

        foreach ($fields['recipient'] as $recipient) {
            $author = AuthorManager::fetchByUsername($recipient);

            if (empty($author)) {
                $errors['recipient'][$recipient] = __('Recipient not found');
                continue;
            }

            $email = Email::create();

            // Exceptions are also thrown in the settings functions, not only in the send function.
            // Those Exceptions should be caught too.
            try {
                $email->recipients = array(

The property recipients does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                    $author->get('first_name') => $author->get('email')
                );

                if ($fields['sender-name'] != null) {
                    $email->sender_name = $fields['sender-name'];

The property sender_name does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                }

                if ($fields['sender-email'] != null) {
                    $email->sender_email_address = $fields['sender-email'];

The property sender_email_address does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                }

                if ($fields['reply-to-name'] != null) {
                    $email->reply_to_name = $fields['reply-to-name'];

The property reply_to_name does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                }

                if ($fields['reply-to-email'] != null) {
                    $email->reply_to_email_address = $fields['reply-to-email'];

The property reply_to_email_address does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                }

                $email->text_plain = str_replace('<!-- RECIPIENT NAME -->', $author->get('first_name'), $body);

The property text_plain does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                $email->subject = $fields['subject'];

The property subject does not exist on EmailGateway. Since you implemented __set, consider adding a @property annotation.

                $email->send();
            } catch (EmailValidationException $e) {
                $errors['address'][$author->get('email')] = $e->getMessage();

                // The current error array does not permit custom tags.
                // Therefore, it is impossible to set a "proper" error message.
                // Will return the failed email address instead.
            } catch (EmailGatewayException $e) {
                $errors['gateway'][$author->get('email')] = $e->getMessage();

                // Because we don't want symphony to break because it can not send emails,
                // all exceptions are logged silently.
                // Any custom event can change this behaviour.
            } catch (EmailException $e) {
                $errors['email'][$author->get('email')] = $e->getMessage();
            }
        }

        // If there were errors, output them to the event
        if (!empty($errors)) {
            $xml = self::buildFilterElement('send-email', 'failed');

            foreach ($errors as $type => $messages) {
                $xType = new XMLElement('error');
                $xType->setAttribute('error-type', $type);

                foreach ($messages as $recipient => $message) {
                    $xType->appendChild(
                        new XMLElement('message', General::wrapInCDATA($message), array(
                            'recipient' => $recipient
                        ))
                    );
                }

                $xml->appendChild($xType);
            }

            $result->appendChild($xml);
        } else {
            $result->appendChild(
                self::buildFilterElement('send-email', 'passed')
            );
        }

        return $result;
    }