+global\SectionDatasource::execute()

Complexity

Conditions	52
Paths	> 20000

Size

Total Lines	204
Code Lines	115

Duplication

Lines	10
Ratio	4.9 %

Importance

Changes

0

<?php
            $this->dsParamPAGINATERESULTS === 'yes')

The property dsParamPAGINATERESULTS does not exist on SectionDatasource. Did you maybe forget to declare it?

            && isset($this->dsParamLIMIT) && General::intval($this->dsParamLIMIT) >= 0;

        $section = (new SectionManager)
            ->select()
            ->section($this->getSource())
            ->execute()
            ->next();

        if (!$section) {

$section is of type Section, thus it always evaluated to true.

            $about = $this->about();
            trigger_error(__('The Section, %s, associated with the Data source, %s, could not be found.', array($this->getSource(), '<code>' . $about['name'] . '</code>')), E_USER_ERROR);
        }

        $sectioninfo = new XMLElement('section', General::sanitize($section->get('name')), array(

It seems like $section->get('name') can also be of type array; however, parameter $source of General::sanitize() does only seem to accept string, maybe add an additional type check?

            'id' => $section->get('id'),
            'handle' => $section->get('handle')
        ));

        if ($this->_force_empty_result == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            if ($this->dsParamREDIRECTONREQUIRED === 'yes') {

The property dsParamREDIRECTONREQUIRED does not exist on SectionDatasource. Did you maybe forget to declare it?

                throw new FrontendPageNotFoundException;
            }

            $this->_force_empty_result = false; //this is so the section info element doesn't disappear.
            $error = new XMLElement('error', __("Data source not executed, required parameter is missing."), array(
                'required-param' => $this->dsParamREQUIREDPARAM

The property dsParamREQUIREDPARAM does not exist on SectionDatasource. Did you maybe forget to declare it?

            ));
            $result->appendChild($error);
            $result->prependChild($sectioninfo);

            return $result;
        }

        if ($this->_negate_result == true) {

It seems like you are loosely comparing two booleans. Considering using the strict comparison === instead.

            if ($this->dsParamREDIRECTONFORBIDDEN === 'yes') {

The property dsParamREDIRECTONFORBIDDEN does not exist on SectionDatasource. Did you maybe forget to declare it?

                throw new FrontendPageNotFoundException;
            }

            $this->_negate_result = false; //this is so the section info element doesn't disappear.
            $result = $this->negateXMLSet();
            $result->prependChild($sectioninfo);

            return $result;
        }

        if (is_array($this->dsParamINCLUDEDELEMENTS)) {
            $include_pagination_element = in_array('system:pagination', $this->dsParamINCLUDEDELEMENTS);
        } else {
            $this->dsParamINCLUDEDELEMENTS = array();

The property dsParamINCLUDEDELEMENTS does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        if (isset($this->dsParamPARAMOUTPUT) && !is_array($this->dsParamPARAMOUTPUT)) {
            $this->dsParamPARAMOUTPUT = array($this->dsParamPARAMOUTPUT);

The property dsParamPARAMOUTPUT does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }

        $this->_can_process_system_parameters = $this->canProcessSystemParameters();

The property _can_process_system_parameters does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        // combine `INCLUDEDELEMENTS`, `PARAMOUTPUT` and `GROUP` into an
        // array of field handles to optimise the `EntryManager` queries
        $datasource_schema = $this->dsParamINCLUDEDELEMENTS;

        if (is_array($this->dsParamPARAMOUTPUT)) {
            $datasource_schema = array_merge($datasource_schema, $this->dsParamPARAMOUTPUT);
        }

        if ($this->dsParamGROUP) {

The property dsParamGROUP does not exist on SectionDatasource. Did you mean dsParamSORT?

            $datasource_schema[] = FieldManager::fetchHandleFromID($this->dsParamGROUP);
        }

        // Create our query object
        $entriesQuery = (new EntryManager)
            ->select($datasource_schema)
            ->section($this->getSource());

        // Process Filters
        $this->processFilters($entriesQuery);

        // Process Sorting
        $entriesQuery->sort((string)$this->dsParamSORT, $this->dsParamORDER);

        // Configure pagination in the query
        if ($requiresPagination) {
            $entriesQuery->paginate($this->dsParamSTARTPAGE, $this->dsParamLIMIT);
        }

        // Execute
        $pagination = $entriesQuery->execute()->pagination();
        $entries = $pagination->rows();

        /**
         * Immediately after building entries allow modification of the Data Source entries array
         *
         * @delegate DataSourceEntriesBuilt
         * @param string $context
         * '/frontend/'
         * @param Datasource $datasource
         * @param array $entries
         * @param array $filters
         */
        Symphony::ExtensionManager()->notifyMembers('DataSourceEntriesBuilt', '/frontend/', array(
            'datasource' => &$this,
            'entries' => &$entries,
            'filters' => $this->dsParamFILTERS
        ));

        $entries_per_page = $requiresPagination
            ? $pagination->pageSize()
            : $pagination->totalEntries();

        if (empty($entries)) {
            if ($this->dsParamREDIRECTONEMPTY === 'yes') {

The property dsParamREDIRECTONEMPTY does not exist on SectionDatasource. Did you maybe forget to declare it?

                throw new FrontendPageNotFoundException;
            }

            $this->_force_empty_result = false;
            $result = $this->emptyXMLSet();
            $result->prependChild($sectioninfo);

            if ($include_pagination_element) {

The variable $include_pagination_element does not seem to be defined for all execution paths leading up to this point.

                $pagination_element = General::buildPaginationElement(0, 0, $entries_per_page);

                if ($pagination_element instanceof XMLElement && $result instanceof XMLElement) {

$result is always a sub-type of XMLElement.

                    $result->prependChild($pagination_element);
                }
            }
        } else {
            if (!$this->_param_output_only) {
                $result->appendChild($sectioninfo);

                if ($include_pagination_element) {
                    $pagination_element = General::buildPaginationElement(
                        $pagination->totalEntries(),
                        $pagination->totalPages(),
                        $entries_per_page,
                        $pagination->currentPage()
                    );

                    if ($pagination_element instanceof XMLElement && $result instanceof XMLElement) {

$result is always a sub-type of XMLElement.

                        $result->prependChild($pagination_element);
                    }
                }
            }

            if (!isset($this->dsParamASSOCIATEDENTRYCOUNTS) || $this->dsParamASSOCIATEDENTRYCOUNTS === 'yes') {

The property dsParamASSOCIATEDENTRYCOUNTS does not exist on SectionDatasource. Did you maybe forget to declare it?

                $this->_associated_sections = $section->fetchChildAssociations();

The property _associated_sections does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }

            // If the datasource require's GROUPING
            if (isset($this->dsParamGROUP)) {
                if (!isset(self::$_fieldPool[$this->dsParamGROUP])) {
                    self::$_fieldPool[$this->dsParamGROUP] = (new FieldManager)
                        ->select()
                        ->field($this->dsParamGROUP)
                        ->execute()
                        ->next();
                }
                if (self::$_fieldPool[$this->dsParamGROUP] == null) {
                    throw new SymphonyErrorPage(vsprintf("The field used for grouping '%s' cannot be found.", $this->dsParamGROUP));
                }

                $groups = self::$_fieldPool[$this->dsParamGROUP]->groupRecords($entries);

                foreach ($groups as $element => $group) {
                    foreach ($group as $g) {
                        $result->appendChild(
                            $this->processRecordGroup($element, $g)
                        );
                    }
                }
            } else {
                if (isset($entries[0])) {
                    $data = $entries[0]->getData();
                    if (!empty($data)) {
                        $pool = (new FieldManager)
                            ->select()
                            ->fields(array_keys($data))
                            ->execute()
                            ->rowsIndexedByColumn('id');
                        self::$_fieldPool += $pool;
                    }
                }

                foreach ($entries as $entry) {
                    $xEntry = $this->processEntry($entry);

                    if ($xEntry instanceof XMLElement) {
                        $result->appendChild($xEntry);
                    }
                }
            }
        }

        $param_pool = $this->_param_pool;

        return $result;
    }
}