DoctrineGenerator::doBuild() - Code Metrics - symfony2admingenerator/GeneratorBundle - Measure and Improve Code Quality continuously with Scrutinizer

DoctrineGenerator::doBuild() B
last analyzed 2019-08-07 21:50 UTC

↳ Parent: DoctrineGenerator

Complexity

Conditions	8
Paths	128

Size

Total Lines

Duplication

Lines	69
Ratio	100 %

Importance

Changes

Metric	Value
dl	69
loc	69
rs	7.2452
c	0
b	0
f	0
cc	8
nc	128
nop	0

How to fix Long Method

<?php

namespace Admingenerator\GeneratorBundle\Generator;

use Admingenerator\GeneratorBundle\Builder\Generator as AdminGenerator;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ListBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ListBuilderTemplate;
use Admingenerator\GeneratorBundle\Builder\Doctrine\NestedListBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\NestedListBuilderTemplate;
use Admingenerator\GeneratorBundle\Builder\Doctrine\FiltersBuilderType;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ExcelBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderTemplate;
use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderType;
use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderTemplate;
use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderType;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ShowBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ShowBuilderTemplate;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ActionsBuilderAction;
use Admingenerator\GeneratorBundle\Builder\Doctrine\ActionsBuilderTemplate;

class DoctrineGenerator extends Generator

{
    /**
     * (non-PHPdoc)
     * @see Generator/Admingenerator\GeneratorBundle\Generator.Generator::doBuild()
     */
    protected function doBuild()
    {
        $this->validateYaml();

        $generator = new AdminGenerator($this->cache_dir, $this->getGeneratorYml());
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $generator->setBundleConfig($this->bundleConfig);
        $generator->setRouter($this->router);
        $generator->setBaseAdminTemplate(
            $generator->getFromYaml(
                'base_admin_template',
                $generator->getFromBundleConfig('base_admin_template')
            )
        );
        $generator->setFieldGuesser($this->getFieldGuesser());
        $generator->setMustOverwriteIfExists($this->needToOverwrite($generator));
        $generator->setTwigExtensions($this->twig->getExtensions());
        $generator->setTwigFilters($this->twig->getFilters());
        $generator->setTemplateDirs($this->templatesDirectories);
        $generator->setBaseController(
            'Admingenerator\GeneratorBundle\Controller\Doctrine\BaseController'
        );
        $generator->setBaseGeneratorName($this->getBaseGeneratorName());

        $builders = $generator->getFromYaml('builders', array());

        if (array_key_exists('list', $builders)) {
            $generator->addBuilder(new ListBuilderAction());
            $generator->addBuilder(new ListBuilderTemplate());
            $generator->addBuilder(new FiltersBuilderType());
        }

        if (array_key_exists('nested_list', $builders)) {
            $generator->addBuilder(new NestedListBuilderAction());
            $generator->addBuilder(new NestedListBuilderTemplate());
        }

        if (array_key_exists('edit', $builders)) {
            $generator->addBuilder(new EditBuilderAction());
            $generator->addBuilder(new EditBuilderTemplate());
            $generator->addBuilder(new EditBuilderType());
        }

        if (array_key_exists('new', $builders)) {
            $generator->addBuilder(new NewBuilderAction());
            $generator->addBuilder(new NewBuilderTemplate());
            $generator->addBuilder(new NewBuilderType());
        }

        if (array_key_exists('show', $builders)) {
            $generator->addBuilder(new ShowBuilderAction());
            $generator->addBuilder(new ShowBuilderTemplate());
        }

        if (array_key_exists('excel', $builders)) {
            $generator->addBuilder(new ExcelBuilderAction());
        }

        if (array_key_exists('actions', $builders)) {
            $generator->addBuilder(new ActionsBuilderAction());
            $generator->addBuilder(new ActionsBuilderTemplate());
        }

        $generator->writeOnDisk(
            $this->getCachePath(
                $generator->getFromYaml('params.namespace_prefix'),
                $generator->getFromYaml('params.bundle_name')
            )
        );
    }
}


1		<?php
2
3		namespace Admingenerator\GeneratorBundle\Generator;
4
5		use Admingenerator\GeneratorBundle\Builder\Generator as AdminGenerator;
6		use Admingenerator\GeneratorBundle\Builder\Doctrine\ListBuilderAction;
7		use Admingenerator\GeneratorBundle\Builder\Doctrine\ListBuilderTemplate;
8		use Admingenerator\GeneratorBundle\Builder\Doctrine\NestedListBuilderAction;
9		use Admingenerator\GeneratorBundle\Builder\Doctrine\NestedListBuilderTemplate;
10		use Admingenerator\GeneratorBundle\Builder\Doctrine\FiltersBuilderType;
11		use Admingenerator\GeneratorBundle\Builder\Doctrine\ExcelBuilderAction;
12		use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderAction;
13		use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderTemplate;
14		use Admingenerator\GeneratorBundle\Builder\Doctrine\EditBuilderType;
15		use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderAction;
16		use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderTemplate;
17		use Admingenerator\GeneratorBundle\Builder\Doctrine\NewBuilderType;
18		use Admingenerator\GeneratorBundle\Builder\Doctrine\ShowBuilderAction;
19		use Admingenerator\GeneratorBundle\Builder\Doctrine\ShowBuilderTemplate;
20		use Admingenerator\GeneratorBundle\Builder\Doctrine\ActionsBuilderAction;
21		use Admingenerator\GeneratorBundle\Builder\Doctrine\ActionsBuilderTemplate;
22
23	View Code Duplication	class DoctrineGenerator extends Generator
		0 ignored issues – show Duplication introduced 2017-05-18 22:14 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
24		{
25		/**
26		* (non-PHPdoc)
27		* @see Generator/Admingenerator\GeneratorBundle\Generator.Generator::doBuild()
28		*/
29		protected function doBuild()
30		{
31		$this->validateYaml();
32
33		$generator = new AdminGenerator($this->cache_dir, $this->getGeneratorYml());
		0 ignored issues – show Documentation introduced 2017-05-18 22:14 UTC by Report Bug Copy Issue Report `$this->getGeneratorYml()` is of type `string`, but the function expects a `object<Admingenerator\Ge...undle\Builder\Filepath>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
34		$generator->setBundleConfig($this->bundleConfig);
35		$generator->setRouter($this->router);
36		$generator->setBaseAdminTemplate(
37		$generator->getFromYaml(
38		'base_admin_template',
39		$generator->getFromBundleConfig('base_admin_template')
40		)
41		);
42		$generator->setFieldGuesser($this->getFieldGuesser());
43		$generator->setMustOverwriteIfExists($this->needToOverwrite($generator));
44		$generator->setTwigExtensions($this->twig->getExtensions());
45		$generator->setTwigFilters($this->twig->getFilters());
46		$generator->setTemplateDirs($this->templatesDirectories);
47		$generator->setBaseController(
48		'Admingenerator\GeneratorBundle\Controller\Doctrine\BaseController'
49		);
50		$generator->setBaseGeneratorName($this->getBaseGeneratorName());
51
52		$builders = $generator->getFromYaml('builders', array());
53
54		if (array_key_exists('list', $builders)) {
55		$generator->addBuilder(new ListBuilderAction());
56		$generator->addBuilder(new ListBuilderTemplate());
57		$generator->addBuilder(new FiltersBuilderType());
58		}
59
60		if (array_key_exists('nested_list', $builders)) {
61		$generator->addBuilder(new NestedListBuilderAction());
62		$generator->addBuilder(new NestedListBuilderTemplate());
63		}
64
65		if (array_key_exists('edit', $builders)) {
66		$generator->addBuilder(new EditBuilderAction());
67		$generator->addBuilder(new EditBuilderTemplate());
68		$generator->addBuilder(new EditBuilderType());
69		}
70
71		if (array_key_exists('new', $builders)) {
72		$generator->addBuilder(new NewBuilderAction());
73		$generator->addBuilder(new NewBuilderTemplate());
74		$generator->addBuilder(new NewBuilderType());
75		}
76
77		if (array_key_exists('show', $builders)) {
78		$generator->addBuilder(new ShowBuilderAction());
79		$generator->addBuilder(new ShowBuilderTemplate());
80		}
81
82		if (array_key_exists('excel', $builders)) {
83		$generator->addBuilder(new ExcelBuilderAction());
84		}
85
86		if (array_key_exists('actions', $builders)) {
87		$generator->addBuilder(new ActionsBuilderAction());
88		$generator->addBuilder(new ActionsBuilderTemplate());
89		}
90
91		$generator->writeOnDisk(
92		$this->getCachePath(
93		$generator->getFromYaml('params.namespace_prefix'),
94		$generator->getFromYaml('params.bundle_name')
95		)
96		);
97		}
98		}
99

symfony2admingenerator / GeneratorBundle

DoctrineGenerator::doBuild() B last analyzed 2019-08-07 21:50 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like

DoctrineGenerator::doBuild() B
last analyzed 2019-08-07 21:50 UTC