VariadicControllerTest::testEmptyReturnsResponse() - Code Metrics - Inspection of "Update VariadicControllerTest.php" - symfony-util/controller-using-templating-http-foundation - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 57230d...aff590 )

by Jean-Bernard

created 2017-12-05 02:48 UTC

VariadicControllerTest::testEmptyReturnsResponse() A

↳ Parent: VariadicControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	7

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	7
nc	1
nop	0

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\Twig\TwigEngine;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\Templating\TemplateNameParser;
use SymfonyUtil\Controller\VariadicController;

/**
 * @covers \SymfonyUtil\Controller\VariadicController
 * @requires PHP 5.6.0
 */
final class VariadicControllerTest extends TestCase
namespace YourVendor;

class YourClass { }
{
    public function testCanBeCreated()

    {
        $this->assertInstanceOf(
            VariadicController::class,
            new VariadicController(new TwigEngine(
                new Twig_Environment(new Twig_Loader_Array(['index.html.twig' => 'Hello World!'])),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                new TemplateNameParser()
            ))
        );
    }

    public function testEmptyReturnsResponse()

    {
        $this->assertInstanceOf(
            Response::class,
            (new VariadicController(new TwigEngine(
                new Twig_Environment(new Twig_Loader_Array(['index.html.twig' => 'Hello World!'])),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                new TemplateNameParser()
            )))->__invoke()
        );
    }

    public function testArrayReturnsResponse()

    {
        $this->assertInstanceOf(
            Response::class,
            (new VariadicController(new TwigEngine(
                new Twig_Environment(new Twig_Loader_Array([
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'index.html.twig' => '<ul>{% for item in 0 %}<li>{{ item }}</li>{% endfor %}</ul>',
                ])),
                new TemplateNameParser()
            )))->__invoke([
                'One',
                'Two',
                'Three',
            ])
        );
    }
}

// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html


1		<?php
2
3		/*
4		* This file is part of the Symfony-Util package.
5		*
6		* (c) Jean-Bernard Addor
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		use PHPUnit\Framework\TestCase;
13		use Symfony\Bridge\Twig\TwigEngine;
14		use Symfony\Component\HttpFoundation\Response;
15		use Symfony\Component\Templating\TemplateNameParser;
16		use SymfonyUtil\Controller\VariadicController;
17
18		/**
19		* @covers \SymfonyUtil\Controller\VariadicController
20		* @requires PHP 5.6.0
21		*/
22		final class VariadicControllerTest extends TestCase
		0 ignored issues – show Coding Style Compatibility introduced 2017-08-26 18:03 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
23		{
24	View Code Duplication	public function testCanBeCreated()
		0 ignored issues – show Duplication introduced 2017-12-05 02:47 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
25		{
26		$this->assertInstanceOf(
27		VariadicController::class,
28		new VariadicController(new TwigEngine(
29		new Twig_Environment(new Twig_Loader_Array(['index.html.twig' => 'Hello World!'])),
		0 ignored issues – show Documentation introduced 2017-08-26 13:40 UTC by Report Bug Copy Issue Report `new \Twig_Environment(ne...g' => 'Hello World!')))` is of type `object<Twig_Environment>`, but the function expects a `object<Twig\Environment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30		new TemplateNameParser()
31		))
32		);
33		}
34
35	View Code Duplication	public function testEmptyReturnsResponse()
		0 ignored issues – show Duplication introduced 2017-12-05 02:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36		{
37		$this->assertInstanceOf(
38		Response::class,
39		(new VariadicController(new TwigEngine(
40		new Twig_Environment(new Twig_Loader_Array(['index.html.twig' => 'Hello World!'])),
		0 ignored issues – show Documentation introduced 2017-08-26 13:40 UTC by Report Bug Copy Issue Report `new \Twig_Environment(ne...g' => 'Hello World!')))` is of type `object<Twig_Environment>`, but the function expects a `object<Twig\Environment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41		new TemplateNameParser()
42		)))->__invoke()
43		);
44		}
45
46	View Code Duplication	public function testArrayReturnsResponse()
		0 ignored issues – show Duplication introduced 2017-12-05 02:50 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
47		{
48		$this->assertInstanceOf(
49		Response::class,
50		(new VariadicController(new TwigEngine(
51		new Twig_Environment(new Twig_Loader_Array([
		0 ignored issues – show Documentation introduced 2017-08-26 14:25 UTC by Report Bug Copy Issue Report `new \Twig_Environment(ne...i>{% endfor %}</ul>')))` is of type `object<Twig_Environment>`, but the function expects a `object<Twig\Environment>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
52		'index.html.twig' => '<ul>{% for item in 0 %}<li>{{ item }}</li>{% endfor %}</ul>',
53		])),
54		new TemplateNameParser()
55		)))->__invoke([
56		'One',
57		'Two',
58		'Three',
59		])
60		);
61		}
62		}
63
64		// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
65		// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html
66

symfony-util / controller-using-templating-http-foundation

Push — master ( 57230d...aff590 )

VariadicControllerTest::testEmptyReturnsResponse() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like