Issues in AppKernel.php (master) - Issues in master - symfony-util/controller-using-templating-http-foundation-http-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Issues (37)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/Component/AppKernel.php (7 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tests\Component;

use Symfony\Bridge\Twig\TwigEngine;
use Symfony\Bundle\FrameworkBundle\Client;
use Symfony\Bundle\FrameworkBundle\Controller\ControllerNameParser;
use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver; // Many controller resolver exists!
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddCacheClearerPass;
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddCacheWarmerPass;
// use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\AddConsoleCommandPass;
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\ControllerArgumentValueResolverPass; // 2 versions of this!
use Symfony\Bundle\FrameworkBundle\DependencyInjection\Compiler\RoutingResolverPass;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Bundle\FrameworkBundle\Routing\DelegatingLoader;
use Symfony\Bundle\FrameworkBundle\Routing\RedirectableUrlMatcher;
use Symfony\Bundle\FrameworkBundle\Routing\Router;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\Config\Loader\LoaderResolver;
use Symfony\Component\Config\ResourceCheckerConfigCacheFactory;
use Symfony\Component\DependencyInjection\Compiler\PassConfig;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;
use Symfony\Component\DependencyInjection\Reference;
use Symfony\Component\EventDispatcher\ContainerAwareEventDispatcher;
use Symfony\Component\EventDispatcher\DependencyInjection\RegisterListenersPass;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\DefaultValueResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\RequestAttributeValueResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\RequestValueResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\ServiceValueResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\SessionValueResolver;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver\VariadicValueResolver;
use Symfony\Component\HttpKernel\ControllerMetadata\ArgumentMetadataFactory;
// use Symfony\Component\HttpKernel\DependencyInjection\ControllerArgumentValueResolverPass; // 2 versions of this!
use Symfony\Component\HttpKernel\DependencyInjection\RegisterControllerArgumentLocatorsPass;
use Symfony\Component\HttpKernel\EventListener\RouterListener;
use Symfony\Component\HttpKernel\HttpKernel;
use Symfony\Component\HttpKernel\Kernel; // Manages an environment made of bundles. HttpKernel is needed in addition!
use Symfony\Component\HttpKernel\UriSigner;
use Symfony\Component\Routing\Generator\Dumper\PhpGeneratorDumper;
use Symfony\Component\Routing\Generator\UrlGenerator;
use Symfony\Component\Routing\Loader\DependencyInjection\ServiceRouterLoader;
use Symfony\Component\Routing\Matcher\Dumper\PhpMatcherDumper;
use Symfony\Component\Routing\RouteCollectionBuilder;
use Symfony\Component\Templating\EngineInterface;
use Symfony\Component\Templating\TemplateNameParser;
use Symfony\Component\Templating\TemplateNameParserInterface;
use SymfonyUtil\Controller\EngineAsArgumentController;
use SymfonyUtil\Controller\TemplatingController;

// use Twig_Environment;
// use Twig_Loader_Array;
// use Twig_LoaderInterface;

class AppKernel extends Kernel
{
    use MicroKernelTrait;

    public function registerBundles()
    {
        return [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
            // new FrameworkBundle(),
        ];
    }

    protected function configureRoutes(RouteCollectionBuilder $routes)
    {
        $routes->add('/', EngineAsArgumentController::class, 'index');
        $routes->add('/argument', EngineAsArgumentController::class, 'argument');
        $routes->add('/constructor', TemplatingController::class, 'constructor');
        // $routes->add('/', EngineAsArgumentFrameworkController::class, 'index');
    }

    public function registerContainerConfiguration(LoaderInterface $loader)
    {
        $loader->load(function (ContainerBuilder $container) use ($loader) {
            $this->configureContainer($container, $loader);

            $container->addObjectResource($this); ////////////// TODO understand and consider necessity.
        });
    }

    protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader)

    {
        // https://symfony.com/doc/current/service_container.html
        // HttpKernel has to be added!
        // TODO: find the way the container is compiled in microKernel, be sure it works....
        // TODO: find the right way to configure the service_container!! cheking...
        // It does not replace the framework yet, but this is probably based on a config older than Symfony 3.3
        // TODO: reaorganize in different files by dependecy and use eg. HttpKernel, Matcher, ... allowing for alternatives
        // TODO: Read doc di component and load the config xml files from the framework bundle

        $c->register('kernel')->setSynthetic(true);
        $c->set('kernel', $this);

        // $c->register('service_container')->setSynthetic(true);
        // $c->set('service_container', $c);
        // https://github.com/symfony/dependency-injection/blob/master/Container.php
        // Seems to be included by default!

        $c->register('event_dispatcher', ContainerAwareEventDispatcher::class) // services.xml
            // TODO: Obsolete use EventDispatcher instead, but may cause other problems
            ->addArgument(new Reference('service_container'))
        ;

        $c->register('http_kernel', HttpKernel::class) // services.xml
            ->addArgument(new Reference('event_dispatcher'))
            ->addArgument(new Reference('controller_resolver'))
            ->addArgument(new Reference('request_stack'))
            ->addArgument(new Reference('argument_resolver'))
        ;

        $c->register('request_stack', RequestStack::class); // services.xml

        $c->register('uri_signer', UriSigner::class) // services.xml
            ->addArgument('12345') // app config
        ;

        $c->register('config_cache_factory', ResourceCheckerConfigCacheFactory::class) // services.xml
            ->addArgument([])
        ;
        $c->register('controller_name_converter', ControllerNameParser::class) // web.xml
            ->setPublic(false)
            ->addTag('monolog.logger', ['channel' => 'request'])
            ->addArgument(new Reference('kernel'))
        ;

        $c->register('controller_resolver', ControllerResolver::class) // web.xml
//            ->setPublic(false)
            ->addTag('monolog.logger', ['channel' => 'request'])
            ->addArgument(new Reference('service_container'))
            ->addArgument(new Reference('controller_name_converter'))
            ->addArgument(new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
        ;

        $c->register('argument_metadata_factory', ArgumentMetadataFactory::class) // web.xml
//            ->setPublic(false)
        ;

        $c->register('argument_resolver', ArgumentResolver::class) // web.xml
//            ->setPublic(false)
            ->addArgument(new Reference('argument_metadata_factory'))
            ->addArgument([])
        ;

        $c->setParameter('router.resource', 'kernel:loadRoutes'); // resource_type: service
        //         $c->setParameter('router.resource',                       new Expression('service("kernel").loadRoutes'));
        //        $c->setParameter('router.resource',                       MicroKernel::class . ':loadRoutes');
        //         $c->setParameter('router.resource',                       new Reference('kernel') . ':loadRoutes');
        //        $c->setParameter('router.resource',                       MicroKernel::loadRoutes);
        //        $c->setParameter('router.resource',                       self::loadRoutes);
        //        $c->setParameter('router.resource',                       parent::loadRoutes);
        //        $c->setParameter('router.resource',                       [new Reference('kernel'), 'loadRoutes']);
        //        $c->setParameter('router.resource',                       ['kernel', 'loadRoutes']);
        //        $c->setParameter('router.resource',                       [MicroKernel::class, 'loadRoutes']);

        $c->setParameter('router.cache_class_prefix', $c->getParameter('kernel.container_class'));
        // symfony/framework-bundle/DependencyInjection/FrameworkExtension.php
        $c->setParameter('router.options.generator_class', UrlGenerator::class); // routing.xml
        $c->setParameter('router.options.generator_base_class', UrlGenerator::class); // routing.xml
        $c->setParameter('router.options.generator_dumper_class', PhpGeneratorDumper::class); // routing.xml
        $c->setParameter('router.options.generator.cache_class', '%router.cache_class_prefix%UrlGenerator'); // routing.xml
        $c->setParameter('router.options.matcher_class', RedirectableUrlMatcher::class); // routing.xml
        $c->setParameter('router.options.matcher_base_class', RedirectableUrlMatcher::class); // routing.xml
        $c->setParameter('router.options.matcher_dumper_class', PhpMatcherDumper::class); // routing.xml
        $c->setParameter('router.options.matcher.cache_class', '%router.cache_class_prefix%UrlMatcher'); // routing.xml

        $c->setParameter('router.request_context.host', 'localhost'); // routing.xml
        $c->setParameter('router.request_context.scheme', 'http'); // routing.xml
        $c->setParameter('router.request_context.base_url', ''); // routing.xml

        $c->setParameter('request_listener.http_port', 80);
        $c->setParameter('request_listener.https_port', 443);
        // symfony/framework-bundle/DependencyInjection/FrameworkExtension.php

        $c->register('routing.resolver', LoaderResolver::class) // routing.xml
            ->setPublic(false)
        ;

        $c->register('routing.loader.service', ServiceRouterLoader::class) // routing.xml
//            ->setPublic(false)
            ->addTag('routing.loader')
            ->addArgument(new Reference('service_container'))
        ;
        $c->register('routing.loader', DelegatingLoader::class) // routing.xml
            ->addArgument(new Reference('controller_name_converter'))
            ->addArgument(new Reference('routing.resolver'))
        ;
        //...
        $c->register('router.default', Router::class) // routing.xml
//            ->setPublic(false)
            ->addTag('monolog.logger', ['channel' => 'router'])
            ->addArgument(new Reference('service_container'))
            ->addArgument('%router.resource%')
            ->addArgument([
                'cache_dir' => '%kernel.cache_dir%',
                'debug' => '%kernel.debug%',
                'generator_class' => '%router.options.generator_class%',
                'generator_base_class' => '%router.options.generator_base_class%',
                'generator_dumper_class' => '%router.options.generator_dumper_class%',
                'generator_cache_class' => '%router.options.generator.cache_class%',
                'matcher_class' => '%router.options.matcher_class%',
                'matcher_base_class' => '%router.options.matcher_base_class%',
                'matcher_dumper_class' => '%router.options.matcher_dumper_class%',
                'matcher_cache_class' => '%router.options.matcher.cache_class%',
                'resource_type' => 'service', ////////////////////!
            ])
            ->addArgument(new Reference('router.request_context', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
            ->addArgument(new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
            ->addMethodCall('setConfigCacheFactory', [new Reference('config_cache_factory')])
        ;
        $c->setAlias('router', 'router.default');

        $c->register('router_listener', RouterListener::class) // routing.xml
            ->addTag('kernel.event_subscriber')
            ->addTag('monolog.logger', ['channel' => 'request'])
            ->addArgument(new Reference('router'))
            ->addArgument(new Reference('request_stack'))
            ->addArgument(new Reference('router.request_context', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
            ->addArgument(new Reference('logger', ContainerInterface::IGNORE_ON_INVALID_REFERENCE))
        ;

        $c->autowire(TemplateNameParser::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(TemplateNameParserInterface::class, TemplateNameParser::class);

        $c->autowire(\Twig_Loader_Array::class, \Twig_Loader_Array::class)
            ->setArgument('$templates', ['index.html.twig' => 'Hello Component!'])
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(\Twig_LoaderInterface::class, \Twig_Loader_Array::class);

        $c->autowire(\Twig_Environment::class, \Twig_Environment::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(\Twig\Environment::class, \Twig_Environment::class);

        $c->autowire(TwigEngine::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(EngineInterface::class, TwigEngine::class);
        $c->setAlias('templating', TwigEngine::class); // Read Symfony source code to understand!

        if (\in_array($this->getEnvironment(), ['test'], true)) {

            $c->autowire('test.client', Client::class)
                ->setPublic(true); // Public needed!
        }

        //Controllers
        $c->autowire(EngineAsArgumentController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(true);

        $c->autowire(TemplatingController::class)
            ->setAutoconfigured(true)
            // ->addTag('controller.service_arguments')
            ->setPublic(true);

        $c->autowire(EngineAsArgumentFrameworkController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(true);

        // https://github.com/symfony/framework-bundle/blob/current/Resources/config/web.xml
        $c->autowire(RequestAttributeValueResolver::class) // argument_resolver.request_attribute
            ->addTag('controller.argument_value_resolver', ['priority' => 100])->setPublic(false);
        $c->autowire(RequestValueResolver::class) // argument_resolver.request
            ->addTag('controller.argument_value_resolver', ['priority' => 50])->setPublic(false);
        $c->autowire(SessionValueResolver::class) // argument_resolver.session
            ->addTag('controller.argument_value_resolver', ['priority' => 50])->setPublic(false);
        $c->autowire(ServiceValueResolver::class) // argument_resolver.service
            ->setArgument('$container', new Reference('service_container'))
            ->addTag('controller.argument_value_resolver', ['priority' => -50])->setPublic(false);
        $c->autowire(DefaultValueResolver::class) // argument_resolver.default
            ->addTag('controller.argument_value_resolver', ['priority' => -100])->setPublic(false);
        $c->autowire(VariadicValueResolver::class) // argument_resolver.variadic
            ->addTag('controller.argument_value_resolver', ['priority' => -150])->setPublic(false);
        // https://symfony.com/doc/current/controller/argument_value_resolver.html
        // http://api.symfony.com/3.3/Symfony/Component/HttpKernel/Controller/ArgumentResolver/ServiceValueResolver.html
        // https://symfony.com/doc/current/service_container/tags.html

        $c->addCompilerPass(new RoutingResolverPass());

        $c->addCompilerPass(new RegisterListenersPass(), PassConfig::TYPE_BEFORE_REMOVING);
        // $c->addCompilerPass(new AddConsoleCommandPass()); // Dependency need!
        $c->addCompilerPass(new AddCacheWarmerPass());

        $c->addCompilerPass(new AddCacheClearerPass());

        $c->addCompilerPass(new ControllerArgumentValueResolverPass());

        $c->addCompilerPass(new RegisterControllerArgumentLocatorsPass());

        // Extensions
        // $c->loadFromExtension('framework', [
        //     'secret' => 'NotSecret', // What about use $ uuid -v4  or $ uuidgen
        // ]);
    }
}

// Information for Service "test.client"
// =====================================

//  ---------------- ---------------------------------------
//   Option           Value
//  ---------------- ---------------------------------------
//   Service ID       test.client
//   Class            Symfony\Bundle\FrameworkBundle\Client
//   Tags             -
//   Public           yes
//   Synthetic        no
//   Lazy             no
//   Shared           no
//   Abstract         no
//   Autowired        no
//   Autoconfigured   no
//  ---------------- ---------------------------------------


symfony-util / controller-using-templating-http-foundation-http-kernel

Issues (37)

Security Analysis not enabled

tests/Component/AppKernel.php (7 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like