EngineAsArgumentInKernelControllerTest::testCanBeCreated() - Code Metrics - Inspection of "Update EngineAsArgumentInKernelControllerTest.php" - symfony-util/controller-using-templating-http-foundation-http-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 3fd4f8...c663c4 )

by Jean-Bernard

created 2017-08-24 11:26 UTC

testCanBeCreated() A

↳ Parent: EngineAsArgumentInKernelControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	8
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	0

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\Twig\TwigEngine;
// use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver; // Do not know how to configure this.
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
use Symfony\Component\HttpKernel\Controller\ControllerResolver;
use Symfony\Component\HttpKernel\Controller\ContainerControllerResolver;
use Symfony\Component\HttpKernel\EventListener\ResponseListener;
use Symfony\Component\HttpKernel\EventListener\RouterListener;
use Symfony\Component\HttpKernel\HttpKernel;
use Symfony\Component\Routing\Matcher\UrlMatcher;
use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
use Symfony\Component\Routing\RequestContext;
use Symfony\Component\Routing\RouteCollectionBuilder;
use Symfony\Component\Templating\EngineInterface;
use Symfony\Component\Templating\TemplateNameParser;
use Symfony\Component\Templating\TemplateNameParserInterface;
use SymfonyUtil\Controller\EngineAsArgumentController;
use Tests\Component\AppKernel;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * @covers \SymfonyUtil\Controller\EngineAsArgumentController
 */
final class EngineAsArgumentInKernelControllerTest extends TestCase
namespace YourVendor;

class YourClass { }
{
    public function testCanBeCreated()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'Symfony\Component\HttpKernel\Kernel',
            new AppKernel('dev', true)
        );
    }

    public function testKernelInterface()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'Symfony\Component\HttpKernel\KernelInterface',
            new AppKernel('dev', true)
        );
    }

    public function testFrameworkReturnsResponse()
    {
        $this->assertInstanceOf(
            // Response::class, // 5.4 < php
            'Symfony\Component\HttpFoundation\Response',
            (new AppKernel('dev', true))->handle(Request::create('/', 'GET'))
        );
    }

    public function testControllerResponse()
    { // From: https://symfony.com/doc/current/create_framework/unit_testing.html
        // TODO: Try with a real matcher
        // TODO: Use real controller to be tested!
        $matcher = $this->createMock(UrlMatcherInterface::class);
        // use getMock() on PHPUnit 5.3 or below
        // $matcher = $this->getMock(UrlMatcherInterface::class);


        $matcher
            ->expects($this->once())
            ->method('match')
            ->will($this->returnValue([
                '_route' => 'foo',
                'name' => 'Fabien',
                '_controller' => function ($name) {
                    return new Response('Hello '.$name);
                },
            ]))
        ;
        $matcher
            ->expects($this->once())
            ->method('getContext')
            ->will($this->returnValue($this->createMock(RequestContext::class)))
        ;

        $requestStack = new RequestStack();
        $dispatcher = new EventDispatcher();
        $dispatcher->addSubscriber(new RouterListener(
            $matcher,
            $requestStack
        )); // Returns nothing.
        $dispatcher->addSubscriber(new ResponseListener('UTF-8'));
        $response = (new HttpKernel(
            $dispatcher,
            new ContainerControllerResolver($this->container()),
            // new ControllerResolver(),

            $requestStack,
            new ArgumentResolver() // OK
        // ))->handle(Request::create('/', 'GET'));

        ))->handle(new Request());

        $this->assertSame(200, $response->getStatusCode());
        $this->assertContains('Hello Fabien', $response->getContent());
    }

    public function testContainerCanBeCreated()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'Symfony\Component\DependencyInjection\ContainerBuilder',
            $this->container()
        );
    }

    public function testContainerInterface()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'psr\Container\ContainerInterface',
            $this->container()
        );
    }

    public function testComponentReturnsResponse() // Not yet a test!
    {
        // TODO: Use real controller to be tested!
        $requestStack = new RequestStack();
        $dispatcher = new EventDispatcher();
        $dispatcher->addSubscriber(new RouterListener(
            new UrlMatcher(
                $this->loadJustHelloRoutes(),
                new RequestContext()
            ),
            $requestStack
        ));
        $dispatcher->addSubscriber(new ResponseListener('UTF-8'));

        $this->assertInstanceOf(
            // Response::class, // 5.4 < php
            'Symfony\Component\HttpFoundation\Response',
            (new HttpKernel(
                $dispatcher,
                // new ContainerControllerResolver($this->container()),

                new ControllerResolver($this->container()),
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $requestStack,
                new ArgumentResolver()
            ))->handle(Request::create('/', 'GET'))
        );
    }

    private function configureRoutes(RouteCollectionBuilder $routes)
    { // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
        $routes->add('/', EngineAsArgumentController::class, 'index'); // .'::__invoke'
        //^ It should be tested if the actually used controller resolver can resolve this!
        //^ Returns Symfony/Component/Routing/Route .
    }

    private function loadRoutes(LoaderInterface $loader = null)

    { // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
        $routes = new RouteCollectionBuilder($loader);
        $this->configureRoutes($routes);

        return $routes->build();
    }

    private function configureJustHelloRoutes(RouteCollectionBuilder $routes)

    { // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
        $routes->add(
            '/',
            function () {
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                return new Response('Hello');
            },
            'index'
        ); // .'::__invoke'
        //^ It should be tested if the actually used controller resolver can resolve this!
        //^ Returns Symfony/Component/Routing/Route .
    }

    private function loadJustHelloRoutes(LoaderInterface $loader = null)
    { // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
        $routes = new RouteCollectionBuilder($loader);
        $this->configureRoutes($routes);

        return $routes->build();
    }

    private function container()
    {
        $c = new ContainerBuilder();
        // https://symfony.com/doc/current/service_container.html

        $c->autowire(TemplateNameParser::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(TemplateNameParserInterface::class, TemplateNameParser::class);

        $c->autowire(Twig_Loader_Array::class, Twig_Loader_Array::class)
            ->setArgument('$templates', ['index.html.twig' => 'Hello Component!'])
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(Twig_LoaderInterface::class, Twig_Loader_Array::class);

        $c->autowire(Twig_Environment::class, Twig_Environment::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(Twig\Environment::class, Twig_Environment::class);

        $c->autowire(TwigEngine::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(EngineInterface::class, TwigEngine::class);

        // Unit Testing
        // $c->autowire('test.client', Client::class)

        //     ->setPublic(true); // Public needed!


        //Controllers
        $c->autowire(EngineAsArgumentController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(false);

        return $c;
    }
}

// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html


1			<?php
2
3			/*
4			* This file is part of the Symfony-Util package.
5			*
6			* (c) Jean-Bernard Addor
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			use PHPUnit\Framework\TestCase;
13			use Symfony\Bridge\Twig\TwigEngine;
14			// use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver; // Do not know how to configure this.
15			use Symfony\Component\DependencyInjection\ContainerBuilder;
16			use Symfony\Component\EventDispatcher\EventDispatcher;
17			use Symfony\Component\HttpFoundation\Request;
18			use Symfony\Component\HttpFoundation\RequestStack;
19			use Symfony\Component\HttpFoundation\Response;
20			use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
21			use Symfony\Component\HttpKernel\Controller\ControllerResolver;
22			use Symfony\Component\HttpKernel\Controller\ContainerControllerResolver;
23			use Symfony\Component\HttpKernel\EventListener\ResponseListener;
24			use Symfony\Component\HttpKernel\EventListener\RouterListener;
25			use Symfony\Component\HttpKernel\HttpKernel;
26			use Symfony\Component\Routing\Matcher\UrlMatcher;
27			use Symfony\Component\Routing\Matcher\UrlMatcherInterface;
28			use Symfony\Component\Routing\RequestContext;
29			use Symfony\Component\Routing\RouteCollectionBuilder;
30			use Symfony\Component\Templating\EngineInterface;
31			use Symfony\Component\Templating\TemplateNameParser;
32			use Symfony\Component\Templating\TemplateNameParserInterface;
33			use SymfonyUtil\Controller\EngineAsArgumentController;
34			use Tests\Component\AppKernel;
			0 ignored issues – show Bug introduced 2017-08-23 16:51 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `AppKernel`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
35
36			/**
37			* @covers \SymfonyUtil\Controller\EngineAsArgumentController
38			*/
39			final class EngineAsArgumentInKernelControllerTest extends TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-23 15:34 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
40			{
41			public function testCanBeCreated()
42			{
43			$this->assertInstanceOf(
44			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 16:33 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
45			'Symfony\Component\HttpKernel\Kernel',
46			new AppKernel('dev', true)
47			);
48			}
49
50			public function testKernelInterface()
51			{
52			$this->assertInstanceOf(
53			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 16:33 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
54			'Symfony\Component\HttpKernel\KernelInterface',
55			new AppKernel('dev', true)
56			);
57			}
58
59			public function testFrameworkReturnsResponse()
60			{
61			$this->assertInstanceOf(
62			// Response::class, // 5.4 < php
63			'Symfony\Component\HttpFoundation\Response',
64			(new AppKernel('dev', true))->handle(Request::create('/', 'GET'))
65			);
66			}
67
68			public function testControllerResponse()
69			{ // From: https://symfony.com/doc/current/create_framework/unit_testing.html
70			// TODO: Try with a real matcher
71			// TODO: Use real controller to be tested!
72			$matcher = $this->createMock(UrlMatcherInterface::class);
73			// use getMock() on PHPUnit 5.3 or below
74			// $matcher = $this->getMock(UrlMatcherInterface::class);
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 03:42 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
75
76			$matcher
77			->expects($this->once())
78			->method('match')
79			->will($this->returnValue([
80			'_route' => 'foo',
81			'name' => 'Fabien',
82			'_controller' => function ($name) {
83			return new Response('Hello '.$name);
84			},
85			]))
86			;
87			$matcher
88			->expects($this->once())
89			->method('getContext')
90			->will($this->returnValue($this->createMock(RequestContext::class)))
91			;
92
93			$requestStack = new RequestStack();
94			$dispatcher = new EventDispatcher();
95			$dispatcher->addSubscriber(new RouterListener(
96			$matcher,
97			$requestStack
98			)); // Returns nothing.
99			$dispatcher->addSubscriber(new ResponseListener('UTF-8'));
100			$response = (new HttpKernel(
101			$dispatcher,
102			new ContainerControllerResolver($this->container()),
103			// new ControllerResolver(),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 11:11 UTC by Report Bug Copy Issue Report `58%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
104			$requestStack,
105			new ArgumentResolver() // OK
106			// ))->handle(Request::create('/', 'GET'));
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 03:34 UTC by Report Bug Copy Issue Report `71%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
107			))->handle(new Request());
108
109			$this->assertSame(200, $response->getStatusCode());
110			$this->assertContains('Hello Fabien', $response->getContent());
111			}
112
113			public function testContainerCanBeCreated()
114			{
115			$this->assertInstanceOf(
116			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 02:11 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
117			'Symfony\Component\DependencyInjection\ContainerBuilder',
118			$this->container()
119			);
120			}
121
122			public function testContainerInterface()
123			{
124			$this->assertInstanceOf(
125			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 02:11 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
126			'psr\Container\ContainerInterface',
127			$this->container()
128			);
129			}
130
131			public function testComponentReturnsResponse() // Not yet a test!
132			{
133			// TODO: Use real controller to be tested!
134			$requestStack = new RequestStack();
135			$dispatcher = new EventDispatcher();
136			$dispatcher->addSubscriber(new RouterListener(
137			new UrlMatcher(
138			$this->loadJustHelloRoutes(),
139			new RequestContext()
140			),
141			$requestStack
142			));
143			$dispatcher->addSubscriber(new ResponseListener('UTF-8'));
144
145			$this->assertInstanceOf(
146			// Response::class, // 5.4 < php
147			'Symfony\Component\HttpFoundation\Response',
148			(new HttpKernel(
149			$dispatcher,
150			// new ContainerControllerResolver($this->container()),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-24 11:22 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
151			new ControllerResolver($this->container()),
			0 ignored issues – show Documentation introduced 2017-08-24 11:28 UTC by Report Bug Copy Issue Report `$this->container()` is of type `object<Symfony\Component...ction\ContainerBuilder>`, but the function expects a `null\|object<Psr\Log\LoggerInterface>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
152			$requestStack,
153			new ArgumentResolver()
154			))->handle(Request::create('/', 'GET'))
155			);
156			}
157
158			private function configureRoutes(RouteCollectionBuilder $routes)
159			{ // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
160			$routes->add('/', EngineAsArgumentController::class, 'index'); // .'::__invoke'
161			//^ It should be tested if the actually used controller resolver can resolve this!
162			//^ Returns Symfony/Component/Routing/Route .
163			}
164
165			private function loadRoutes(LoaderInterface $loader = null)
			0 ignored issues – show Unused Code introduced 2017-08-24 03:06 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
166			{ // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
167			$routes = new RouteCollectionBuilder($loader);
168			$this->configureRoutes($routes);
169
170			return $routes->build();
171			}
172
173			private function configureJustHelloRoutes(RouteCollectionBuilder $routes)
			0 ignored issues – show Unused Code introduced 2017-08-24 11:05 UTC by Report Bug Copy Issue Report This method is not used, and could be removed. Loading history...
174			{ // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
175			$routes->add(
176			'/',
177			function () {
			0 ignored issues – show Documentation introduced 2017-08-24 11:05 UTC by Report Bug Copy Issue Report `function () { return...on\Response('Hello'); }` is of type `object<Closure>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
178			return new Response('Hello');
179			},
180			'index'
181			); // .'::__invoke'
182			//^ It should be tested if the actually used controller resolver can resolve this!
183			//^ Returns Symfony/Component/Routing/Route .
184			}
185
186			private function loadJustHelloRoutes(LoaderInterface $loader = null)
187			{ // from Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait
188			$routes = new RouteCollectionBuilder($loader);
189			$this->configureRoutes($routes);
190
191			return $routes->build();
192			}
193
194			private function container()
195			{
196			$c = new ContainerBuilder();
197			// https://symfony.com/doc/current/service_container.html
198
199			$c->autowire(TemplateNameParser::class)
200			->setAutoconfigured(true)
201			->setPublic(false);
202			$c->setAlias(TemplateNameParserInterface::class, TemplateNameParser::class);
203
204			$c->autowire(Twig_Loader_Array::class, Twig_Loader_Array::class)
205			->setArgument('$templates', ['index.html.twig' => 'Hello Component!'])
206			->setAutoconfigured(true)
207			->setPublic(false);
208			$c->setAlias(Twig_LoaderInterface::class, Twig_Loader_Array::class);
209
210			$c->autowire(Twig_Environment::class, Twig_Environment::class)
211			->setAutoconfigured(true)
212			->setPublic(false);
213			$c->setAlias(Twig\Environment::class, Twig_Environment::class);
214
215			$c->autowire(TwigEngine::class)
216			->setAutoconfigured(true)
217			->setPublic(false);
218			$c->setAlias(EngineInterface::class, TwigEngine::class);
219
220			// Unit Testing
221			// $c->autowire('test.client', Client::class)
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 20:13 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
222			// ->setPublic(true); // Public needed!
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 20:13 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
223
224			//Controllers
225			$c->autowire(EngineAsArgumentController::class)
226			->setAutoconfigured(true)
227			->addTag('controller.service_arguments')
228			->setPublic(false);
229
230			return $c;
231			}
232			}
233
234			// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
235			// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html
236

symfony-util / controller-using-templating-http-foundation-http-kernel

Push — master ( 3fd4f8...c663c4 )

testCanBeCreated() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like