EngineAsArgumentInKernelControllerTest::testComponentReturnsResponse() - Code Metrics - Inspection of "Update EngineAsArgumentInKernelControllerTest.php" - symfony-util/controller-using-templating-http-foundation-http-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( aa0e3d...8f2a71 )

by Jean-Bernard

created 2017-08-23 21:53 UTC

testComponentReturnsResponse() A

↳ Parent: EngineAsArgumentInKernelControllerTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	60
Code Lines	41

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	60
rs	9.5555
c	0
b	0
f	0
cc	1
eloc	41
nc	1
nop	0

How to fix Long Method

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use PHPUnit\Framework\TestCase;
use Symfony\Bridge\Twig\TwigEngine;
use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\EventDispatcher\EventDispatcher;
use Symfony\Component\HttpFoundation\Request;
use Symfony\Component\HttpFoundation\RequestStack;
use Symfony\Component\HttpFoundation\Response;
use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
// use Symfony\Component\HttpKernel\Controller\ContainerControllerResolver;
use Symfony\Component\HttpKernel\EventListener\ResponseListener;
use Symfony\Component\HttpKernel\EventListener\RouterListener;
use Symfony\Component\HttpKernel\HttpKernel;
use Symfony\Component\Routing\Matcher\UrlMatcher;
use Symfony\Component\Routing\RequestContext;
use Symfony\Component\Routing\RouteCollectionBuilder;
use Symfony\Component\Templating\EngineInterface;
use Symfony\Component\Templating\TemplateNameParser;
use Symfony\Component\Templating\TemplateNameParserInterface;
use SymfonyUtil\Controller\EngineAsArgumentController;
use Tests\Component\AppKernel;
.
|-- OtherDir
|   |-- Bar.php
|   `-- Foo.php
`-- SomeDir
    `-- Foo.php

/**
 * @covers \SymfonyUtil\Controller\EngineAsArgumentController
 */
final class EngineAsArgumentInKernelControllerTest extends TestCase
namespace YourVendor;

class YourClass { }
{
    public function testCanBeCreated()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'Symfony\Component\HttpKernel\Kernel',
            new AppKernel('dev', true)
        );
    }

    public function testKernelInterface()
    {
        $this->assertInstanceOf(
            // ...::class, // 5.4 < php

            'Symfony\Component\HttpKernel\KernelInterface',
            new AppKernel('dev', true)
        );
    }

    public function testFrameworkReturnsResponse()
    {
        $this->assertInstanceOf(
            // Response::class, // 5.4 < php
            'Symfony\Component\HttpFoundation\Response',
            (new AppKernel('dev', true))->handle(Request::create('/', 'GET'))
        );
    }

    public function testComponentReturnsResponse()
    {
        $requestStack = new RequestStack();
        $routes = new RouteCollectionBuilder(); // Because I know how to use it.
        $routes->add('/', EngineAsArgumentController::class, 'index'); // returns Symfony/Component/Routing/Route
        $dispatcher = new EventDispatcher();
        $dispatcher->addSubscriber(new RouterListener(
            new UrlMatcher(
                $routes->build(),
                new RequestContext()
            ),
            $requestStack
        ));
        $dispatcher->addSubscriber(new ResponseListener('UTF-8'));

        $c = new ContainerBuilder();
        // https://symfony.com/doc/current/service_container.html

        $c->autowire(TemplateNameParser::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(TemplateNameParserInterface::class, TemplateNameParser::class);

        $c->autowire(Twig_Loader_Array::class, Twig_Loader_Array::class)
            ->setArgument('$templates', ['index.html.twig' => 'Hello Component!'])
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(Twig_LoaderInterface::class, Twig_Loader_Array::class);

        $c->autowire(Twig_Environment::class, Twig_Environment::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(Twig\Environment::class, Twig_Environment::class);

        $c->autowire(TwigEngine::class)
            ->setAutoconfigured(true)
            ->setPublic(false);
        $c->setAlias(EngineInterface::class, TwigEngine::class);

        // Unit Testing
        // $c->autowire('test.client', Client::class)

        //     ->setPublic(true); // Public needed!


        //Controllers
        $c->autowire(EngineAsArgumentController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(false);

        $this->assertInstanceOf(
            // Response::class, // 5.4 < php
            'Symfony\Component\HttpFoundation\Response',
            (new HttpKernel(
                $dispatcher,
                new ControllerResolver($c),

                $requestStack,
                new ArgumentResolver()
            ))->handle(Request::create('/', 'GET'))
        );
    }
    
}

// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html


1			<?php
2
3			/*
4			* This file is part of the Symfony-Util package.
5			*
6			* (c) Jean-Bernard Addor
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			use PHPUnit\Framework\TestCase;
13			use Symfony\Bridge\Twig\TwigEngine;
14			use Symfony\Bundle\FrameworkBundle\Controller\ControllerResolver;
15			use Symfony\Component\DependencyInjection\ContainerBuilder;
16			use Symfony\Component\EventDispatcher\EventDispatcher;
17			use Symfony\Component\HttpFoundation\Request;
18			use Symfony\Component\HttpFoundation\RequestStack;
19			use Symfony\Component\HttpFoundation\Response;
20			use Symfony\Component\HttpKernel\Controller\ArgumentResolver;
21			// use Symfony\Component\HttpKernel\Controller\ContainerControllerResolver;
22			use Symfony\Component\HttpKernel\EventListener\ResponseListener;
23			use Symfony\Component\HttpKernel\EventListener\RouterListener;
24			use Symfony\Component\HttpKernel\HttpKernel;
25			use Symfony\Component\Routing\Matcher\UrlMatcher;
26			use Symfony\Component\Routing\RequestContext;
27			use Symfony\Component\Routing\RouteCollectionBuilder;
28			use Symfony\Component\Templating\EngineInterface;
29			use Symfony\Component\Templating\TemplateNameParser;
30			use Symfony\Component\Templating\TemplateNameParserInterface;
31			use SymfonyUtil\Controller\EngineAsArgumentController;
32			use Tests\Component\AppKernel;
			0 ignored issues – show Bug introduced 2017-08-23 16:51 UTC by Report Bug Copy Issue Report This use statement conflicts with another class in this namespace, `AppKernel`. Let’s assume that you have a directory layout like this: . \|-- OtherDir \| \|-- Bar.php \| `-- Foo.php `-- SomeDir `-- Foo.php and let’s assume the following content of `Bar.php`: // Bar.php namespace OtherDir; use SomeDir\Foo; // This now conflicts the class OtherDir\Foo If both files `OtherDir/Foo.php` and `SomeDir/Foo.php` are loaded in the same runtime, you will see a PHP error such as the following: PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.php However, as `OtherDir/Foo.php` does not necessarily have to be loaded and the error is only triggered if it is loaded before `OtherDir/Bar.php`, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: // Bar.php namespace OtherDir; use SomeDir\Foo as SomeDirFoo; // There is no conflict anymore. Loading history...
33
34			/**
35			* @covers \SymfonyUtil\Controller\EngineAsArgumentController
36			*/
37			final class EngineAsArgumentInKernelControllerTest extends TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-23 15:34 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
38			{
39			public function testCanBeCreated()
40			{
41			$this->assertInstanceOf(
42			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 16:33 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
43			'Symfony\Component\HttpKernel\Kernel',
44			new AppKernel('dev', true)
45			);
46			}
47
48			public function testKernelInterface()
49			{
50			$this->assertInstanceOf(
51			// ...::class, // 5.4 < php
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 16:33 UTC by Report Bug Copy Issue Report `50%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
52			'Symfony\Component\HttpKernel\KernelInterface',
53			new AppKernel('dev', true)
54			);
55			}
56
57			public function testFrameworkReturnsResponse()
58			{
59			$this->assertInstanceOf(
60			// Response::class, // 5.4 < php
61			'Symfony\Component\HttpFoundation\Response',
62			(new AppKernel('dev', true))->handle(Request::create('/', 'GET'))
63			);
64			}
65
66			public function testComponentReturnsResponse()
67			{
68			$requestStack = new RequestStack();
69			$routes = new RouteCollectionBuilder(); // Because I know how to use it.
70			$routes->add('/', EngineAsArgumentController::class, 'index'); // returns Symfony/Component/Routing/Route
71			$dispatcher = new EventDispatcher();
72			$dispatcher->addSubscriber(new RouterListener(
73			new UrlMatcher(
74			$routes->build(),
75			new RequestContext()
76			),
77			$requestStack
78			));
79			$dispatcher->addSubscriber(new ResponseListener('UTF-8'));
80
81			$c = new ContainerBuilder();
82			// https://symfony.com/doc/current/service_container.html
83
84			$c->autowire(TemplateNameParser::class)
85			->setAutoconfigured(true)
86			->setPublic(false);
87			$c->setAlias(TemplateNameParserInterface::class, TemplateNameParser::class);
88
89			$c->autowire(Twig_Loader_Array::class, Twig_Loader_Array::class)
90			->setArgument('$templates', ['index.html.twig' => 'Hello Component!'])
91			->setAutoconfigured(true)
92			->setPublic(false);
93			$c->setAlias(Twig_LoaderInterface::class, Twig_Loader_Array::class);
94
95			$c->autowire(Twig_Environment::class, Twig_Environment::class)
96			->setAutoconfigured(true)
97			->setPublic(false);
98			$c->setAlias(Twig\Environment::class, Twig_Environment::class);
99
100			$c->autowire(TwigEngine::class)
101			->setAutoconfigured(true)
102			->setPublic(false);
103			$c->setAlias(EngineInterface::class, TwigEngine::class);
104
105			// Unit Testing
106			// $c->autowire('test.client', Client::class)
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 20:13 UTC by Report Bug Copy Issue Report `59%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
107			// ->setPublic(true); // Public needed!
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 20:13 UTC by Report Bug Copy Issue Report `63%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
108
109			//Controllers
110			$c->autowire(EngineAsArgumentController::class)
111			->setAutoconfigured(true)
112			->addTag('controller.service_arguments')
113			->setPublic(false);
114
115			$this->assertInstanceOf(
116			// Response::class, // 5.4 < php
117			'Symfony\Component\HttpFoundation\Response',
118			(new HttpKernel(
119			$dispatcher,
120			new ControllerResolver($c),
			0 ignored issues – show Bug introduced 2017-08-23 21:55 UTC by Report Bug Copy Issue Report The call to `ControllerResolver::__construct()` misses a required argument `$parser`. This check looks for function calls that miss required arguments. Loading history...
121			$requestStack,
122			new ArgumentResolver()
123			))->handle(Request::create('/', 'GET'))
124			);
125			}
126
127			}
128
129			// http://api.symfony.com/3.3/Symfony/Bridge/Twig/TwigEngine.html
130			// http://api.symfony.com/3.3/Symfony/Bundle/TwigBundle/TwigEngine.html
131

symfony-util / controller-using-templating-http-foundation-http-kernel

Push — master ( aa0e3d...8f2a71 )

testComponentReturnsResponse() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like