DefaultControllerTest - Code Metrics - Inspection of "Update DefaultControllerTest.php" - symfony-util/controller-using-templating-http-foundation-http-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 02a76b...57ef55 )

by Jean-Bernard

created 2017-08-23 14:33 UTC

DefaultControllerTest A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	16
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	4
Bugs	0	Features	0

Metric	Value
wmc	1
c	4
b	0
f	0
lcom	0
cbo	2
dl	0
loc	16
rs	10

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;

class DefaultControllerTest extends WebTestCase
namespace YourVendor;

class YourClass { }
{
    public function testIndex()
    {
        $client = static::createClient();

        $crawler = $client->request('GET', '/');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $this->assertSame(
            200, // or Symfony\Component\HttpFoundation\Response::HTTP_OK,

            $client->getResponse()->getStatusCode()
        );

        $this->assertContains('Hello World!', $client->getResponse()->getContent());
    }
}


1		<?php
2
3		/*
4		* This file is part of the Symfony-Util package.
5		*
6		* (c) Jean-Bernard Addor
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
13
14	View Code Duplication	class DefaultControllerTest extends WebTestCase
		0 ignored issues – show Comprehensibility Best Practice introduced 2017-08-23 14:38 UTC by Report Bug Copy Issue Report The type `DefaultControllerTest` has been defined more than once; this definition is ignored, only the first definition in `tests/Component/DefaultControllerTest.php` (L14-29) is considered. This check looks for classes that have been defined more than once. If you can, we would recommend to use standard object-oriented programming techniques. For example, to avoid multiple types, it might make sense to create a common interface, and then multiple, different implementations for that interface. This also has the side-effect of providing you with better IDE auto-completion, static analysis and also better OPCode caching from PHP. Loading history... Duplication introduced 2017-08-22 20:22 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history... Coding Style Compatibility introduced 2017-08-23 14:38 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
15		{
16		public function testIndex()
17		{
18		$client = static::createClient();
19
20		$crawler = $client->request('GET', '/');
		0 ignored issues – show Unused Code introduced 2017-08-23 14:21 UTC by Report Bug Copy Issue Report `$crawler` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
21
22		$this->assertSame(
23		200, // or Symfony\Component\HttpFoundation\Response::HTTP_OK,
		0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-23 14:21 UTC by Report Bug Copy Issue Report `43%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
24		$client->getResponse()->getStatusCode()
25		);
26
27		$this->assertContains('Hello World!', $client->getResponse()->getContent());
28		}
29		}
30

symfony-util / controller-using-templating-http-foundation-http-kernel

Push — master ( 02a76b...57ef55 )

DefaultControllerTest A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

Duplication Side-by-Side

Filter issues like