Tests\FrameworkTwig\Identity

Complexity

Total Complexity

1

Size/Duplication

Total Lines	9
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

0

1 Method

Rating	Name	Duplication	Size	Complexity
A	__invoke()	0	6	1

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tests\FrameworkTwig;

use Knp\Rad\ResourceResolver\Bundle\ResourceResolverBundle;
use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Bundle\TwigBundle\TwigBundle;
use Symfony\Bundle\WebServerBundle\WebServerBundle;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\RouteCollectionBuilder;
use SymfonyUtil\Controller\EngineAsArgumentController;
use SymfonyUtil\Controller\TemplatingController;
use SymfonyUtil\Controller\VariadicController;

class Identity
{
    public function __invoke($a)
    {
        dump($a);

        return $a;
    }
}

class AppKernel extends Kernel

PSR1 recommends that each class should be in its own file to aid autoloaders.

{
    use MicroKernelTrait;

    public function registerBundles()
    {
        return [
            new FrameworkBundle(),
            new ResourceResolverBundle(),
            new TwigBundle(),
            new WebServerBundle()
        ];
    }

    protected function configureRoutes(RouteCollectionBuilder $routes)
    {
        $routes->add('/', EngineAsArgumentController::class, 'index');
        $routes->add('/argument', EngineAsArgumentController::class, 'argument');
        $routes->add('/constructor', TemplatingController::class, 'constructor');
        $routes->addRoute(new Route('/variadic/request', [
                '_controller' => VariadicController::class,
                '_resources' => ['\Identity', ['request']],
            ]),
            'variadic_request'
        );
    }

    protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader)

The parameter $loader is not used and could be removed.

    {
        //Controllers
        $c->autowire(EngineAsArgumentController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(true);

        $c->autowire(TemplatingController::class)
            ->setAutoconfigured(true)
            // ->addTag('controller.service_arguments')

67% of this comment could be valid code. Did you maybe forget this after debugging?

            ->setPublic(true);

        $c->autowire(VariadicController::class)
            ->setAutoconfigured(true)
            ->setPublic(true);

        $c->autowire('\Identity')
            ->setAutoconfigured(true)
            ->setPublic(true);

        // Extensions
        $c->loadFromExtension('framework', [
            'secret' => 'NotSecret', // What about use $ uuid -v4  or $ uuidgen
            'test' => in_array($this->getEnvironment(), ['test'], true), // test.client service for eg. PHPUnit
            'templating' => ['engines' => 'twig'],
        ]);
        $c->loadFromExtension('twig', [
            'debug' => true,
            'paths' => ['%kernel.project_dir%/tests/templates'],
        ]);
    }
}