Identity - Code Metrics - Inspection of "Update AppKernel.php" - symfony-util/controller-using-templating-http-foundation-http-kernel - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Push — master ( 49f28c...622303 )

by Jean-Bernard

created 2017-08-26 21:42 UTC

Identity A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	9
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes

Metric	Value
wmc	1
lcom	0
cbo	0
dl	0
loc	9
rs	10
c	0
b	0
f	0

<?php

/*
 * This file is part of the Symfony-Util package.
 *
 * (c) Jean-Bernard Addor
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace Tests\FrameworkTwig

use Knp\Rad\ResourceResolver\Bundle\ResourceResolverBundle;

use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
use Symfony\Bundle\TwigBundle\TwigBundle;
use Symfony\Bundle\WebServerBundle\WebServerBundle;
use Symfony\Component\Config\Loader\LoaderInterface;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\HttpKernel\Kernel;
use Symfony\Component\Routing\Route;
use Symfony\Component\Routing\RouteCollectionBuilder;
use SymfonyUtil\Controller\EngineAsArgumentController;
use SymfonyUtil\Controller\TemplatingController;
use SymfonyUtil\Controller\VariadicController;

class Identity
{
    public function __invoke($a)
    {
        dump($a);

        return $a;
    }
}

class AppKernel extends Kernel

{
    use MicroKernelTrait;

    public function registerBundles()
    {
        return [
            new FrameworkBundle(),
            new ResourceResolverBundle(),
            new TwigBundle(),
            new WebServerBundle()
        ];
    }

    protected function configureRoutes(RouteCollectionBuilder $routes)
    {
        $routes->add('/', EngineAsArgumentController::class, 'index');
        $routes->add('/argument', EngineAsArgumentController::class, 'argument');
        $routes->add('/constructor', TemplatingController::class, 'constructor');
        $routes->addRoute(new Route('/variadic/request', [
                '_controller' => VariadicController::class,
                '_resources' => ['\Identity', ['request']],
            ]),
            'variadic_request'
        );
    }

    protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader)
    {
        //Controllers
        $c->autowire(EngineAsArgumentController::class)
            ->setAutoconfigured(true)
            ->addTag('controller.service_arguments')
            ->setPublic(true);

        $c->autowire(TemplatingController::class)
            ->setAutoconfigured(true)
            // ->addTag('controller.service_arguments')

            ->setPublic(true);

        $c->autowire(VariadicController::class)
            ->setAutoconfigured(true)
            ->setPublic(true);

        $c->autowire('\Identity')
            ->setAutoconfigured(true)
            ->setPublic(true);

        // Extensions
        $c->loadFromExtension('framework', [
            'secret' => 'NotSecret', // What about use $ uuid -v4  or $ uuidgen
            'test' => in_array($this->getEnvironment(), ['test'], true), // test.client service for eg. PHPUnit
            'templating' => ['engines' => 'twig'],
        ]);
        $c->loadFromExtension('twig', [
            'debug' => true,
            'paths' => ['%kernel.project_dir%/tests/templates'],
        ]);
    }
}


1			<?php
2
3			/*
4			* This file is part of the Symfony-Util package.
5			*
6			* (c) Jean-Bernard Addor
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace Tests\FrameworkTwig
13
14			use Knp\Rad\ResourceResolver\Bundle\ResourceResolverBundle;
			0 ignored issues – show Bug introduced 2017-08-26 21:44 UTC by Report Bug Copy Issue Report This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_USE, expecting ';' or '{' Loading history...
15			use Symfony\Bundle\FrameworkBundle\FrameworkBundle;
16			use Symfony\Bundle\FrameworkBundle\Kernel\MicroKernelTrait;
17			use Symfony\Bundle\TwigBundle\TwigBundle;
18			use Symfony\Bundle\WebServerBundle\WebServerBundle;
19			use Symfony\Component\Config\Loader\LoaderInterface;
20			use Symfony\Component\DependencyInjection\ContainerBuilder;
21			use Symfony\Component\HttpKernel\Kernel;
22			use Symfony\Component\Routing\Route;
23			use Symfony\Component\Routing\RouteCollectionBuilder;
24			use SymfonyUtil\Controller\EngineAsArgumentController;
25			use SymfonyUtil\Controller\TemplatingController;
26			use SymfonyUtil\Controller\VariadicController;
27
28			class Identity
29			{
30			public function __invoke($a)
31			{
32			dump($a);
33
34			return $a;
35			}
36			}
37
38			class AppKernel extends Kernel
			0 ignored issues – show Coding Style Compatibility introduced 2017-08-26 20:33 UTC by Report Bug Copy Issue Report PSR1 recommends that each class should be in its own file to aid autoloaders. Having each class in a dedicated file usually plays nice with PSR autoloaders and is therefore a well established practice. If you use other autoloaders, you might not want to follow this rule. Loading history...
39			{
40			use MicroKernelTrait;
41
42			public function registerBundles()
43			{
44			return [
45			new FrameworkBundle(),
46			new ResourceResolverBundle(),
47			new TwigBundle(),
48			new WebServerBundle()
49			];
50			}
51
52			protected function configureRoutes(RouteCollectionBuilder $routes)
53			{
54			$routes->add('/', EngineAsArgumentController::class, 'index');
55			$routes->add('/argument', EngineAsArgumentController::class, 'argument');
56			$routes->add('/constructor', TemplatingController::class, 'constructor');
57			$routes->addRoute(new Route('/variadic/request', [
58			'_controller' => VariadicController::class,
59			'_resources' => ['\Identity', ['request']],
60			]),
61			'variadic_request'
62			);
63			}
64
65			protected function configureContainer(ContainerBuilder $c, LoaderInterface $loader)
66			{
67			//Controllers
68			$c->autowire(EngineAsArgumentController::class)
69			->setAutoconfigured(true)
70			->addTag('controller.service_arguments')
71			->setPublic(true);
72
73			$c->autowire(TemplatingController::class)
74			->setAutoconfigured(true)
75			// ->addTag('controller.service_arguments')
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-08-26 15:19 UTC by Report Bug Copy Issue Report `67%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
76			->setPublic(true);
77
78			$c->autowire(VariadicController::class)
79			->setAutoconfigured(true)
80			->setPublic(true);
81
82			$c->autowire('\Identity')
83			->setAutoconfigured(true)
84			->setPublic(true);
85
86			// Extensions
87			$c->loadFromExtension('framework', [
88			'secret' => 'NotSecret', // What about use $ uuid -v4 or $ uuidgen
89			'test' => in_array($this->getEnvironment(), ['test'], true), // test.client service for eg. PHPUnit
90			'templating' => ['engines' => 'twig'],
91			]);
92			$c->loadFromExtension('twig', [
93			'debug' => true,
94			'paths' => ['%kernel.project_dir%/tests/templates'],
95			]);
96			}
97			}
98

symfony-util / controller-using-templating-http-foundation-http-kernel

Push — master ( 49f28c...622303 )

Identity A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

Duplication Side-by-Side

Filter issues like