Process::getPid() - Code Metrics - Inspection of "[Core] Release 3.0" - symfony-bundles/fork - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#8)

by Dmitry

created 2018-02-12 23:01 UTC

Process::getPid() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	2
cts	2
cp	1
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0
crap	1

<?php

namespace SymfonyBundles\Fork;

class Process implements ProcessInterface
{
    /**
     * @var bool
     */
    protected $isAllowedFork;

    /**
     * @var int
     */
    protected $processesCount;

    /**
     * Constructor.
     */
    public function __construct()
    {
        $this->isAllowedFork = function_exists('pcntl_fork');
    }

    /**
     * {@inheritdoc}
     */
    public function create(\Closure $closure): ProcessInterface
    {
        for ($i = 0; $i < $this->processesCount; ++$i) {
            if ($this->fork()) {
                $closure();

                $this->terminate();
            }
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function wait(): ProcessInterface
    {
        if ($this->isAllowedFork) {
            pcntl_wait($status);
        }

        return $this;
    }

    /**
     * {@inheritdoc}
     */
    public function getPid(): int
    {
        return getmypid();
    }

    /**
     * {@inheritdoc}
     *
     * @codeCoverageIgnore
     */
    public function isAlive(int $pid): bool
    {
        $os = strtolower(trim(PHP_OS));

        switch ($os) {
            case 'linux':
                return empty($this->execute(sprintf('kill -0 %d', $pid)));
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
            case 'winnt':
            case 'windows':
                $output = $this->execute(sprintf('wmic process where processId=%d get processId', $pid));

                return $pid === (int) preg_replace('#[^\d]*#', '', $output);
                break;
switch ($x) {
    case 1:
        return 'foo';
        break; // This break is not necessary and can be left off.
}
        }

        return false;
    }

    /**
     * {@inheritdoc}
     */
    public function getMemoryUsage(): float
    {
        return round(memory_get_usage(true) / 1024 / 1024, 2);
    }

    /**
     * {@inheritdoc}
     */
    public function setCountOfChildProcesses(int $processesCount): ProcessInterface
    {
        if ($processesCount < 1) {
            $processesCount = $this->getOptimalNumberOfChildProcesses();
        }

        if ($processesCount > static::MAX_PROCESSES_QUANTITY) {
            $processesCount = static::MAX_PROCESSES_QUANTITY;
        }

        if ($this->isAllowedFork) {
            $this->processesCount = $processesCount;
        } else {
            $this->processesCount = 1;
        }

        return $this;
    }

    /**
     * @return bool Returns TRUE if this is a child process, else - FALSE
     */
    protected function fork(): bool
    {
        if ($this->isAllowedFork) {
            return 0 === pcntl_fork();
        }

        return true;
    }

    /**
     * @codeCoverageIgnore
     *
     * @return bool
     */
    protected function terminate(): bool
    {
        if ($this->isAllowedFork) {
            return posix_kill(getmypid(), SIGKILL);
        }

        return true;
    }

    /**
     * Returns the optimal number of child processes.
     *
     * @return int
     */
    protected function getOptimalNumberOfChildProcesses(): int
    {
        $coreNumber = 1;
        $detectCommand = [
            'linux' => 'cat /proc/cpuinfo | grep processor | wc -l',
        ];

        $os = strtolower(trim(PHP_OS));

        if (isset($detectCommand[$os])) {
            $coreNumber = intval($this->execute($detectCommand[$os]));
        }

        return $coreNumber;
    }

    /**
     * @param string $command
     *
     * @return string
     */
    protected function execute(string $command): string
    {
        return trim(shell_exec($command));
    }
}


1		<?php
2
3		namespace SymfonyBundles\Fork;
4
5		class Process implements ProcessInterface
6		{
7		/**
8		* @var bool
9		*/
10		protected $isAllowedFork;
11
12		/**
13		* @var int
14		*/
15		protected $processesCount;
16
17		/**
18		* Constructor.
19		*/
20	9	public function __construct()
21		{
22	9	$this->isAllowedFork = function_exists('pcntl_fork');
23	9	}
24
25		/**
26		* {@inheritdoc}
27		*/
28	3	public function create(\Closure $closure): ProcessInterface
29		{
30	3	for ($i = 0; $i < $this->processesCount; ++$i) {
31	3	if ($this->fork()) {
32	2	$closure();
33
34	2	$this->terminate();
35		}
36		}
37
38	3	return $this;
39		}
40
41		/**
42		* {@inheritdoc}
43		*/
44	1	public function wait(): ProcessInterface
45		{
46	1	if ($this->isAllowedFork) {
47	1	pcntl_wait($status);
48		}
49
50	1	return $this;
51		}
52
53		/**
54		* {@inheritdoc}
55		*/
56	1	public function getPid(): int
57		{
58	1	return getmypid();
59		}
60
61		/**
62		* {@inheritdoc}
63		*
64		* @codeCoverageIgnore
65		*/
66		public function isAlive(int $pid): bool
67		{
68		$os = strtolower(trim(PHP_OS));
69
70		switch ($os) {
71		case 'linux':
72		return empty($this->execute(sprintf('kill -0 %d', $pid)));
73		break;
		0 ignored issues – show Unused Code introduced 2018-02-12 22:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
74		case 'winnt':
75		case 'windows':
76		$output = $this->execute(sprintf('wmic process where processId=%d get processId', $pid));
77
78		return $pid === (int) preg_replace('#[^\d]*#', '', $output);
79		break;
		0 ignored issues – show Unused Code introduced 2018-02-12 22:56 UTC by Report Bug Copy Issue Report `break` is not strictly necessary here and could be removed. The `break` statement is not necessary if it is preceded for example by a `return` statement: switch ($x) { case 1: return 'foo'; break; // This break is not necessary and can be left off. } If you would like to keep this construct to be consistent with other `case` statements, you can safely mark this issue as a false-positive. Loading history...
80		}
81
82		return false;
83		}
84
85		/**
86		* {@inheritdoc}
87		*/
88	1	public function getMemoryUsage(): float
89		{
90	1	return round(memory_get_usage(true) / 1024 / 1024, 2);
91		}
92
93		/**
94		* {@inheritdoc}
95		*/
96	5	public function setCountOfChildProcesses(int $processesCount): ProcessInterface
97		{
98	5	if ($processesCount < 1) {
99	2	$processesCount = $this->getOptimalNumberOfChildProcesses();
100		}
101
102	5	if ($processesCount > static::MAX_PROCESSES_QUANTITY) {
103	1	$processesCount = static::MAX_PROCESSES_QUANTITY;
104		}
105
106	5	if ($this->isAllowedFork) {
107	4	$this->processesCount = $processesCount;
108		} else {
109	1	$this->processesCount = 1;
110		}
111
112	5	return $this;
113		}
114
115		/**
116		* @return bool Returns TRUE if this is a child process, else - FALSE
117		*/
118	2	protected function fork(): bool
119		{
120	2	if ($this->isAllowedFork) {
121	1	return 0 === pcntl_fork();
122		}
123
124	1	return true;
125		}
126
127		/**
128		* @codeCoverageIgnore
129		*
130		* @return bool
131		*/
132		protected function terminate(): bool
133		{
134		if ($this->isAllowedFork) {
135		return posix_kill(getmypid(), SIGKILL);
136		}
137
138		return true;
139		}
140
141		/**
142		* Returns the optimal number of child processes.
143		*
144		* @return int
145		*/
146	2	protected function getOptimalNumberOfChildProcesses(): int
147		{
148	2	$coreNumber = 1;
149		$detectCommand = [
150	2	'linux' => 'cat /proc/cpuinfo \| grep processor \| wc -l',
151		];
152
153	2	$os = strtolower(trim(PHP_OS));
154
155	2	if (isset($detectCommand[$os])) {
156	2	$coreNumber = intval($this->execute($detectCommand[$os]));
157		}
158
159	2	return $coreNumber;
160		}
161
162		/**
163		* @param string $command
164		*
165		* @return string
166		*/
167	3	protected function execute(string $command): string
168		{
169	3	return trim(shell_exec($command));
170		}
171		}
172

symfony-bundles / fork

Pull Request — master (#8)

Process::getPid() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like