Issues in VersionedImageExtension.php (master) - Issues in master - symbiote/silverstripe-versionedfiles - Measure and Improve Code Quality continuously with Scrutinizer

Issues (67)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/VersionedImageExtension.php (3 issues)

Labels

Bug 3

Severity

Major 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * An extension to automatically regenerate all cached/resampled images when an
 * image version is changed.
 *
 * @package silverstripe-versionedfiles
 */
class VersionedImageExtension extends DataExtension
{
    /**
     * Regenerates all cached images if the version number has been changed.
     */
    public function onBeforeWrite()
    {
        if (!$this->owner->isChanged('CurrentVersionID')) {
            return;
        }

        // Support new {@see Image::regenerateFormattedImages} method in 3.2
        if ($this->owner->hasMethod('regenerateFormattedImages')) {
            $this->owner->regenerateFormattedImages();
            return;
        }

        if ($this->owner->ParentID) {

            $base = $this->owner->Parent()->getFullPath();

        } else {
            $base = ASSETS_PATH . '/';
        }

        $resampled = "{$base}_resampled";
        if (!is_dir($resampled)) {
            return;
        }

        $files    = scandir($resampled);
        $iterator = new ArrayIterator($files);
        $filter   = new RegexIterator(
            $iterator,
            sprintf(
                "/([a-z]+)([0-9]?[0-9a-f]*)-%s/i",
                preg_quote($this->owner->Name)

            ),
            RegexIterator::GET_MATCH
        );

        // grab each resampled image and regenerate it
        foreach ($filter as $cachedImage) {
            $path      = "$resampled/{$cachedImage[0]}";

            //skip resampled image files that don't exist
            if (!file_exists($path)) {
                continue;
            }

            $size      = getimagesize($path);
            $method    = $cachedImage[1];
            $arguments = $cachedImage[2];

            unlink($path);

            // Determine the arguments used to generate an image, and regenerate
            // it. Different methods need different ways of determining the
            // original arguments used.
            switch (strtolower($method)) {
                case 'paddedimage':
                    $color = preg_replace("/^{$size[0]}{$size[1]}/", '', $arguments);
                    $this->owner->$method($size[0], $size[1], $color);
                    break;
                case 'resizedimage':
                case 'setsize':
                case 'croppedimage':
                case 'setratiosize':
                case 'croppedfocusedimage':
                    $this->owner->$method($size[0], $size[1]);
                    break;

                case 'setwidth':
                    $this->owner->$method($size[0]);
                    break;

                case 'setheight':
                    $this->owner->$method($size[1]);
                    break;

                default:
                    $this->owner->$method($arguments);
                    break;
            }
        }
    }
}


1			<?php
2			/**
3			* An extension to automatically regenerate all cached/resampled images when an
4			* image version is changed.
5			*
6			* @package silverstripe-versionedfiles
7			*/
8			class VersionedImageExtension extends DataExtension
9			{
10			/**
11			* Regenerates all cached images if the version number has been changed.
12			*/
13			public function onBeforeWrite()
14			{
15			if (!$this->owner->isChanged('CurrentVersionID')) {
16			return;
17			}
18
19			// Support new {@see Image::regenerateFormattedImages} method in 3.2
20			if ($this->owner->hasMethod('regenerateFormattedImages')) {
21			$this->owner->regenerateFormattedImages();
22			return;
23			}
24
25			if ($this->owner->ParentID) {
			0 ignored issues – show Bug introduced 2018-06-17 22:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `ParentID` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
26			$base = $this->owner->Parent()->getFullPath();
			0 ignored issues – show Bug introduced 2018-06-17 22:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Parent()` does not exist on `SS_Object`. Did you maybe mean `parentClass()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
27			} else {
28			$base = ASSETS_PATH . '/';
29			}
30
31			$resampled = "{$base}_resampled";
32			if (!is_dir($resampled)) {
33			return;
34			}
35
36			$files = scandir($resampled);
37			$iterator = new ArrayIterator($files);
38			$filter = new RegexIterator(
39			$iterator,
40			sprintf(
41			"/([a-z]+)([0-9]?[0-9a-f]*)-%s/i",
42			preg_quote($this->owner->Name)
			0 ignored issues – show Bug introduced 2018-06-17 22:03 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Name` does not seem to exist in `SS_Object`. An attempt at access to an undefined property has been detected. This may either be a typographical error or the property has been renamed but there are still references to its old name. If you really want to allow access to undefined properties, you can define magic methods to allow access. See the php core documentation on Overloading. Loading history...
43			),
44			RegexIterator::GET_MATCH
45			);
46
47			// grab each resampled image and regenerate it
48			foreach ($filter as $cachedImage) {
49			$path = "$resampled/{$cachedImage[0]}";
50
51			//skip resampled image files that don't exist
52			if (!file_exists($path)) {
53			continue;
54			}
55
56			$size = getimagesize($path);
57			$method = $cachedImage[1];
58			$arguments = $cachedImage[2];
59
60			unlink($path);
61
62			// Determine the arguments used to generate an image, and regenerate
63			// it. Different methods need different ways of determining the
64			// original arguments used.
65			switch (strtolower($method)) {
66			case 'paddedimage':
67			$color = preg_replace("/^{$size[0]}{$size[1]}/", '', $arguments);
68			$this->owner->$method($size[0], $size[1], $color);
69			break;
70			case 'resizedimage':
71			case 'setsize':
72			case 'croppedimage':
73			case 'setratiosize':
74			case 'croppedfocusedimage':
75			$this->owner->$method($size[0], $size[1]);
76			break;
77
78			case 'setwidth':
79			$this->owner->$method($size[0]);
80			break;
81
82			case 'setheight':
83			$this->owner->$method($size[1]);
84			break;
85
86			default:
87			$this->owner->$method($arguments);
88			break;
89			}
90			}
91			}
92			}
93

symbiote / silverstripe-versionedfiles

Issues (67)

Security Analysis not enabled

code/VersionedImageExtension.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like