Issues in VersionedFileUploadField.php (master) - Issues in master - symbiote/silverstripe-versionedfiles - Measure and Improve Code Quality continuously with Scrutinizer

Issues (67)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/VersionedFileUploadField.php (8 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
class VersionedFileUploadField extends UploadField
{
    private static $allowed_actions = array(

        'upload'
    );

    /**
     * The file to upload a new version of
     * @var File
     */
    public $currentVersionFile;


    /**
     * Action to handle upload of a single file
     * 
     * @param SS_HTTPRequest $request
     * @return string json
     */
    public function upload(SS_HTTPRequest $request)
    {
        if (!$this->currentVersionFile) {
            return;
        }


        if ($this->isDisabled() || $this->isReadonly()) {
            return $this->httpError(403);
        }

        // Protect against CSRF on destructive action
        $token = $this->getForm()->getSecurityToken();
        if (!$token->checkRequest($request)) {
            return $this->httpError(400);
        }

        $name = $this->getName();
        $tmpfile = $request->postVar($name);
        $record = $this->getRecord();
        
        // Check if the file has been uploaded into the temporary storage.
        if (!$tmpfile) {
            $return = array('error' => _t('UploadField.FIELDNOTSET', 'File information not found'));
        } else {
            $return = array(
                'name' => $tmpfile['name'],
                'size' => $tmpfile['size'],
                'type' => $tmpfile['type'],
                'error' => $tmpfile['error']
            );
        }

        // Check for constraints on the record to which the file will be attached.
        if (!$return['error'] && $this->relationAutoSetting && $record && $record->exists()) {
            $tooManyFiles = false;
            // Some relationships allow many files to be attached.
            if ($this->getConfig('allowedMaxFileNumber') && ($record->has_many($name) || $record->many_many($name))) {

                if (!$record->isInDB()) {
                    $record->write();
                }
                $tooManyFiles = $record->{$name}()->count() >= $this->getConfig('allowedMaxFileNumber');
            // has_one only allows one file at any given time.
            } elseif ($record->has_one($name)) {

                $tooManyFiles = $record->{$name}() && $record->{$name}()->exists();
            }

            // Report the constraint violation.
            if ($tooManyFiles) {
                if (!$this->getConfig('allowedMaxFileNumber')) {
                    $this->setConfig('allowedMaxFileNumber', 1);
                }
                $return['error'] = _t(
                    'UploadField.MAXNUMBEROFFILES',
                    'Max number of {count} file(s) exceeded.',
                    array('count' => $this->getConfig('allowedMaxFileNumber'))
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                );
            }
        }

        // Process the uploaded file
        if (!$return['error']) {
            // Get the uploaded file into a new file object.
            try {
                $currentFilePath = $this->currentVersionFile->getFullPath();
                if (file_exists($currentFilePath)) {
                    unlink($this->currentVersionFile->getFullPath());
                }

                // If $folderName == assets (by default), then this will try and create a file inside assets/assets
                // instead of creating it in the root. This check ensures that the newly uploaded files overwrites the
                // old file in the assets root directory.
                $folderName = $this->folderName;
                if ($folderName == basename(ASSETS_PATH)) {
                    $folderName = "/";
                }

                $this->upload->loadIntoFile(
                    array_merge($tmpfile, array('name' => $this->currentVersionFile->Name)),
                    $this->currentVersionFile,
                    $folderName
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                );
            } catch (Exception $e) {
                // we shouldn't get an error here, but just in case
                $return['error'] = $e->getMessage();
            }

            if (!$return['error']) {
                if ($this->upload->isError()) {
                    $return['error'] = implode(' '.PHP_EOL, $this->upload->getErrors());
                } else {
                    $file = $this->upload->getFile();

                    $file->createVersion();

                    // Attach the file to the related record.
                    if ($this->relationAutoSetting) {
                        $this->attachFile($file);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
                    }

                    // Collect all output data.
                    $file =  $this->customiseFile($file);
                    $return = array_merge($return, array(
                        'id' => $file->ID,
                        'name' => $file->getTitle() . '.' . $file->getExtension(),

                        'url' => $file->getURL(),
                        'thumbnail_url' => $file->UploadFieldThumbnailURL,
                        'edit_url' => $file->UploadFieldEditLink,
                        'size' => $file->getAbsoluteSize(),
                        'buttons' => $file->UploadFieldFileButtons
                    ));
                }
            }
        }
        $response = new SS_HTTPResponse(Convert::raw2json(array($return)));
        $response->addHeader('Content-Type', 'text/plain');
        return $response;
    }
}


1			<?php
2			class VersionedFileUploadField extends UploadField
3			{
4			private static $allowed_actions = array(
			0 ignored issues – show Comprehensibility introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this Consider using a different property name as you override a private property of the parent class. Loading history...
5			'upload'
6			);
7
8			/**
9			* The file to upload a new version of
10			* @var File
11			*/
12			public $currentVersionFile;
13
14
15			/**
16			* Action to handle upload of a single file
17			*
18			* @param SS_HTTPRequest $request
19			* @return string json
20			*/
21			public function upload(SS_HTTPRequest $request)
22			{
23			if (!$this->currentVersionFile) {
24			return;
25			}
26
27
28			if ($this->isDisabled() \|\| $this->isReadonly()) {
29			return $this->httpError(403);
30			}
31
32			// Protect against CSRF on destructive action
33			$token = $this->getForm()->getSecurityToken();
34			if (!$token->checkRequest($request)) {
35			return $this->httpError(400);
36			}
37
38			$name = $this->getName();
39			$tmpfile = $request->postVar($name);
40			$record = $this->getRecord();
41
42			// Check if the file has been uploaded into the temporary storage.
43			if (!$tmpfile) {
44			$return = array('error' => _t('UploadField.FIELDNOTSET', 'File information not found'));
45			} else {
46			$return = array(
47			'name' => $tmpfile['name'],
48			'size' => $tmpfile['size'],
49			'type' => $tmpfile['type'],
50			'error' => $tmpfile['error']
51			);
52			}
53
54			// Check for constraints on the record to which the file will be attached.
55			if (!$return['error'] && $this->relationAutoSetting && $record && $record->exists()) {
56			$tooManyFiles = false;
57			// Some relationships allow many files to be attached.
58			if ($this->getConfig('allowedMaxFileNumber') && ($record->has_many($name) \|\| $record->many_many($name))) {
			0 ignored issues – show Deprecated Code introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `DataObject::has_many()` has been deprecated with message: 4.0 Method has been replaced by hasMany() and hasManyComponent() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history... Deprecated Code introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `DataObject::many_many()` has been deprecated with message: 4.0 Method has been renamed to manyMany() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
59			if (!$record->isInDB()) {
60			$record->write();
61			}
62			$tooManyFiles = $record->{$name}()->count() >= $this->getConfig('allowedMaxFileNumber');
63			// has_one only allows one file at any given time.
64			} elseif ($record->has_one($name)) {
			0 ignored issues – show Deprecated Code introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `DataObject::has_one()` has been deprecated with message: 4.0 Method has been replaced by hasOne() and hasOneComponent() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
65			$tooManyFiles = $record->{$name}() && $record->{$name}()->exists();
66			}
67
68			// Report the constraint violation.
69			if ($tooManyFiles) {
70			if (!$this->getConfig('allowedMaxFileNumber')) {
71			$this->setConfig('allowedMaxFileNumber', 1);
72			}
73			$return['error'] = _t(
74			'UploadField.MAXNUMBEROFFILES',
75			'Max number of {count} file(s) exceeded.',
76			array('count' => $this->getConfig('allowedMaxFileNumber'))
			0 ignored issues – show Documentation introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('count' => $this->...allowedMaxFileNumber'))` is of type `array<string,,{"count":""}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
77			);
78			}
79			}
80
81			// Process the uploaded file
82			if (!$return['error']) {
83			// Get the uploaded file into a new file object.
84			try {
85			$currentFilePath = $this->currentVersionFile->getFullPath();
86			if (file_exists($currentFilePath)) {
87			unlink($this->currentVersionFile->getFullPath());
88			}
89
90			// If $folderName == assets (by default), then this will try and create a file inside assets/assets
91			// instead of creating it in the root. This check ensures that the newly uploaded files overwrites the
92			// old file in the assets root directory.
93			$folderName = $this->folderName;
94			if ($folderName == basename(ASSETS_PATH)) {
95			$folderName = "/";
96			}
97
98			$this->upload->loadIntoFile(
99			array_merge($tmpfile, array('name' => $this->currentVersionFile->Name)),
100			$this->currentVersionFile,
101			$folderName
			0 ignored issues – show Documentation introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$folderName` is of type `string`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
102			);
103			} catch (Exception $e) {
104			// we shouldn't get an error here, but just in case
105			$return['error'] = $e->getMessage();
106			}
107
108			if (!$return['error']) {
109			if ($this->upload->isError()) {
110			$return['error'] = implode(' '.PHP_EOL, $this->upload->getErrors());
111			} else {
112			$file = $this->upload->getFile();
113
114			$file->createVersion();
115
116			// Attach the file to the related record.
117			if ($this->relationAutoSetting) {
118			$this->attachFile($file);
			0 ignored issues – show Documentation Bug introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `attachFile` does not exist on `object<VersionedFileUploadField>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
119			}
120
121			// Collect all output data.
122			$file = $this->customiseFile($file);
123			$return = array_merge($return, array(
124			'id' => $file->ID,
125			'name' => $file->getTitle() . '.' . $file->getExtension(),
			0 ignored issues – show Bug introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getExtension()` does not exist on `ViewableData_Customised`. Did you maybe mean `getExtensionInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
126			'url' => $file->getURL(),
127			'thumbnail_url' => $file->UploadFieldThumbnailURL,
128			'edit_url' => $file->UploadFieldEditLink,
129			'size' => $file->getAbsoluteSize(),
130			'buttons' => $file->UploadFieldFileButtons
131			));
132			}
133			}
134			}
135			$response = new SS_HTTPResponse(Convert::raw2json(array($return)));
136			$response->addHeader('Content-Type', 'text/plain');
137			return $response;
138			}
139			}
140

symbiote / silverstripe-versionedfiles

Issues (67)

Security Analysis not enabled

code/VersionedFileUploadField.php (8 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like