Issues in FileVersion.php (master) - Issues in master - symbiote/silverstripe-versionedfiles - Measure and Improve Code Quality continuously with Scrutinizer

Issues (67)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

code/FileVersion.php (3 issues)

Labels

Severity

Damian Mooyman 3

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * This class represents a single version of a file. Each file can have many
 * versions, and one of these is currently active at any one time.
 *
 * @package silverstripe-versionedfiles
 */
class FileVersion extends DataObject
{
    const VERSION_FOLDER = '_versions';

    private static $db = array(
        'VersionNumber' => 'Int',
        'Filename'      => 'Varchar(255)'
    );

    private static $has_one = array(
        'Creator' => 'Member',
        'File'    => 'File'
    );

    /**
     * Saves version meta-data, and generates the saved file version on first
     * write.
     */
    public function onBeforeWrite()
    {
        if (!$this->isInDB()) {
            $this->CreatorID = Member::currentUserID();
        }

        if (!$this->VersionNumber) {
            $versions = DataObject::get(
                'FileVersion', sprintf('"FileID" = %d', $this->FileID)
            );

            if ($versions) {
                $this->VersionNumber = $versions->Count() + 1;
            } else {
                $this->VersionNumber = 1;
            }
        }

        if (!$this->Filename) {
            $this->Filename = $this->saveCurrentVersion();
        }

        parent::onBeforeWrite();
    }

    public function onBeforeDelete()
    {
        if (file_exists($this->getFullPath())) {
            unlink($this->getFullPath());
        }

        parent::onBeforeDelete();
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return sprintf(
            _t('VersionNumber.VERSIONNUM', "Version %d"), $this->VersionNumber
        );
    }

    /**
     * @return string
     */
    public function getName()
    {
        return basename($this->Filename);
    }

    /**
     * @return string
     */
    public function getURL()
    {
        return Controller::join_links(Director::baseURL(), $this->Filename);
    }

    /**
     * @return string
     */
    public function getFullPath()
    {
        return Director::baseFolder() . $this->Filename;
    }

    /**
     * Returns a Boolean object indicating if this version is currently active.
     *
     * @return Boolean
     */
    public function IsCurrent()
    {
        return DBField::create_field(
            'Boolean', ($this->File()->CurrentVersionID == $this->ID)
        );
    }

    /**
     * Saves the current version of the linked File object in a versions
     * directory, then returns the relative path to where it is stored.
     *
     * @return string
     */
    protected function saveCurrentVersion()
    {
        // Ensure we re-fetch fresh record from database (in case it was recently renamed / moved)
        $file = File::get()->byID($this->FileID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        if ($file->ParentID) {
            $base = Controller::join_links(
                $file->Parent()->getFullPath(),

                self::VERSION_FOLDER,
                $this->FileID
            );
        } else {
            $base = Controller::join_links(
                Director::baseFolder(),
                ASSETS_DIR,
                self::VERSION_FOLDER,
                $this->FileID
            );
        }

        Filesystem::makeFolder($base);

        $extension = $file->getExtension();

        $basename  = basename($file->Name, $extension);
        $version   = $this->VersionNumber;

        $cachedPath = Controller::join_links(
            $base, "{$basename}$version.$extension"
        );

        if (!copy($file->getFullPath(), $cachedPath)) {
            throw new Exception(
                "Unable to copy version #$version of file #$this->FileID from:\n \"{$file->getFullPath()}\"\nto:\n\"$cachedPath\""
            );
        }

        return Director::makeRelative($cachedPath);
    }
}


1			<?php
2			/**
3			* This class represents a single version of a file. Each file can have many
4			* versions, and one of these is currently active at any one time.
5			*
6			* @package silverstripe-versionedfiles
7			*/
8			class FileVersion extends DataObject
9			{
10			const VERSION_FOLDER = '_versions';
11
12			private static $db = array(
13			'VersionNumber' => 'Int',
14			'Filename' => 'Varchar(255)'
15			);
16
17			private static $has_one = array(
18			'Creator' => 'Member',
19			'File' => 'File'
20			);
21
22			/**
23			* Saves version meta-data, and generates the saved file version on first
24			* write.
25			*/
26			public function onBeforeWrite()
27			{
28			if (!$this->isInDB()) {
29			$this->CreatorID = Member::currentUserID();
30			}
31
32			if (!$this->VersionNumber) {
33			$versions = DataObject::get(
34			'FileVersion', sprintf('"FileID" = %d', $this->FileID)
35			);
36
37			if ($versions) {
38			$this->VersionNumber = $versions->Count() + 1;
39			} else {
40			$this->VersionNumber = 1;
41			}
42			}
43
44			if (!$this->Filename) {
45			$this->Filename = $this->saveCurrentVersion();
46			}
47
48			parent::onBeforeWrite();
49			}
50
51			public function onBeforeDelete()
52			{
53			if (file_exists($this->getFullPath())) {
54			unlink($this->getFullPath());
55			}
56
57			parent::onBeforeDelete();
58			}
59
60			/**
61			* @return string
62			*/
63			public function getTitle()
64			{
65			return sprintf(
66			_t('VersionNumber.VERSIONNUM', "Version %d"), $this->VersionNumber
67			);
68			}
69
70			/**
71			* @return string
72			*/
73			public function getName()
74			{
75			return basename($this->Filename);
76			}
77
78			/**
79			* @return string
80			*/
81			public function getURL()
82			{
83			return Controller::join_links(Director::baseURL(), $this->Filename);
84			}
85
86			/**
87			* @return string
88			*/
89			public function getFullPath()
90			{
91			return Director::baseFolder() . $this->Filename;
92			}
93
94			/**
95			* Returns a Boolean object indicating if this version is currently active.
96			*
97			* @return Boolean
98			*/
99			public function IsCurrent()
100			{
101			return DBField::create_field(
102			'Boolean', ($this->File()->CurrentVersionID == $this->ID)
103			);
104			}
105
106			/**
107			* Saves the current version of the linked File object in a versions
108			* directory, then returns the relative path to where it is stored.
109			*
110			* @return string
111			*/
112			protected function saveCurrentVersion()
113			{
114			// Ensure we re-fetch fresh record from database (in case it was recently renamed / moved)
115			$file = File::get()->byID($this->FileID);
			0 ignored issues – show Documentation introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `FileID` does not exist on `object<FileVersion>`. Since you implemented `__get`, maybe consider adding a @property annotation. Since your code implements the magic getter `_get`, this function will be called for any read access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } If the property has read access only, you can use the @property-read annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
116			if ($file->ParentID) {
117			$base = Controller::join_links(
118			$file->Parent()->getFullPath(),
			0 ignored issues – show Bug introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `Parent()` does not exist on `DataObject`. Did you maybe mean `parentClass()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
119			self::VERSION_FOLDER,
120			$this->FileID
121			);
122			} else {
123			$base = Controller::join_links(
124			Director::baseFolder(),
125			ASSETS_DIR,
126			self::VERSION_FOLDER,
127			$this->FileID
128			);
129			}
130
131			Filesystem::makeFolder($base);
132
133			$extension = $file->getExtension();
			0 ignored issues – show Bug introduced 2017-10-01 22:58 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `getExtension()` does not exist on `DataObject`. Did you maybe mean `getExtensionInstance()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
134			$basename = basename($file->Name, $extension);
135			$version = $this->VersionNumber;
136
137			$cachedPath = Controller::join_links(
138			$base, "{$basename}$version.$extension"
139			);
140
141			if (!copy($file->getFullPath(), $cachedPath)) {
142			throw new Exception(
143			"Unable to copy version #$version of file #$this->FileID from:\n \"{$file->getFullPath()}\"\nto:\n\"$cachedPath\""
144			);
145			}
146
147			return Director::makeRelative($cachedPath);
148			}
149			}
150

symbiote / silverstripe-versionedfiles

Issues (67)

Security Analysis not enabled

code/FileVersion.php (3 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like