DataExtension::updateCMSFields() - Code Metrics - Inspection of "Feature review for various features." - symbiote/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#290)

unknown

created 2020-04-23 23:13 UTC

DataExtension::updateCMSFields() A

↳ Parent: DataExtension

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace App\Queue\Admin;

use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\LiteralField;
use SilverStripe\Forms\TextareaField;
use SilverStripe\ORM\DataExtension as BaseDataExtension;
use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;

/**
 * Class DataExtension
 *
 * @property QueuedJobDescriptor|$this $owner
 * @package App\Queue\Admin
 */
class DataExtension extends BaseDataExtension
{

    /**
     * @param FieldList $fields
     */
    public function updateCMSFields(FieldList $fields): void
    {
        $owner = $this->owner;

        $fields->addFieldsToTab('Root.JobData', [
            $jobDataPreview = TextareaField::create('SavedJobDataPreview', 'Job Data'),
        ]);

        if (strlen($owner->getMessagesRaw()) > 0) {
            $fields->addFieldToTab(
                'Root.MessagesRaw',
                $messagesRaw = LiteralField::create('MessagesRaw', $owner->getMessagesRaw())
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            );
        }

        $jobDataPreview->setReadonly(true);
    }

    /**
     * @return string|null
     */
    public function getSavedJobDataPreview(): ?string
    {
        return $this->owner->SavedJobData;
    }

    /**
     * @return string|null
     */
    public function getMessagesRaw(): ?string
    {
        return $this->owner->SavedJobMessages;
    }

    /**
     * @return string
     */
    public function getImplementationSummary(): string
    {
        $segments = explode('\\', $this->owner->Implementation);

        while (count($segments) > 2) {
            array_shift($segments);
        }

        return implode('\\', $segments);
    }
}


1			<?php
2
3			namespace App\Queue\Admin;
4
5			use SilverStripe\Forms\FieldList;
6			use SilverStripe\Forms\LiteralField;
7			use SilverStripe\Forms\TextareaField;
8			use SilverStripe\ORM\DataExtension as BaseDataExtension;
9			use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;
10
11			/**
12			* Class DataExtension
13			*
14			* @property QueuedJobDescriptor\|$this $owner
15			* @package App\Queue\Admin
16			*/
17			class DataExtension extends BaseDataExtension
18			{
19
20			/**
21			* @param FieldList $fields
22			*/
23			public function updateCMSFields(FieldList $fields): void
24			{
25			$owner = $this->owner;
26
27			$fields->addFieldsToTab('Root.JobData', [
28			$jobDataPreview = TextareaField::create('SavedJobDataPreview', 'Job Data'),
29			]);
30
31			if (strlen($owner->getMessagesRaw()) > 0) {
32			$fields->addFieldToTab(
33			'Root.MessagesRaw',
34			$messagesRaw = LiteralField::create('MessagesRaw', $owner->getMessagesRaw())
			0 ignored issues – show Bug introduced 2020-04-23 23:15 UTC by Report Bug Copy Issue Report The method `getMessagesRaw` does only exist in `App\Queue\Admin\DataExtension`, but not in `Symbiote\QueuedJobs\Data...cts\QueuedJobDescriptor`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
35			);
36			}
37
38			$jobDataPreview->setReadonly(true);
39			}
40
41			/**
42			* @return string\|null
43			*/
44			public function getSavedJobDataPreview(): ?string
45			{
46			return $this->owner->SavedJobData;
47			}
48
49			/**
50			* @return string\|null
51			*/
52			public function getMessagesRaw(): ?string
53			{
54			return $this->owner->SavedJobMessages;
55			}
56
57			/**
58			* @return string
59			*/
60			public function getImplementationSummary(): string
61			{
62			$segments = explode('\\', $this->owner->Implementation);
63
64			while (count($segments) > 2) {
65			array_shift($segments);
66			}
67
68			return implode('\\', $segments);
69			}
70			}
71

symbiote / silverstripe-queuedjobs

GitHub Access Token became invalid

Pull Request — master (#290)

DataExtension::updateCMSFields() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like