symbiote / silverstripe-queuedjobs

src/Services/QueuedJobService.php

Unused Use Statements -3 removed lines

@@ -6,20 +6,17 @@
 use SilverStripe\Control\Controller;
 use SilverStripe\Control\Director;
 use SilverStripe\Control\Email\Email;
-use SilverStripe\Control\Session;
 use SilverStripe\Core\Config\Config;
 use SilverStripe\Core\Config\Configurable;
 use SilverStripe\Core\Convert;
 use SilverStripe\Core\Extensible;
 use SilverStripe\Core\Injector\Injectable;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Dev\SapphireTest;
 use SilverStripe\ORM\DataList;
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\DB;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Security\Member;
-use SilverStripe\Security\Permission;
 use SilverStripe\Security\Security;
 use Psr\Log\LoggerInterface;
 use SilverStripe\Subsites\Model\Subsite;

Doc Comments +8 added lines, -4 removed lines

@@ -152,7 +152,7 @@ 
      *
      * @param QueuedJob $job
      *          The job to start.
-     * @param $startAfter
+     * @param string $startAfter
      *          The date (in Y-m-d H:i:s format) to start execution after
      * @param int $userId
      *          The ID of a user to execute the job as. Defaults to the current user
@@ -208,7 +208,7 @@ 
     /**
      * Start a job (or however the queue handler determines it should be started)
      *
-     * @param JobDescriptor $jobDescriptor
+     * @param QueuedJobDescriptor $jobDescriptor
      * @param date $startAfter
      */
     public function startJob($jobDescriptor, $startAfter = null)
@@ -379,6 +379,7 @@ 
 
     /**
      * Checks through ll the scheduled jobs that are expected to exist
+     * @param string $queue
      */
     public function checkDefaultJobs($queue = null)
     {
@@ -435,7 +436,7 @@ 
      *
      * @param QueuedJobDescriptor $stalledJob
      *
-     * @return bool True if the job was successfully restarted
+     * @return boolean|null True if the job was successfully restarted
      */
     protected function restartStalledJob($stalledJob)
     {
@@ -961,6 +962,9 @@ 
         }
     }
 
+    /**
+     * @param double $size
+     */
     protected function humanReadable($size)
     {
         $filesizename = [" Bytes", " KB", " MB", " GB", " TB", " PB", " EB", " ZB", " YB"];
@@ -977,7 +981,7 @@ 
      *          The number of seconds to include jobs that have just finished, allowing a job list to be built that
      *          includes recently finished jobs
      *
-     * @return QueuedJobDescriptor
+     * @return DataList
      */
     public function getJobList($type = null, $includeUpUntil = 0)
     {

tests/QueuedJobsAdminTest.php

Unused Use Statements -1 removed lines

@@ -2,7 +2,6 @@
 
 namespace Symbiote\QueuedJobs\Tests;
 
-use SilverStripe\Core\Config\Config;
 use SilverStripe\Control\HTTPRequest;
 use SilverStripe\Dev\FunctionalTest;
 use SilverStripe\Forms\FieldList;

src/Jobs/RunBuildTaskJob.php

Doc Comments +1 added lines, -1 removed lines

@@ -20,7 +20,7 @@
 class RunBuildTaskJob extends AbstractQueuedJob
 {
     /**
-     * @param DataObject $node
+     * @param string $queryString
      */
     public function __construct($taskClass = null, $queryString = null)
     {