Issues in TestQueuedJob.php - Fixed Issues - Inspection of "Merge pull request #234 from creative-commoners/pu..." - symbiote/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 95a104...d03d4c )

by Guy

created 2019-04-04 21:47 UTC

tests/QueuedJobsTest/TestQueuedJob.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Symbiote\QueuedJobs\Tests\QueuedJobsTest;

use Symbiote\QueuedJobs\Services\AbstractQueuedJob;
use Symbiote\QueuedJobs\Services\QueuedJob;

class TestQueuedJob extends AbstractQueuedJob implements QueuedJob
{
    private $type = QueuedJob::QUEUED;

    public function __construct($type = null)
    {
        if ($type) {
            $this->type = $type;
        }
        $this->times = array();
    }

    public function getJobType()
    {
        return $this->type;
    }

    public function getTitle()
    {
        return "A Test job";
    }

    public function setup()
    {
        $this->totalSteps = 5;
    }

    public function process()
    {
        $times = $this->times;
        // needed due to quirks with __set
        $times[] = date('Y-m-d H:i:s');
        $this->times = $times;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->addMessage("Updated time to " . date('Y-m-d H:i:s'));
        sleep(1);

        // make sure we're incrementing
        $this->currentStep++;

        // and checking whether we're complete
        if ($this->currentStep == 5) {
            $this->isComplete = true;
        }
    }
}


1		<?php
2
3		namespace Symbiote\QueuedJobs\Tests\QueuedJobsTest;
4
5		use Symbiote\QueuedJobs\Services\AbstractQueuedJob;
6		use Symbiote\QueuedJobs\Services\QueuedJob;
7
8		class TestQueuedJob extends AbstractQueuedJob implements QueuedJob
9		{
10		private $type = QueuedJob::QUEUED;
11
12		public function __construct($type = null)
13		{
14		if ($type) {
15		$this->type = $type;
16		}
17		$this->times = array();
18		}
19
20		public function getJobType()
21		{
22		return $this->type;
23		}
24
25		public function getTitle()
26		{
27		return "A Test job";
28		}
29
30		public function setup()
31		{
32		$this->totalSteps = 5;
33		}
34
35	View Code Duplication	public function process()
36		{
37		$times = $this->times;
38		// needed due to quirks with __set
39		$times[] = date('Y-m-d H:i:s');
40		$this->times = $times;
		0 ignored issues – show Documentation introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `times` does not exist on `object<Symbiote\QueuedJo...JobsTest\TestQueuedJob>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
41
42		$this->addMessage("Updated time to " . date('Y-m-d H:i:s'));
43		sleep(1);
44
45		// make sure we're incrementing
46		$this->currentStep++;
47
48		// and checking whether we're complete
49		if ($this->currentStep == 5) {
50		$this->isComplete = true;
51		}
52		}
53		}
54

GitHub Access Token became invalid

Push — master ( 95a104...d03d4c )

tests/QueuedJobsTest/TestQueuedJob.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

symbiote / silverstripe-queuedjobs

GitHub Access Token became invalid

Push — master ( 95a104...d03d4c )

tests/QueuedJobsTest/TestQueuedJob.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like