QueuedJobDescriptor::getCMSFields() - Code Metrics - Inspection of "Merge branch '4.2'" - symbiote/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6956e2...9a55f0 )

unknown

created 2018-06-24 22:25 UTC

QueuedJobDescriptor::getCMSFields() A

↳ Parent: QueuedJobDescriptor

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	40
rs	9.28
c	1
b	0
f	0
cc	3
nc	4
nop	0

<?php

namespace Symbiote\QueuedJobs\DataObjects;

use SilverStripe\Assets\Filesystem;
use SilverStripe\Core\Config\Config;
use SilverStripe\Core\Convert;
use SilverStripe\Forms\DropdownField;
use SilverStripe\Forms\LiteralField;
use SilverStripe\ORM\DataObject;
use SilverStripe\ORM\FieldType\DBField;
use SilverStripe\Security\Permission;
use Symbiote\QueuedJobs\Services\QueuedJob;
use Symbiote\QueuedJobs\Services\QueuedJobService;

/**
 * A QueuedJobDescriptor is the stored representation of a piece of work that could take a while to execute,
 * because of which it is desireable to not have it executing in parallel to other jobs.
 *
 * A queued job should always attempt to report how many potential dataobjects will be affected by being executed;
 * this will determine which queue it is placed within so that some shorter jobs can execute immediately without needing
 * to wait for a potentially long running job.
 *
 * @property string $JobTitle Name of job
 * @property string $Signature Unique identifier for this job instance
 * @property string $Implementation Classname of underlying job
 * @property string $StartAfter Don't start until this date, if set
 * @property string $JobStarted When this job was started
 * @property string $JobFinished When this job was finished
 * @property int $TotalSteps Number of steps
 * @property int $StepsProcessed Number of completed steps
 * @property int $LastProcessedCount Number at which StepsProcessed was last checked for stalled jobs
 * @property int $ResumeCounts Number of times this job has been resumed
 * @property string $SavedJobData serialised data for the job to use as storage
 * @property string $SavedJobMessages List of messages saved for this job
 * @property string $JobStatus Status of this job
 * @property string $JobType Type of job
 *
 * @method Member RunAs() Member to run this job as
 *
 * @author Marcus Nyeholt <[email protected]>
 * @license BSD http://silverstripe.org/bsd-license/
 */
class QueuedJobDescriptor extends DataObject
{
    /**
     * {@inheritDoc}
     * @var string
     */
    private static $table_name = 'QueuedJobDescriptor';


    /**
     * @var array
     */
    private static $db = [

        'JobTitle' => 'Varchar(255)',
        'Signature' => 'Varchar(64)',
        'Implementation' => 'Varchar(255)',
        'StartAfter' => 'DBDatetime',
        'JobStarted' => 'DBDatetime',
        'JobRestarted' => 'DBDatetime',
        'JobFinished' => 'DBDatetime',
        'TotalSteps' => 'Int',
        'StepsProcessed' => 'Int',
        'LastProcessedCount' => 'Int(-1)', // -1 means never checked, 0 means checked but no work is done
        'ResumeCounts' => 'Int',
        'SavedJobData' => 'Text',
        'SavedJobMessages' => 'Text',
        'JobStatus' => 'Varchar(16)',
        'JobType' => 'Varchar(16)',
    ];

    /**
     * @var array
     */
    private static $has_one = [

        'RunAs' => 'SilverStripe\\Security\\Member',
    ];

    /**
     * @var array
     */
    private static $defaults = [

        'JobStatus' => 'New',
        'ResumeCounts' => 0,
        'LastProcessedCount' => -1 // -1 means never checked, 0 means checked and none were processed
    ];

    /**
     * @var array
     */
    private static $indexes = [

        'JobStatus' => true,
        'StartAfter' => true,
        'Signature' => true,
    ];

    /**
     * @var array
     */
    private static $casting = [

        'Messages' => 'HTMLText',
    ];

    /**
     * @var array
     */
    private static $searchable_fields = [

        'JobTitle',
    ];

    /**
     * @var string
     */
    private static $default_sort = 'Created DESC';


    public function requireDefaultRecords()
    {
        parent::requireDefaultRecords();
        $this->getJobDir();
    }

    /**
     * @return array
     */
    public function summaryFields()
    {
        return [
            'JobTitle' => _t(__CLASS__ . '.TABLE_TITLE', 'Title'),
            'Created' => _t(__CLASS__ . '.TABLE_ADDE', 'Added'),
            'JobStarted' => _t(__CLASS__ . '.TABLE_STARTED', 'Started'),
//          'JobRestarted' => _t(__CLASS__ . '.TABLE_RESUMED', 'Resumed'),

            'StartAfter' => _t(__CLASS__ . '.TABLE_START_AFTER', 'Start After'),
            'JobType' => _t(__CLASS__ . '.JOB_TYPE', 'Job Type'),
            'JobStatus' => _t(__CLASS__ . '.TABLE_STATUS', 'Status'),
            'LastMessage' => _t(__CLASS__ . '.TABLE_MESSAGES', 'Message'),
            'StepsProcessed' => _t(__CLASS__ . '.TABLE_NUM_PROCESSED', 'Done'),
            'TotalSteps' => _t(__CLASS__ . '.TABLE_TOTAL', 'Total'),
        ];
    }

    /**
     * Pause this job, but only if it is waiting, running, or init
     *
     * @param bool $force Pause this job even if it's not waiting, running, or init
     *
     * @return bool Return true if this job was paused
     */
    public function pause($force = false)
    {
        if ($force || in_array(
            $this->JobStatus,
            [QueuedJob::STATUS_WAIT, QueuedJob::STATUS_RUN, QueuedJob::STATUS_INIT]
        )) {
            $this->JobStatus = QueuedJob::STATUS_PAUSED;
            $this->write();
            return true;
        }
        return false;
    }

    /**
     * Resume this job and schedules it for execution
     *
     * @param bool $force Resume this job even if it's not paused or broken
     *
     * @return bool Return true if this job was resumed
     */
    public function resume($force = false)
    {
        if ($force || in_array($this->JobStatus, [QueuedJob::STATUS_PAUSED, QueuedJob::STATUS_BROKEN])) {
            $this->JobStatus = QueuedJob::STATUS_WAIT;
            $this->ResumeCounts++;
            $this->write();
            singleton(QueuedJobService::class)->startJob($this);
            return true;
        }
        return false;
    }

    /**
     * Restarts this job via a forced resume
     */
    public function restart()
    {
        $this->resume(true);
    }

    /**
     * Called to indicate that the job is ready to be run on the queue. This is done either as the result of
     * creating the job and adding it, or when resuming.
     */
    public function activateOnQueue()
    {
        // if it's an immediate job, lets cache it to disk to be picked up later
        if ($this->JobType == QueuedJob::IMMEDIATE
            && !Config::inst()->get(QueuedJobService::class, 'use_shutdown_function')
        ) {
            touch($this->getJobDir() . '/queuedjob-' . $this->ID);
        }
    }

    /**
     * Gets the path to the queuedjob cache directory
     *
     * @return string
     */
    protected function getJobDir()
    {
        // make sure our temp dir is in place. This is what will be inotify watched
        $jobDir = Config::inst()->get(QueuedJobService::class, 'cache_dir');
        if ($jobDir{0} != '/') {
            $jobDir = TEMP_FOLDER . '/' . $jobDir;
        }

        if (!is_dir($jobDir)) {
            Filesystem::makeFolder($jobDir);
        }
        return $jobDir;
    }

    public function execute()
    {
        $service = singleton(QueuedJobService::class);
        $service->runJob($this->ID);
    }

    /**
     * Called when the job has completed and we want to cleanup anything the descriptor has lying around
     * in caches or the like.
     */
    public function cleanupJob()
    {
        // remove the job's temp file if it exists
        $tmpFile = $this->getJobDir() . '/queuedjob-' . $this->ID;
        if (file_exists($tmpFile)) {
            unlink($tmpFile);
        }
    }

    public function onBeforeDelete()
    {
        parent::onBeforeDelete();
        $this->cleanupJob();
    }

    /**
     * Get all job messages as an HTML unordered list.
     *
     * @return string|void
     */
    public function getMessages()
    {
        if (strlen($this->SavedJobMessages)) {
            $messages = @unserialize($this->SavedJobMessages);
            if (!empty($messages)) {
                return DBField::create_field('HTMLText', '<ul><li>' . nl2br(implode('</li><li>', Convert::raw2xml($messages))) . '</li></ul>');
            }
            return '';
        }
    }

    /**
     * Get the last job message as a raw string
     *
     * @return string|void
     */
    public function getLastMessage()
    {
        if (strlen($this->SavedJobMessages)) {
            $msgs = @unserialize($this->SavedJobMessages);
            if (is_array($msgs) && sizeof($msgs)) {
                $msg = array_pop($msgs);
                return $msg;
            }
        }
    }

    /**
     * @return string
     */
    public function getTitle()
    {
        return $this->JobTitle;
    }

    /**
     * @return FieldList
     */
    public function getCMSFields()
    {
        $fields = parent::getCMSFields();
        $fields->replaceField(
            'JobType',
            new DropdownField('JobType', $this->fieldLabel('JobType'), [
                QueuedJob::IMMEDIATE => 'Immediate',
                QueuedJob::QUEUED => 'Queued',
                QueuedJob::LARGE => 'Large',
            ])
        );
        $statuses = [
            QueuedJob::STATUS_NEW,
            QueuedJob::STATUS_INIT,
            QueuedJob::STATUS_RUN,
            QueuedJob::STATUS_WAIT,
            QueuedJob::STATUS_COMPLETE,
            QueuedJob::STATUS_PAUSED,
            QueuedJob::STATUS_CANCELLED,
            QueuedJob::STATUS_BROKEN,
        ];
        $fields->replaceField(
            'JobStatus',
            DropdownField::create('JobStatus', $this->fieldLabel('JobStatus'), array_combine($statuses, $statuses))
        );

        $fields->removeByName('SavedJobData');
        $fields->removeByName('SavedJobMessages');

        if (strlen($this->SavedJobMessages)) {
            $fields->addFieldToTab('Root.Messages', new LiteralField('Messages', $this->getMessages()));

        }

        if (Permission::check('ADMIN')) {
            return $fields;
        }

        // Readonly CMS view is a lot more useful for debugging than no view at all
        return $fields->makeReadonly();
    }
}


1			<?php
2
3			namespace Symbiote\QueuedJobs\DataObjects;
4
5			use SilverStripe\Assets\Filesystem;
6			use SilverStripe\Core\Config\Config;
7			use SilverStripe\Core\Convert;
8			use SilverStripe\Forms\DropdownField;
9			use SilverStripe\Forms\LiteralField;
10			use SilverStripe\ORM\DataObject;
11			use SilverStripe\ORM\FieldType\DBField;
12			use SilverStripe\Security\Permission;
13			use Symbiote\QueuedJobs\Services\QueuedJob;
14			use Symbiote\QueuedJobs\Services\QueuedJobService;
15
16			/**
17			* A QueuedJobDescriptor is the stored representation of a piece of work that could take a while to execute,
18			* because of which it is desireable to not have it executing in parallel to other jobs.
19			*
20			* A queued job should always attempt to report how many potential dataobjects will be affected by being executed;
21			* this will determine which queue it is placed within so that some shorter jobs can execute immediately without needing
22			* to wait for a potentially long running job.
23			*
24			* @property string $JobTitle Name of job
25			* @property string $Signature Unique identifier for this job instance
26			* @property string $Implementation Classname of underlying job
27			* @property string $StartAfter Don't start until this date, if set
28			* @property string $JobStarted When this job was started
29			* @property string $JobFinished When this job was finished
30			* @property int $TotalSteps Number of steps
31			* @property int $StepsProcessed Number of completed steps
32			* @property int $LastProcessedCount Number at which StepsProcessed was last checked for stalled jobs
33			* @property int $ResumeCounts Number of times this job has been resumed
34			* @property string $SavedJobData serialised data for the job to use as storage
35			* @property string $SavedJobMessages List of messages saved for this job
36			* @property string $JobStatus Status of this job
37			* @property string $JobType Type of job
38			*
39			* @method Member RunAs() Member to run this job as
40			*
41			* @author Marcus Nyeholt <[email protected]>
42			* @license BSD http://silverstripe.org/bsd-license/
43			*/
44			class QueuedJobDescriptor extends DataObject
45			{
46			/**
47			* {@inheritDoc}
48			* @var string
49			*/
50			private static $table_name = 'QueuedJobDescriptor';
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$table_name` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
51
52			/**
53			* @var array
54			*/
55			private static $db = [
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$db` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
56			'JobTitle' => 'Varchar(255)',
57			'Signature' => 'Varchar(64)',
58			'Implementation' => 'Varchar(255)',
59			'StartAfter' => 'DBDatetime',
60			'JobStarted' => 'DBDatetime',
61			'JobRestarted' => 'DBDatetime',
62			'JobFinished' => 'DBDatetime',
63			'TotalSteps' => 'Int',
64			'StepsProcessed' => 'Int',
65			'LastProcessedCount' => 'Int(-1)', // -1 means never checked, 0 means checked but no work is done
66			'ResumeCounts' => 'Int',
67			'SavedJobData' => 'Text',
68			'SavedJobMessages' => 'Text',
69			'JobStatus' => 'Varchar(16)',
70			'JobType' => 'Varchar(16)',
71			];
72
73			/**
74			* @var array
75			*/
76			private static $has_one = [
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$has_one` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
77			'RunAs' => 'SilverStripe\\Security\\Member',
78			];
79
80			/**
81			* @var array
82			*/
83			private static $defaults = [
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$defaults` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
84			'JobStatus' => 'New',
85			'ResumeCounts' => 0,
86			'LastProcessedCount' => -1 // -1 means never checked, 0 means checked and none were processed
87			];
88
89			/**
90			* @var array
91			*/
92			private static $indexes = [
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$indexes` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
93			'JobStatus' => true,
94			'StartAfter' => true,
95			'Signature' => true,
96			];
97
98			/**
99			* @var array
100			*/
101			private static $casting = [
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$casting` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
102			'Messages' => 'HTMLText',
103			];
104
105			/**
106			* @var array
107			*/
108			private static $searchable_fields = [
			0 ignored issues – show Comprehensibility introduced 2018-03-20 17:23 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2018-03-20 17:23 UTC by Report Bug Copy Issue Report The property `$searchable_fields` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
109			'JobTitle',
110			];
111
112			/**
113			* @var string
114			*/
115			private static $default_sort = 'Created DESC';
			0 ignored issues – show Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report Consider using a different property name as you override a private property of the parent class. Loading history... Unused Code introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report The property `$default_sort` is not used and could be removed. This check marks private properties in classes that are never used. Those properties can be removed. Loading history...
116
117			public function requireDefaultRecords()
118			{
119			parent::requireDefaultRecords();
120			$this->getJobDir();
121			}
122
123			/**
124			* @return array
125			*/
126			public function summaryFields()
127			{
128			return [
129			'JobTitle' => _t(__CLASS__ . '.TABLE_TITLE', 'Title'),
130			'Created' => _t(__CLASS__ . '.TABLE_ADDE', 'Added'),
131			'JobStarted' => _t(__CLASS__ . '.TABLE_STARTED', 'Started'),
132			// 'JobRestarted' => _t(__CLASS__ . '.TABLE_RESUMED', 'Resumed'),
			0 ignored issues – show Unused Code Comprehensibility introduced 2017-10-04 23:47 UTC by Report Bug Copy Issue Report `53%` of this comment could be valid code. Did you maybe forget this after debugging? Sometimes obsolete code just ends up commented out instead of removed. In this case it is better to remove the code once you have checked you do not need it. The code might also have been commented out for debugging purposes. In this case it is vital that someone uncomments it again or your project may behave in very unexpected ways in production. This check looks for comments that seem to be mostly valid code and reports them. Loading history...
133			'StartAfter' => _t(__CLASS__ . '.TABLE_START_AFTER', 'Start After'),
134			'JobType' => _t(__CLASS__ . '.JOB_TYPE', 'Job Type'),
135			'JobStatus' => _t(__CLASS__ . '.TABLE_STATUS', 'Status'),
136			'LastMessage' => _t(__CLASS__ . '.TABLE_MESSAGES', 'Message'),
137			'StepsProcessed' => _t(__CLASS__ . '.TABLE_NUM_PROCESSED', 'Done'),
138			'TotalSteps' => _t(__CLASS__ . '.TABLE_TOTAL', 'Total'),
139			];
140			}
141
142			/**
143			* Pause this job, but only if it is waiting, running, or init
144			*
145			* @param bool $force Pause this job even if it's not waiting, running, or init
146			*
147			* @return bool Return true if this job was paused
148			*/
149			public function pause($force = false)
150			{
151			if ($force \|\| in_array(
152			$this->JobStatus,
153			[QueuedJob::STATUS_WAIT, QueuedJob::STATUS_RUN, QueuedJob::STATUS_INIT]
154			)) {
155			$this->JobStatus = QueuedJob::STATUS_PAUSED;
156			$this->write();
157			return true;
158			}
159			return false;
160			}
161
162			/**
163			* Resume this job and schedules it for execution
164			*
165			* @param bool $force Resume this job even if it's not paused or broken
166			*
167			* @return bool Return true if this job was resumed
168			*/
169			public function resume($force = false)
170			{
171			if ($force \|\| in_array($this->JobStatus, [QueuedJob::STATUS_PAUSED, QueuedJob::STATUS_BROKEN])) {
172			$this->JobStatus = QueuedJob::STATUS_WAIT;
173			$this->ResumeCounts++;
174			$this->write();
175			singleton(QueuedJobService::class)->startJob($this);
176			return true;
177			}
178			return false;
179			}
180
181			/**
182			* Restarts this job via a forced resume
183			*/
184			public function restart()
185			{
186			$this->resume(true);
187			}
188
189			/**
190			* Called to indicate that the job is ready to be run on the queue. This is done either as the result of
191			* creating the job and adding it, or when resuming.
192			*/
193			public function activateOnQueue()
194			{
195			// if it's an immediate job, lets cache it to disk to be picked up later
196			if ($this->JobType == QueuedJob::IMMEDIATE
197			&& !Config::inst()->get(QueuedJobService::class, 'use_shutdown_function')
198			) {
199			touch($this->getJobDir() . '/queuedjob-' . $this->ID);
200			}
201			}
202
203			/**
204			* Gets the path to the queuedjob cache directory
205			*
206			* @return string
207			*/
208			protected function getJobDir()
209			{
210			// make sure our temp dir is in place. This is what will be inotify watched
211			$jobDir = Config::inst()->get(QueuedJobService::class, 'cache_dir');
212			if ($jobDir{0} != '/') {
213			$jobDir = TEMP_FOLDER . '/' . $jobDir;
214			}
215
216			if (!is_dir($jobDir)) {
217			Filesystem::makeFolder($jobDir);
218			}
219			return $jobDir;
220			}
221
222			public function execute()
223			{
224			$service = singleton(QueuedJobService::class);
225			$service->runJob($this->ID);
226			}
227
228			/**
229			* Called when the job has completed and we want to cleanup anything the descriptor has lying around
230			* in caches or the like.
231			*/
232			public function cleanupJob()
233			{
234			// remove the job's temp file if it exists
235			$tmpFile = $this->getJobDir() . '/queuedjob-' . $this->ID;
236			if (file_exists($tmpFile)) {
237			unlink($tmpFile);
238			}
239			}
240
241			public function onBeforeDelete()
242			{
243			parent::onBeforeDelete();
244			$this->cleanupJob();
245			}
246
247			/**
248			* Get all job messages as an HTML unordered list.
249			*
250			* @return string\|void
251			*/
252			public function getMessages()
253			{
254			if (strlen($this->SavedJobMessages)) {
255			$messages = @unserialize($this->SavedJobMessages);
256			if (!empty($messages)) {
257			return DBField::create_field('HTMLText', '<ul><li>' . nl2br(implode('</li><li>', Convert::raw2xml($messages))) . '</li></ul>');
258			}
259			return '';
260			}
261			}
262
263			/**
264			* Get the last job message as a raw string
265			*
266			* @return string\|void
267			*/
268			public function getLastMessage()
269			{
270			if (strlen($this->SavedJobMessages)) {
271			$msgs = @unserialize($this->SavedJobMessages);
272			if (is_array($msgs) && sizeof($msgs)) {
273			$msg = array_pop($msgs);
274			return $msg;
275			}
276			}
277			}
278
279			/**
280			* @return string
281			*/
282			public function getTitle()
283			{
284			return $this->JobTitle;
285			}
286
287			/**
288			* @return FieldList
289			*/
290			public function getCMSFields()
291			{
292			$fields = parent::getCMSFields();
293			$fields->replaceField(
294			'JobType',
295			new DropdownField('JobType', $this->fieldLabel('JobType'), [
296			QueuedJob::IMMEDIATE => 'Immediate',
297			QueuedJob::QUEUED => 'Queued',
298			QueuedJob::LARGE => 'Large',
299			])
300			);
301			$statuses = [
302			QueuedJob::STATUS_NEW,
303			QueuedJob::STATUS_INIT,
304			QueuedJob::STATUS_RUN,
305			QueuedJob::STATUS_WAIT,
306			QueuedJob::STATUS_COMPLETE,
307			QueuedJob::STATUS_PAUSED,
308			QueuedJob::STATUS_CANCELLED,
309			QueuedJob::STATUS_BROKEN,
310			];
311			$fields->replaceField(
312			'JobStatus',
313			DropdownField::create('JobStatus', $this->fieldLabel('JobStatus'), array_combine($statuses, $statuses))
314			);
315
316			$fields->removeByName('SavedJobData');
317			$fields->removeByName('SavedJobMessages');
318
319			if (strlen($this->SavedJobMessages)) {
320			$fields->addFieldToTab('Root.Messages', new LiteralField('Messages', $this->getMessages()));
			0 ignored issues – show Bug introduced 2018-03-20 17:23 UTC by Report Bug Copy Issue Report It seems like `$this->getMessages()` targeting `Symbiote\QueuedJobs\Data...scriptor::getMessages()` can also be of type `null` or `object<SilverStripe\ORM\FieldType\DBField>`; however, `SilverStripe\Forms\LiteralField::__construct()` does only seem to accept `string\|object<SilverStripe\Forms\FormField>`, maybe add an additional type check? This check looks at variables that are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
321			}
322
323			if (Permission::check('ADMIN')) {
324			return $fields;
325			}
326
327			// Readonly CMS view is a lot more useful for debugging than no view at all
328			return $fields->makeReadonly();
329			}
330			}
331

symbiote / silverstripe-queuedjobs

GitHub Access Token became invalid

Push — master ( 6956e2...9a55f0 )

QueuedJobDescriptor::getCMSFields() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like