QueuedJobHandler::__construct() - Code Metrics - Inspection of "Add real-time logs when using `LoggerInterface`" - symbiote/silverstripe-queuedjobs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#240)

unknown

created 2019-04-15 01:57 UTC

QueuedJobHandler::__construct() A

↳ Parent: QueuedJobHandler

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

namespace Symbiote\QueuedJobs\Services;

use Monolog\Handler\AbstractProcessingHandler;
use SilverStripe\Core\Injector\Injectable;
use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;

/**
 * Writes log output to a job descriptor
 */
class QueuedJobHandler extends AbstractProcessingHandler
{
    use Injectable;

    /** @var QueuedJob */
    protected $job;

    /** @var QueuedJobDescriptor */
    protected $jobDescriptor;

    public function __construct(QueuedJob $job, QueuedJobDescriptor $jobDescriptor)
    {
        parent::__construct($job, $jobDescriptor);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        $this->job = $job;
        $this->jobDescriptor = $jobDescriptor;
    }

    /**
     * @return QueuedJob
     */
    public function getJob()
    {
        return $this->job;
    }

    /**
     * @return QueuedJobDescriptor
     */
    public function getJobDescriptor()
    {
        return $this->jobDescriptor;
    }

    /**
     * Writes the record down to the log of the implementing handler
     *
     * @param  array $record
     * @return void
     * @throws \SilverStripe\ORM\ValidationException
     */
    protected function write(array $record)
    {
        $this->job->addMessage($record['message']);
        $this->jobDescriptor->SavedJobMessages = serialize($this->job->getJobData()->messages);
        $this->jobDescriptor->write();
    }
}


1			<?php
2
3			namespace Symbiote\QueuedJobs\Services;
4
5			use Monolog\Handler\AbstractProcessingHandler;
6			use SilverStripe\Core\Injector\Injectable;
7			use Symbiote\QueuedJobs\DataObjects\QueuedJobDescriptor;
8
9			/**
10			* Writes log output to a job descriptor
11			*/
12			class QueuedJobHandler extends AbstractProcessingHandler
13			{
14			use Injectable;
15
16			/** @var QueuedJob */
17			protected $job;
18
19			/** @var QueuedJobDescriptor */
20			protected $jobDescriptor;
21
22			public function __construct(QueuedJob $job, QueuedJobDescriptor $jobDescriptor)
23			{
24			parent::__construct($job, $jobDescriptor);
			0 ignored issues – show Documentation introduced 2019-04-15 01:59 UTC by Report Bug Copy Issue Report `$job` is of type `object<Symbiote\QueuedJobs\Services\QueuedJob>`, but the function expects a `integer`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history... Documentation introduced 2019-04-15 01:59 UTC by Report Bug Copy Issue Report `$jobDescriptor` is of type `object<Symbiote\QueuedJo...ts\QueuedJobDescriptor>`, but the function expects a `boolean`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25
26			$this->job = $job;
27			$this->jobDescriptor = $jobDescriptor;
28			}
29
30			/**
31			* @return QueuedJob
32			*/
33			public function getJob()
34			{
35			return $this->job;
36			}
37
38			/**
39			* @return QueuedJobDescriptor
40			*/
41			public function getJobDescriptor()
42			{
43			return $this->jobDescriptor;
44			}
45
46			/**
47			* Writes the record down to the log of the implementing handler
48			*
49			* @param array $record
50			* @return void
51			* @throws \SilverStripe\ORM\ValidationException
52			*/
53			protected function write(array $record)
54			{
55			$this->job->addMessage($record['message']);
56			$this->jobDescriptor->SavedJobMessages = serialize($this->job->getJobData()->messages);
57			$this->jobDescriptor->write();
58			}
59			}
60

symbiote / silverstripe-queuedjobs

GitHub Access Token became invalid

Pull Request — master (#240)

QueuedJobHandler::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like