Symbiote\QueuedJobs\Tests\QueuedJobsAdminTest

Complexity

Total Complexity

5

Size/Duplication

Total Lines	95
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	9

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	setUp()	0	17	1
A	testConstructorParamsShouldBeATextarea()	0	5	1
A	testCreateJobWithConstructorParams()	0	15	2
A	testCreateJobWithStartAfterOption()	0	22	1

<?php

namespace Symbiote\QueuedJobs\Tests;

use SilverStripe\Core\Config\Config;
use SilverStripe\Control\HTTPRequest;
use SilverStripe\Dev\FunctionalTest;
use SilverStripe\Forms\FieldList;
use SilverStripe\Forms\TextareaField;
use SilverStripe\ORM\FieldType\DBDatetime;
use Symbiote\QueuedJobs\Controllers\QueuedJobsAdmin;
use Symbiote\QueuedJobs\Jobs\PublishItemsJob;
use Symbiote\QueuedJobs\Services\QueuedJobService;

/**
 * Tests for the QueuedJobsAdmin ModelAdmin clas
 *
 * @coversDefaultClass \Symbiote\QueuedJobs\Controllers\QueuedJobsAdmin
 * @package queuedjobs
 * @author  Robbie Averill <robbie@silverstripe.com>
 */
class QueuedJobsAdminTest extends FunctionalTest
{
    /**
     * {@inheritDoc}
     * @var string
     */
    // protected static $fixture_file = 'QueuedJobsAdminTest.yml';

    protected $usesDatabase = true;

    /**
     * @var QueuedJobsAdmin
     */
    protected $admin;

    /**
     * Get a test class, and mock the job queue for it
     *
     * {@inheritDoc}
     */
    protected function setUp()
    {
        parent::setUp();

        // The shutdown handler doesn't play nicely with SapphireTest's database handling
        QueuedJobService::config()->set('use_shutdown_function', false);

        $this->admin = new QueuedJobsAdmin();
        $this->admin->setRequest(new HTTPRequest('GET', '/'));
        $this->admin->getRequest()->setSession($this->session());

        $mockQueue = $this->createMock(QueuedJobService::class);
        $this->admin->jobQueue = $mockQueue;

It seems like $mockQueue of type object<PHPUnit_Framework_MockObject_MockObject> is incompatible with the declared type object<Symbiote\QueuedJobs\Services\QueuedJobService> of property $jobQueue.

        $this->logInWithPermission('ADMIN');
        $this->admin->doInit();
    }

    /**
     * Ensure that the JobParams field is added as a Textarea
     */
    public function testConstructorParamsShouldBeATextarea()
    {
        $fields = $this->admin->getEditForm('foo', new FieldList())->Fields();
        $this->assertInstanceOf(TextareaField::class, $fields->fieldByName('JobParams'));
    }

    /**
     * Ensure that when a multi-line value is entered for JobParams, it is split by new line and each value
     * passed to the constructor of the JobType that is created by the reflection in createjob()
     *
     * @covers ::createjob
     */
    public function testCreateJobWithConstructorParams()
    {
        $this->admin->jobQueue

The method expects does not exist on object<Symbiote\QueuedJobs\Services\QueuedJobService>? Since you implemented __call, maybe consider adding a @method annotation.

            ->expects($this->once())
            ->method('queueJob')
            ->with($this->callback(function ($job) {
                return $job instanceof PublishItemsJob && $job->rootID === 'foo123';

The property rootID does not exist on object<Symbiote\QueuedJobs\Jobs\PublishItemsJob>. Since you implemented __get, maybe consider adding a @property annotation.

            }));

        $form = $this->admin->getEditForm('foo', new FieldList());
        $form->Fields()->fieldByName('JobParams')->setValue(implode(PHP_EOL, ['foo123', 'bar']));
        $form->Fields()->fieldByName('JobType')->setValue(PublishItemsJob::class);

        $this->admin->createjob($form->getData(), $form);
    }

    /**
     * @covers ::createjob
     */
    public function testCreateJobWithStartAfterOption()
    {
        $startTimeAfter = DBDatetime::now();

        $this->admin->jobQueue

The method expects does not exist on object<Symbiote\QueuedJobs\Services\QueuedJobService>? Since you implemented __call, maybe consider adding a @method annotation.

            ->expects($this->once())
            ->method('queueJob')
            ->with(
                $this->callback(static function ($job) {
                    return $job instanceof PublishItemsJob;
                }),
                $this->callback(static function ($givenStartAfter) use ($startTimeAfter) {
                    return $givenStartAfter === $startTimeAfter->forTemplate();
                })
            );

        $form = $this->admin->getEditForm('foo', new FieldList());
        $form->Fields()->fieldByName('JobType')->setValue(PublishItemsJob::class);
        $form->Fields()->fieldByName('JobStart')->setValue($startTimeAfter);

        $this->admin->createjob($form->getData(), $form);
    }
}