Issues in WorkflowEngineTest.php (master) - Issues in master - symbiote/silverstripe-advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

Issues (446)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/WorkflowEngineTest.php (33 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Symbiote\AdvancedWorkflow\Tests;

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\Versioned\Versioned;
use Symbiote\AdvancedWorkflow\Actions\AssignUsersToWorkflowAction;
use Symbiote\AdvancedWorkflow\Actions\NotifyUsersWorkflowAction;
use Symbiote\AdvancedWorkflow\Actions\PublishItemWorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowDefinition;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowInstance;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowTransition;
use Symbiote\AdvancedWorkflow\Templates\WorkflowTemplate;

/**
 * Tests for the workflow engine.
 *
 * @author     [email protected]
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage tests
 */
class WorkflowEngineTest extends SapphireTest
{
    protected static $fixture_file = 'workflowinstancetargets.yml';

    public function testCreateWorkflowInstance()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Create Workflow Instance";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        $instance = new WorkflowInstance();
        $instance->write();

        $instance->beginWorkflow($definition);

        $actions = $definition->Actions();

        $this->assertEquals(2, $actions->Count());

        $transitions = $actions->find('Title', 'Step One')->Transitions();
        $this->assertEquals(1, $transitions->Count());
    }

    public function testExecuteImmediateWorkflow()
    {
        $def = $this->createDefinition();

        $actions = $def->Actions();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $firstAction = $def->getInitialAction();
        $this->assertEquals('Step One', $firstAction->Title);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def);
        $this->assertTrue($instance->CurrentActionID > 0);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance->execute();

        // the instance should be complete, and have two finished workflow action
        // instances.
        $actions = $instance->Actions();

        $this->assertEquals(2, $actions->Count());

        foreach ($actions as $action) {
            $this->assertTrue((bool) $action->Finished);
        }
    }

    /**
     * Ensure WorkflowInstance returns expected values for a Published target object.
     */
    public function testInstanceGetTargetPublished()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture(SiteTree::class, 'published-object');
        $target->publishRecursive();

        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-published');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertTrue($target->isPublished());
        $this->assertEquals($target->ID, $instance->getTarget()->ID);
        $this->assertEquals($target->Title, $instance->getTarget()->Title);
    }

    /**
     * Ensure WorkflowInstance returns expected values for a Draft target object.
     */
    public function testInstanceGetTargetDraft()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture(SiteTree::class, 'draft-object');

        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-draft');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertFalse($target->isPublished());
        $this->assertEquals($target->ID, $instance->getTarget()->ID);
        $this->assertEquals($target->Title, $instance->getTarget()->Title);
    }

    public function testPublishAction()
    {
        $this->logInWithPermission();

        $action = new PublishItemWorkflowAction;
        $instance = new WorkflowInstance();

        $page = new SiteTree();
        $page->Title = 'stuff';
        $page->write();

        $instance->TargetClass = SiteTree::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $instance->TargetID = $page->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertFalse($page->isPublished());

        $action->execute($instance);

        $page = DataObject::get_by_id(SiteTree::class, $page->ID);
        $this->assertTrue($page->isPublished());
    }

    public function testCreateDefinitionWithEmptyTitle()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();
        $this->assertContains(
            'My Workflow',
            $definition->Title,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'Workflow created without title is assigned a default title.'
        );
    }

    protected function createDefinition()

    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Dummy Workflow Definition";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        return $definition;
    }

    public function testCreateFromTemplate()
    {
        $structure = array(
            'First step'    => array(
                'type'      => AssignUsersToWorkflowAction::class,
                'transitions'   => array(
                    'second'    => 'Second step'
                )
            ),
            'Second step'   => array(
                'type'      => NotifyUsersWorkflowAction::class,
                'transitions'   => array(
                    'Approve'   => 'Third step'
                )
            ),
        );

        $template = new WorkflowTemplate('Test');

        $template->setStructure($structure);

        $actions = $template->createRelations();

        $this->assertEquals(2, count($actions));
        $this->assertTrue(isset($actions['First step']));
        $this->assertTrue(isset($actions['Second step']));

        $this->assertTrue($actions['First step']->exists());

        $transitions = $actions['First step']->Transitions();

        $this->assertTrue($transitions->count() == 1);
    }

    /**
     * Tests whether if user(s) are able to delete a workflow, dependent on permissions.
     */
    public function testCanDeleteWorkflow()
    {
        // Create a definition
        $def = $this->createDefinition();

        // Test a user with lame permissions
        $memberID = $this->logInWithPermission('SITETREE_VIEW_ALL');
        $member = DataObject::get_by_id('SilverStripe\\Security\\Member', $memberID);
        $this->assertFalse($def->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        // Test a user with good permissions
        $memberID = $this->logInWithPermission('CREATE_WORKFLOW');
        $member = DataObject::get_by_id('SilverStripe\\Security\\Member', $memberID);
        $this->assertTrue($def->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * For a context around this test, see: https://github.com/symbiote/advancedworkflow/issues/141
     *
     *  1). Create a workflow definition
     *  2). Step the content into that workflow
     *  3). Delete the workflow
     *  4). Check that the content:
     *      i). Has no remaining related actions
     *      ii). Can be re-assigned a new Workflow
     *  5). Check that the object under workflow, maintains its status (Draft, Published etc)
     */
    public function testDeleteWorkflowTargetStillWorks()
    {
        // 1). Create a workflow definition
        $def = $this->createDefinition();
        $page = SiteTree::create();
        $page->Title = 'dummy test';
        $page->WorkflowDefinitionID = $def->ID;     // Normally done via CMS
        Versioned::set_stage(Versioned::DRAFT);
        $page->write();

        // Check $page is in draft, pre-deletion
        $status = ($page->isOnDraftOnly() && !$page->isPublished());
        $this->assertTrue($status);

        // 2). Step the content into that workflow
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def, $page);
        $instance->execute();

        // Check the content is assigned
        $testPage = DataObject::get_by_id(SiteTree::class, $page->ID);
        $this->assertEquals($instance->TargetID, $testPage->ID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // 3). Delete the workflow
        $def->delete();

        // Check $testPage is _still_ in draft, post-deletion
        $status = ($testPage->isOnDraftOnly() && !$testPage->isPublished());
        $this->assertTrue($status);

        /*
         * 4). i). Check that the content: Has no remaining related actions
         * Note: WorkflowApplicable::WorkflowDefinitionID does _not_ get updated until assigned a new workflow
         * so we can use it to check that all related actions are gone
         */
        $defID = $testPage->WorkflowDefinitionID;
        $this->assertEquals(0, DataObject::get(WorkflowAction::class)->filter('WorkflowDefID', $defID)->count());

        /*
         * 4). ii). Check that the content: Can be re-assigned a new Workflow Definition
         */
        $newDef = $this->createDefinition();
        $testPage->WorkflowDefinitionID = $newDef->ID;  // Normally done via CMS
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef, $testPage);
        $instance->execute();

        // Check the content is assigned to the new Workflow Definition correctly
        $this->assertEquals($newDef->ID, $testPage->WorkflowDefinitionID);
        $this->assertEquals(
            $newDef->Actions()->count(),

            DataObject::get(WorkflowAction::class)->filter('WorkflowDefID', $newDef->ID)->count()
        );

        // 5). Check that the object under workflow, maintains its status
        $newDef2 = $this->createDefinition();

        // Login so SiteTree::canPublish() returns true
        $testPage->WorkflowDefinitionID = $newDef2->ID;     // Normally done via CMS
        $this->logInWithPermission();
        $testPage->publishRecursive();

        // Check $testPage is published, pre-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->isPublished());

        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef2, $testPage);
        $instance->execute();

        // Now delete the related WorkflowDefinition and ensure status is the same
        // (i.e. so it's not 'modified' for example)
        $newDef2->delete();

        // Check $testPage is _still_ published, post-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->isPublished());
    }

    /**
     * Test the diff showing only fields that have changes made to it in a data object.
     */
    public function testInstanceDiff()
    {
        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-published');
        $target = $instance->getTarget();
        $target->publishRecursive();

        $target->Title = 'New title for target';
        $target->write();

        $diff = $instance->getTargetDiff()->column('Name');
        $this->assertContains('Title', $diff);
        $this->assertNotContains('Content', $diff);
    }
}


GitHub Access Token became invalid

Issues (446)

Security Analysis not enabled

tests/WorkflowEngineTest.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

symbiote / silverstripe-advancedworkflow

GitHub Access Token became invalid

Issues (446)

Security Analysis not enabled

tests/WorkflowEngineTest.php (33 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like