symbiote / silverstripe-advancedworkflow

code/formfields/WorkflowFieldActionController.php

Doc Comments +4 added lines

@@ -27,6 +27,10 @@
     protected $parent;
     protected $name;
 
+    /**
+     * @param WorkflowField $parent
+     * @param string $name
+     */
     public function __construct($parent, $name)
     {
         $this->parent = $parent;

code/forms/FrontendWorkflowForm.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Symbiote\AdvancedWorkflow\Forms;
 
 use SilverStripe\Forms\Form;
-use FormResponse;
 use SilverStripe\Control\Director;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Core\Convert;

code/forms/gridfield/GridFieldExportAction.php

Doc Comments +2 added lines, -2 removed lines

@@ -66,7 +66,7 @@ 
      * Which columns are handled by this component
      *
      * @param type $gridField
-     * @return type
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {
@@ -77,7 +77,7 @@ 
      * Which GridField actions are this component handling
      *
      * @param GridField $gridField
-     * @return array
+     * @return string[]
      */
     public function getActions($gridField)
     {

code/forms/gridfield/GridFieldWorkflowRestrictedEditButton.php

Doc Comments +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
      * Which columns are handled by this component
      *
      * @param type $gridField
-     * @return type
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {
@@ -85,7 +85,7 @@ 
      * @param DataObject $record
      * @param string $columnName
      *
-     * @return string - the HTML for the column
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText - the HTML for the column
      */
     public function getColumnContent($gridField, $record, $columnName)
     {

code/templates/WorkflowTemplate.php

Doc Comments +5 added lines, -2 removed lines

@@ -83,6 +83,9 @@ 
      */
     protected $structure;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name, $description = '', $version = '0.0', $remindDays = 0, $sort = 0)
     {
         $this->name = $name;
@@ -131,7 +134,7 @@ 
      * Creates the relevant data objects for this structure, returning an array
      * of actions in the order they've been created
      *
-     * @param WorkflowDefinition $definitino
+     * @param WorkflowDefinition $definition
      *              An optional workflow definition to bind the actions into
      * @return array
      */
@@ -183,7 +186,7 @@ 
      * Create a workflow action based on a template
      *
      * @param string $name
-     * @param array $template
+     * @param array $actionTemplate
      * @param WorkflowDefinition $definition
      * @return WorkflowAction
      * @throws Exception

tests/WorkflowEmbargoExpiryTest.php

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use SilverStripe\ORM\DataObject;
 use SilverStripe\ORM\FieldType\DBDatetime;
 use SilverStripe\Translatable\Model\Translatable;
-use SilverStripe\Security\Member;
 use SilverStripe\Subsites\Extensions\SiteTreeSubsites;
 use SilverStripe\Versioned\Versioned;
 use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;

code/formfields/WorkflowFieldTransitionController.php

Doc Comments +4 added lines

@@ -27,6 +27,10 @@
     protected $parent;
     protected $name;
 
+    /**
+     * @param WorkflowField $parent
+     * @param string $name
+     */
     public function __construct($parent, $name)
     {
         $this->parent = $parent;

code/extensions/AdvancedWorkflowExtension.php

Unused Use Statements -2 removed lines

@@ -4,11 +4,9 @@
 
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\Extension;
-use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Forms\Form;
 use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;
 use SilverStripe\ORM\DataObject;
-use SilverStripe\Security\Permission;
 use SilverStripe\View\Requirements;
 use Symbiote\AdvancedWorkflow\Extensions\WorkflowApplicable;
 use Symbiote\AdvancedWorkflow\Services\WorkflowService;

code/dataobjects/WorkflowInstance.php

Doc Comments +5 added lines, -5 removed lines

@@ -603,7 +603,7 @@ 
     /**
      * Does this action restrict the publishing of a document?
      *
-     * @return boolean
+     * @return boolean|null
      */
     public function canPublishTarget()
     {
@@ -616,7 +616,7 @@ 
      * Get the current set of transitions that are valid for the current workflow state,
      * and are available to the current user.
      *
-     * @return array
+     * @return ArrayList
      */
     public function validTransitions()
     {
@@ -750,9 +750,9 @@ 
      * to view WorkflowInstances within GridFields
      * @see {@link $this->userHasAccess()}
      *
-     * @param number $recordID
+     * @param integer $recordID
      * @param number $userID
-     * @param number $wasPublished
+     * @param integer $wasPublished
      * @return boolean
      */
     public function getVersionedConnection($recordID, $userID, $wasPublished = 0)
@@ -789,7 +789,7 @@ 
     /**
      * Tells us if $member has had permissions over some part of the current WorkflowInstance.
      *
-     * @param $member
+     * @param Member $member
      * @return WorkflowAction|boolean
      */
     public function getMostRecentActionForUser($member = null)