symbiote / silverstripe-advancedworkflow

src/Extensions/WorkflowEmbargoExpiryExtension.php

Doc Comments +1 added lines, -1 removed lines

@@ -535,7 +535,7 @@
      * disabled.
      *
      * @param Member $member
-     * @return bool|null
+     * @return false|null
      */
     public function canEdit($member)
     {

Unused Use Statements -4 removed lines

@@ -4,16 +4,12 @@
 
 use SilverStripe\Control\Controller;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Forms\FieldList;
 use SilverStripe\Forms\DatetimeField;
 use SilverStripe\Forms\HeaderField;
 use SilverStripe\Forms\LiteralField;
-use SilverStripe\ORM\ArrayList;
 use SilverStripe\ORM\DataExtension;
-use SilverStripe\ORM\DataQuery;
 use SilverStripe\ORM\FieldType\DBDatetime;
-use SilverStripe\ORM\Queries\SQLSelect;
 use SilverStripe\Security\Member;
 use SilverStripe\Security\Permission;
 use SilverStripe\View\Requirements;

src/FormFields/WorkflowField.php

Doc Comments +4 added lines

@@ -33,6 +33,10 @@
 
     protected $definition;
 
+    /**
+     * @param string $name
+     * @param string $title
+     */
     public function __construct($name, $title, WorkflowDefinition $definition)
     {
         $this->definition = $definition;

Unused Use Statements -1 removed lines

@@ -5,7 +5,6 @@
 use ReflectionClass;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Core\ClassInfo;
-use SilverStripe\Core\Manifest\ModuleLoader;
 use SilverStripe\Forms\FormField;
 use SilverStripe\ORM\ArrayList;
 use SilverStripe\Security\SecurityToken;

src/FormFields/WorkflowFieldActionController.php

Doc Comments +4 added lines

@@ -27,6 +27,10 @@
     protected $parent;
     protected $name;
 
+    /**
+     * @param WorkflowField $parent
+     * @param string $name
+     */
     public function __construct($parent, $name)
     {
         $this->parent = $parent;

src/FormFields/WorkflowFieldTransitionController.php

Doc Comments +4 added lines

@@ -27,6 +27,10 @@
     protected $parent;
     protected $name;
 
+    /**
+     * @param WorkflowField $parent
+     * @param string $name
+     */
     public function __construct($parent, $name)
     {
         $this->parent = $parent;

src/Forms/FrontendWorkflowForm.php

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Symbiote\AdvancedWorkflow\Forms;
 
 use SilverStripe\Forms\Form;
-use FormResponse;
 use SilverStripe\Control\Director;
 use SilverStripe\Control\HTTPResponse;
 use SilverStripe\Core\Convert;

src/Forms/gridfield/GridFieldWorkflowRestrictedEditButton.php

Doc Comments +2 added lines, -2 removed lines

@@ -73,7 +73,7 @@ 
      * Which columns are handled by this component
      *
      * @param type $gridField
-     * @return type
+     * @return string[]
      */
     public function getColumnsHandled($gridField)
     {
@@ -85,7 +85,7 @@ 
      * @param DataObject $record
      * @param string $columnName
      *
-     * @return string - the HTML for the column
+     * @return \SilverStripe\ORM\FieldType\DBHTMLText - the HTML for the column
      */
     public function getColumnContent($gridField, $record, $columnName)
     {

src/Services/WorkflowService.php

Doc Comments +4 added lines, -3 removed lines

@@ -82,6 +82,7 @@ 
      * Will recursively query parent elements until it finds one, if available
      *
      * @param DataObject $dataObject
+     * @return null|DataObject
      */
     public function getDefinitionFor(DataObject $dataObject)
     {
@@ -140,6 +141,7 @@ 
      * main workflow definition.
      *
      * @param DataObject object
+     * @param DataObject $object
      * @return array
      */
 
@@ -170,7 +172,7 @@ 
      *
      * @param mixed $item
      * @param bool $includeComplete
-     * @return WorkflowInstance|null
+     * @return DataObject|null
      */
     public function getWorkflowFor($item, $includeComplete = false)
     {
@@ -194,6 +196,7 @@ 
     /**
      * Get all the workflow action instances for an item
      *
+     * @param DataObject $item
      * @return DataList|null
      */
     public function getWorkflowHistoryFor($item, $limit = null)
@@ -333,7 +336,6 @@ 
     /**
      * Get items that the passed-in user has awaiting for them to action
      *
-     * @param Member $member
      * @return DataList
      */
     public function userPendingItems(Member $user)
@@ -361,7 +363,6 @@ 
     /**
      * Get items that the passed-in user has submitted for workflow review
      *
-     * @param Member $member
      * @return DataList
      */
     public function userSubmittedItems(Member $user)

src/Templates/WorkflowTemplate.php

Doc Comments +5 added lines, -2 removed lines

@@ -83,6 +83,9 @@ 
      */
     protected $structure;
 
+    /**
+     * @param string $name
+     */
     public function __construct($name, $description = '', $version = '0.0', $remindDays = 0, $sort = 0)
     {
         $this->name = $name;
@@ -131,7 +134,7 @@ 
      * Creates the relevant data objects for this structure, returning an array
      * of actions in the order they've been created
      *
-     * @param WorkflowDefinition $definitino
+     * @param WorkflowDefinition $definition
      *              An optional workflow definition to bind the actions into
      * @return array
      */
@@ -183,7 +186,7 @@ 
      * Create a workflow action based on a template
      *
      * @param string $name
-     * @param array $template
+     * @param array $actionTemplate
      * @param WorkflowDefinition $definition
      * @return WorkflowAction
      * @throws Exception

src/Admin/WorkflowDefinitionImporter.php

Doc Comments +1 added lines

@@ -24,6 +24,7 @@
      *
      * @param string $name. If set, a single-value array comprising a WorkflowTemplate object who's first
      *                      constructor param matches $name is returned.
+     * @param string $name
      * @return WorkflowTemplate|WorkflowTemplate[]
      */
     public function getImportedWorkflows($name = null)