WorkflowEngineTest::testCreateDefinitionWithEmptyTitle() - Code Metrics - symbiote/silverstripe-advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

testCreateDefinitionWithEmptyTitle() A
last analyzed 2019-12-18 23:33 UTC

↳ Parent: WorkflowEngineTest

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	11
rs	9.9
c	0
b	0
f	0
cc	1
nc	1
nop	0

<?php

namespace Symbiote\AdvancedWorkflow\Tests;

use SilverStripe\CMS\Model\SiteTree;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ORM\DataObject;
use SilverStripe\Versioned\Versioned;
use Symbiote\AdvancedWorkflow\Actions\AssignUsersToWorkflowAction;
use Symbiote\AdvancedWorkflow\Actions\NotifyUsersWorkflowAction;
use Symbiote\AdvancedWorkflow\Actions\PublishItemWorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowDefinition;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowInstance;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowTransition;
use Symbiote\AdvancedWorkflow\Templates\WorkflowTemplate;

/**
 * Tests for the workflow engine.
 *
 * @author     [email protected]
 * @license    BSD License (http://silverstripe.org/bsd-license/)
 * @package    advancedworkflow
 * @subpackage tests
 */
class WorkflowEngineTest extends SapphireTest
{
    protected static $fixture_file = 'workflowinstancetargets.yml';

    public function testCreateWorkflowInstance()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Create Workflow Instance";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        $instance = new WorkflowInstance();
        $instance->write();

        $instance->beginWorkflow($definition);

        $actions = $definition->Actions();

        $this->assertEquals(2, $actions->Count());

        $transitions = $actions->find('Title', 'Step One')->Transitions();
        $this->assertEquals(1, $transitions->Count());
    }

    public function testExecuteImmediateWorkflow()
    {
        $def = $this->createDefinition();

        $actions = $def->Actions();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $firstAction = $def->getInitialAction();
        $this->assertEquals('Step One', $firstAction->Title);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def);
        $this->assertTrue($instance->CurrentActionID > 0);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $instance->execute();

        // the instance should be complete, and have two finished workflow action
        // instances.
        $actions = $instance->Actions();

        $this->assertEquals(2, $actions->Count());

        foreach ($actions as $action) {
            $this->assertTrue((bool) $action->Finished);
        }
    }

    /**
     * Ensure WorkflowInstance returns expected values for a Published target object.
     */
    public function testInstanceGetTargetPublished()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture(SiteTree::class, 'published-object');
        $target->publishRecursive();

        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-published');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertTrue($target->isPublished());
        $this->assertEquals($target->ID, $instance->getTarget()->ID);
        $this->assertEquals($target->Title, $instance->getTarget()->Title);
    }

    /**
     * Ensure WorkflowInstance returns expected values for a Draft target object.
     */
    public function testInstanceGetTargetDraft()

    {
        $def = $this->createDefinition();
        $target = $this->objFromFixture(SiteTree::class, 'draft-object');

        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-draft');
        $instance->beginWorkflow($def);
        $instance->execute();

        $this->assertFalse($target->isPublished());
        $this->assertEquals($target->ID, $instance->getTarget()->ID);
        $this->assertEquals($target->Title, $instance->getTarget()->Title);
    }

    public function testPublishAction()
    {
        $this->logInWithPermission();

        $action = new PublishItemWorkflowAction;
        $instance = new WorkflowInstance();

        $page = new SiteTree();
        $page->Title = 'stuff';
        $page->write();

        $instance->TargetClass = SiteTree::class;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $instance->TargetID = $page->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        $this->assertFalse($page->isPublished());

        $action->execute($instance);

        $page = DataObject::get_by_id(SiteTree::class, $page->ID);
        $this->assertTrue($page->isPublished());
    }

    public function testCreateDefinitionWithEmptyTitle()
    {
        $definition = new WorkflowDefinition();
        $definition->Title = "";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();
        $this->assertContains(
            'My Workflow',
            $definition->Title,
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
            'Workflow created without title is assigned a default title.'
        );
    }

    protected function createDefinition()

    {
        $definition = new WorkflowDefinition();
        $definition->Title = "Dummy Workflow Definition";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $definition->write();

        $stepOne = new WorkflowAction();
        $stepOne->Title = "Step One";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepOne->write();

        $stepTwo = new WorkflowAction();
        $stepTwo->Title = "Step Two";
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->WorkflowDefID = $definition->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $stepTwo->write();

        $transitionOne = new WorkflowTransition();
        $transitionOne->Title = 'Step One T1';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->ActionID = $stepOne->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->NextActionID = $stepTwo->ID;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $transitionOne->write();

        return $definition;
    }

    public function testCreateFromTemplate()
    {
        $structure = array(
            'First step'    => array(
                'type'      => AssignUsersToWorkflowAction::class,
                'transitions'   => array(
                    'second'    => 'Second step'
                )
            ),
            'Second step'   => array(
                'type'      => NotifyUsersWorkflowAction::class,
                'transitions'   => array(
                    'Approve'   => 'Third step'
                )
            ),
        );

        $template = new WorkflowTemplate('Test');

        $template->setStructure($structure);

        $actions = $template->createRelations();

        $this->assertEquals(2, count($actions));
        $this->assertTrue(isset($actions['First step']));
        $this->assertTrue(isset($actions['Second step']));

        $this->assertTrue($actions['First step']->exists());

        $transitions = $actions['First step']->Transitions();

        $this->assertTrue($transitions->count() == 1);
    }

    /**
     * Tests whether if user(s) are able to delete a workflow, dependent on permissions.
     */
    public function testCanDeleteWorkflow()
    {
        // Create a definition
        $def = $this->createDefinition();

        // Test a user with lame permissions
        $memberID = $this->logInWithPermission('SITETREE_VIEW_ALL');
        $member = DataObject::get_by_id('SilverStripe\\Security\\Member', $memberID);
        $this->assertFalse($def->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

        // Test a user with good permissions
        $memberID = $this->logInWithPermission('CREATE_WORKFLOW');
        $member = DataObject::get_by_id('SilverStripe\\Security\\Member', $memberID);
        $this->assertTrue($def->canCreate($member));
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}
    }

    /**
     * For a context around this test, see: https://github.com/symbiote/advancedworkflow/issues/141
     *
     *  1). Create a workflow definition
     *  2). Step the content into that workflow
     *  3). Delete the workflow
     *  4). Check that the content:
     *      i). Has no remaining related actions
     *      ii). Can be re-assigned a new Workflow
     *  5). Check that the object under workflow, maintains its status (Draft, Published etc)
     */
    public function testDeleteWorkflowTargetStillWorks()
    {
        // 1). Create a workflow definition
        $def = $this->createDefinition();
        $page = SiteTree::create();
        $page->Title = 'dummy test';
        $page->WorkflowDefinitionID = $def->ID;     // Normally done via CMS
        Versioned::set_stage(Versioned::DRAFT);
        $page->write();

        // Check $page is in draft, pre-deletion
        $status = ($page->isOnDraftOnly() && !$page->isPublished());
        $this->assertTrue($status);

        // 2). Step the content into that workflow
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($def, $page);
        $instance->execute();

        // Check the content is assigned
        $testPage = DataObject::get_by_id(SiteTree::class, $page->ID);
        $this->assertEquals($instance->TargetID, $testPage->ID);
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

        // 3). Delete the workflow
        $def->delete();

        // Check $testPage is _still_ in draft, post-deletion
        $status = ($testPage->isOnDraftOnly() && !$testPage->isPublished());
        $this->assertTrue($status);

        /*
         * 4). i). Check that the content: Has no remaining related actions
         * Note: WorkflowApplicable::WorkflowDefinitionID does _not_ get updated until assigned a new workflow
         * so we can use it to check that all related actions are gone
         */
        $defID = $testPage->WorkflowDefinitionID;
        $this->assertEquals(0, DataObject::get(WorkflowAction::class)->filter('WorkflowDefID', $defID)->count());

        /*
         * 4). ii). Check that the content: Can be re-assigned a new Workflow Definition
         */
        $newDef = $this->createDefinition();
        $testPage->WorkflowDefinitionID = $newDef->ID;  // Normally done via CMS
        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef, $testPage);
        $instance->execute();

        // Check the content is assigned to the new Workflow Definition correctly
        $this->assertEquals($newDef->ID, $testPage->WorkflowDefinitionID);
        $this->assertEquals(
            $newDef->Actions()->count(),

            DataObject::get(WorkflowAction::class)->filter('WorkflowDefID', $newDef->ID)->count()
        );

        // 5). Check that the object under workflow, maintains its status
        $newDef2 = $this->createDefinition();

        // Login so SiteTree::canPublish() returns true
        $testPage->WorkflowDefinitionID = $newDef2->ID;     // Normally done via CMS
        $this->logInWithPermission();
        $testPage->publishRecursive();

        // Check $testPage is published, pre-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->isPublished());

        $instance = new WorkflowInstance();
        $instance->beginWorkflow($newDef2, $testPage);
        $instance->execute();

        // Now delete the related WorkflowDefinition and ensure status is the same
        // (i.e. so it's not 'modified' for example)
        $newDef2->delete();

        // Check $testPage is _still_ published, post-deletion (getStatusFlags() returns empty array)
        $this->assertTrue($testPage->isPublished());
    }

    /**
     * Test the diff showing only fields that have changes made to it in a data object.
     */
    public function testInstanceDiff()
    {
        $instance = $this->objFromFixture(WorkflowInstance::class, 'target-is-published');
        $target = $instance->getTarget();
        $target->publishRecursive();

        $target->Title = 'New title for target';
        $target->write();

        $diff = $instance->getTargetDiff()->column('Name');
        $this->assertContains('Title', $diff);
        $this->assertNotContains('Content', $diff);
    }
}


1			<?php
2
3			namespace Symbiote\AdvancedWorkflow\Tests;
4
5			use SilverStripe\CMS\Model\SiteTree;
6			use SilverStripe\Dev\SapphireTest;
7			use SilverStripe\ORM\DataObject;
8			use SilverStripe\Versioned\Versioned;
9			use Symbiote\AdvancedWorkflow\Actions\AssignUsersToWorkflowAction;
10			use Symbiote\AdvancedWorkflow\Actions\NotifyUsersWorkflowAction;
11			use Symbiote\AdvancedWorkflow\Actions\PublishItemWorkflowAction;
12			use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
13			use Symbiote\AdvancedWorkflow\DataObjects\WorkflowDefinition;
14			use Symbiote\AdvancedWorkflow\DataObjects\WorkflowInstance;
15			use Symbiote\AdvancedWorkflow\DataObjects\WorkflowTransition;
16			use Symbiote\AdvancedWorkflow\Templates\WorkflowTemplate;
17
18			/**
19			* Tests for the workflow engine.
20			*
21			* @author [email protected]
22			* @license BSD License (http://silverstripe.org/bsd-license/)
23			* @package advancedworkflow
24			* @subpackage tests
25			*/
26			class WorkflowEngineTest extends SapphireTest
27			{
28			protected static $fixture_file = 'workflowinstancetargets.yml';
29
30			public function testCreateWorkflowInstance()
31			{
32			$definition = new WorkflowDefinition();
33			$definition->Title = "Create Workflow Instance";
			0 ignored issues – show Documentation introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<Symbiote\Advanced...cts\WorkflowDefinition>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
34			$definition->write();
35
36			$stepOne = new WorkflowAction();
37			$stepOne->Title = "Step One";
			0 ignored issues – show Documentation introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<Symbiote\Advanced...Objects\WorkflowAction>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
38			$stepOne->WorkflowDefID = $definition->ID;

symbiote / silverstripe-advancedworkflow

GitHub Access Token became invalid

testCreateDefinitionWithEmptyTitle() A last analyzed 2019-12-18 23:33 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

testCreateDefinitionWithEmptyTitle() A
last analyzed 2019-12-18 23:33 UTC