Symbiote\AdvancedWorkflow\FormFields\WorkflowFieldTransitionController

Complexity

Total Complexity

11

Size/Duplication

Total Lines	68
Duplicated Lines	22.06 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	handleAdd()	0	18	4
A	handleItem()	15	15	4
A	RootField()	0	4	1
A	Link()	0	4	1

<?php

namespace Symbiote\AdvancedWorkflow\FormFields;

use SilverStripe\Control\Controller;
use SilverStripe\Control\RequestHandler;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowAction;
use Symbiote\AdvancedWorkflow\DataObjects\WorkflowTransition;

/**
 * Handles requests for creating or editing transitions.
 *
 * @package silverstripe-advancedworkflow
 */
class WorkflowFieldTransitionController extends RequestHandler
{
    private static $url_handlers = array(

Consider using a different property name as you override a private property of the parent class.

        'new/$ParentID!' => 'handleAdd',
        'item/$ID!'      => 'handleItem'
    );

    private static $allowed_actions = array(

Consider using a different property name as you override a private property of the parent class.

        'handleAdd',
        'handleItem'
    );

    protected $parent;
    protected $name;

    public function __construct($parent, $name)
    {
        $this->parent = $parent;
        $this->name   = $name;

        parent::__construct();
    }

    public function handleAdd()
    {
        $parent = $this->request->param('ParentID');
        $action = WorkflowAction::get()->byID($this->request->param('ParentID'));

        if (!$action || $action->WorkflowDefID != $this->RootField()->Definition()->ID) {
            $this->httpError(404);
        }

        if (!singleton(WorkflowTransition::class)->canCreate()) {
            $this->httpError(403);
        }

        $transition = new WorkflowTransition();
        $transition->ActionID = $action->ID;

The property ActionID does not exist on object<Symbiote\AdvancedWorkflow\DataObjects\WorkflowTransition>. Since you implemented __set, maybe consider adding a @property annotation.

        return new WorkflowFieldItemController($this, "new/$parent", $transition);
    }

    public function handleItem()

This method seems to be duplicated in your project.

    {
        $id    = $this->request->param('ID');
        $trans = WorkflowTransition::get()->byID($id);

        if (!$trans || $trans->Action()->WorkflowDefID != $this->RootField()->Definition()->ID) {

The method Action() does not exist on SilverStripe\ORM\DataObject. Did you maybe mean getCMSActions()?

            $this->httpError(404);
        }

        if (!$trans->canEdit()) {
            $this->httpError(403);
        }

        return new WorkflowFieldItemController($this, "item/$id", $trans);
    }

    public function RootField()
    {
        return $this->parent;
    }

    public function Link($action = null)
    {
        return Controller::join_links($this->parent->Link(), $this->name, $action);
    }
}