WorkflowDefinitionItemRequestClass - Code Metrics - symbiote/silverstripe-advancedworkflow - Measure and Improve Code Quality continuously with Scrutinizer

WorkflowDefinitionItemRequestClass A
last analyzed 2019-12-18 23:33 UTC

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	11
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes

Metric	Value
wmc	2
lcom	0
cbo	2
dl	0
loc	11
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	updatetemplateversion()	0	8	2

<?php

namespace Symbiote\AdvancedWorkflow\Admin;

use SilverStripe\Forms\Form;
use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;

class WorkflowDefinitionItemRequestClass extends GridFieldDetailForm_ItemRequest
{
    public function updatetemplateversion($data, Form $form, $request)

    {
        $record = $form->getRecord();
        if ($record) {
            $record->updateFromTemplate();
        }
        return $form->loadDataFrom($form->getRecord())->forAjaxTemplate();
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}
    }
}


1			<?php
2
3			namespace Symbiote\AdvancedWorkflow\Admin;
4
5			use SilverStripe\Forms\Form;
6			use SilverStripe\Forms\GridField\GridFieldDetailForm_ItemRequest;
7
8			class WorkflowDefinitionItemRequestClass extends GridFieldDetailForm_ItemRequest
9			{
10			public function updatetemplateversion($data, Form $form, $request)
			0 ignored issues – show Unused Code introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report The parameter `$data` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report The parameter `$request` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
11			{
12			$record = $form->getRecord();
13			if ($record) {
14			$record->updateFromTemplate();
15			}
16			return $form->loadDataFrom($form->getRecord())->forAjaxTemplate();
			0 ignored issues – show Bug introduced 2017-10-01 23:10 UTC by Report Bug Copy Issue Report It seems like `$form->getRecord()` can be `null`; however, `loadDataFrom()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
17			}
18			}
19

symbiote / silverstripe-advancedworkflow

GitHub Access Token became invalid

WorkflowDefinitionItemRequestClass A last analyzed 2019-12-18 23:33 UTC

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like

WorkflowDefinitionItemRequestClass A
last analyzed 2019-12-18 23:33 UTC