swooletw / laravel-swoole

src/Task/SwooleTaskJob.php

<?php

namespace SwooleTW\Http\Task;

use Illuminate\Queue\Jobs\Job;
use Illuminate\Contracts\Container\Container;
use Illuminate\Contracts\Queue\Job as JobContract;

/**
 * Class SwooleTaskJob
 */
class SwooleTaskJob extends Job implements JobContract
{
    /**
     * The Swoole Server instance.
     *
     * @var \Swoole\Http\Server
     */
    protected $swoole;

    /**
     * The Swoole async job raw payload.
     *
     * @var array
     */
    protected $job;

    /**
     * The Task id
     *
     * @var int
     */
    protected $taskId;

    /**
     * The src worker Id
     *
     * @var int
     */
    protected $srcWrokerId;

    /**
     * @var int
     */
    protected $srcWorkderId;

    /**
     * Create a new job instance.
     *
     * @param \Illuminate\Contracts\Container\Container $container
     * @param  \Swoole\Http\Server $swoole
     * @param  string $job
     * @param  int $taskId
     * @param $srcWrokerId
     */
    public function __construct(Container $container, $swoole, $job, $taskId, $srcWrokerId)
    {
        $this->container = $container;

$container is of type Illuminate\Contracts\Container\Container, but the property $container was declared to be of type Illuminate\Container\Container. Are you sure that you always receive this specific sub-class here, or does it make sense to add an instanceof check?

        $this->swoole = $swoole;
        $this->job = $job;

It seems like $job of type string is incompatible with the declared type array of property $job.

        $this->taskId = $taskId;
        $this->srcWorkderId = $srcWrokerId;
    }

    /**
     * Fire the job.
     *
     * @return void
     */
    public function fire()
    {
        if (method_exists($this, 'resolveAndFire')) {
            $this->resolveAndFire(json_decode($this->getRawBody(), true));
        } else {
            parent::fire();
        }
    }

    /**
     * Get the number of times the job has been attempted.
     *
     * @return int
     */
    public function attempts()
    {
        return ($this->job['attempts'] ?? null) + 1;
    }

    /**
     * Get the raw body string for the job.
     *
     * @return string
     */
    public function getRawBody()
    {
        return $this->job;

The expression return $this->job returns the type array which is incompatible with the documented return type string.

    }

    /**
     * Get the job identifier.
     *
     * @return string
     */
    public function getJobId()
    {
        return $this->taskId;
    }

    /**
     * Get the service container instance.
     *
     * @return \Illuminate\Contracts\Container\Container
     */
    public function getContainer()
    {
        return $this->container;
    }
}