swisnl / json-api-client

src/Actions/Update.php

<?php

declare(strict_types=1);

namespace Swis\JsonApi\Client\Actions;

use Swis\JsonApi\Client\Interfaces\ItemInterface;

/**
 * @template TItem of \Swis\JsonApi\Client\Interfaces\ItemInterface
 */
trait Update
{
    /**
     * @return \Swis\JsonApi\Client\Interfaces\ItemDocumentInterface<TItem>
     */
    public function update(ItemInterface $item, array $parameters = [], array $headers = [])
    {
        return $this->getClient()->patch(

It seems like getClient() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->getEndpoint().'/'.urlencode($item->getId()).'?'.http_build_query($parameters),

It seems like getEndpoint() must be provided by classes using this trait. How about adding it as abstract method to this trait?

It seems like $item->getId() can also be of type null; however, parameter $string of urlencode() does only seem to accept string, maybe add an additional type check?

            $this->documentFactory->make($item),
            $headers,
        );
    }
}