Swis\JsonApi\Client\Actions\Update

Complexity

Total Complexity

1

Size/Duplication

Total Lines	13
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	update()	0	5	1

<?php

declare(strict_types=1);

namespace Swis\JsonApi\Client\Actions;

use Swis\JsonApi\Client\Interfaces\ItemInterface;

trait Update
{
    /**
     * @param \Swis\JsonApi\Client\Interfaces\ItemInterface $item
     * @param array                                         $parameters
     *
     * @return \Swis\JsonApi\Client\Interfaces\DocumentInterface
     */
    public function update(ItemInterface $item, array $parameters = [])
    {
        return $this->getClient()->patch(

It seems like getClient() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->getEndpoint().'/'.urlencode($item->getId()).'?'.http_build_query($parameters),

It seems like $item->getId() can also be of type null; however, parameter $string of urlencode() does only seem to accept string, maybe add an additional type check?

It seems like getEndpoint() must be provided by classes using this trait. How about adding it as abstract method to this trait?

            $this->documentFactory->make($item)
        );
    }
}