App\Http\Controllers\ContactController

Complexity

Total Complexity

4

Size/Duplication

Total Lines	62
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	show()	0	4	1
A	__construct()	0	4	1
A	index()	0	5	1
A	store()	0	7	1

<?php

namespace App\Http\Controllers;

use App\Http\Requests\ContactStoreRequest;

The type App\Http\Requests\ContactStoreRequest was not found. Maybe you did not declare it correctly or list all dependencies?

use App\Http\Resources\ContactResource;
use App\Interfaces\ContactServiceInterface;
use App\Interfaces\UserServiceInterface;
use Illuminate\Support\Facades\Auth;

class ContactController extends Controller
{
    /**
     * @var ContactServiceInterface
     */
    private ContactServiceInterface $service;

    /**
     * @var UserServiceInterface
     */
    private UserServiceInterface $userService;

    /**
     * ContactController constructor.
     *
     * @param ContactServiceInterface $service
     * @param UserServiceInterface $userService
     */
    public function __construct(ContactServiceInterface $service, UserServiceInterface $userService)
    {
        $this->service = $service;
        $this->userService = $userService;
    }

    /**
     * Returns user by id.
     *
     * @param string $id
     * @return ContactResource
     */
    public function show(string $id)
    {
        return new ContactResource(
            $this->service->contact($id)
        );
    }

    /**
     * Returns contacts by user.
     *
     * @return \Illuminate\Http\Resources\Json\AnonymousResourceCollection
     */
    public function index()
    {
        $user = Auth::user();

        return ContactResource::collection($this->service->contacts($user));

It seems like $user can also be of type null; however, parameter $user of App\Interfaces\ContactServiceInterface::contacts() does only seem to accept App\Models\User, maybe add an additional type check?

    }

    /**
     * Store a contact.
     *
     * @param string $user_id
     * @return ContactResource
     */
    public function store(string $user_id): ContactResource
    {
        $user = Auth::user();
        $contact = $this->userService->find($user_id);

        return new ContactResource(
            $this->service->addContact($user, $contact)

It seems like $user can also be of type null; however, parameter $user of App\Interfaces\ContactServiceInterface::addContact() does only seem to accept App\Models\User, maybe add an additional type check?

        );
    }
}