ContactService::setContacts() - Code Metrics - Inspection of "add contact when two of users in the same thread" - swinn-io/server - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 3bb9e9...5085bf )

by Burak

created 2020-12-09 05:59 UTC

ContactService::setContacts() A

↳ Parent: ContactService

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	1

Importance

Changes

Metric	Value
cc	1
eloc	7
c	0
b	0
f	0
nc	1
nop	1
dl	0
loc	12
ccs	10
cts	10
cp	1
crap	1
rs	10

<?php

namespace App\Services;

use App\Interfaces\ContactServiceInterface;
use App\Models\Contact;
use App\Models\User;
use Illuminate\Contracts\Pagination\LengthAwarePaginator;
use Illuminate\Support\Collection;

class ContactService implements ContactServiceInterface
{
    /**
     * All contacts.
     *
     * @param User $user
     * @return LengthAwarePaginator
     */
    public function contacts(User $user): LengthAwarePaginator
    {
        return Contact::forUser($user->id)->with('source')->paginate();
    }

    /**
     * Retrieve a contact.
     *
     * @param string $contact_id
     * @return Contact
     */
    public function contact(string $contact_id): Contact
    {
        return Contact::find($contact_id);

    }

    /**
     * Creates contact.
     * @param User $user
     * @param User $contact
     * @return Contact
     */
    public function addContact(User $user, User $contact): Contact
    {
        return Contact::updateOrCreate([
            'user_id' => $user->id,
            'source_type' => get_class($contact),
            'source_id' => $contact->id,
        ], [
            'name' => $contact->name,

        ]);
    }

    /**
     * Creates contact by user collection and returns contact.
     *
     * @param Collection $users
     * @return Collection
     */
    public function setContacts(Collection $users): Collection
    {
        return $users->map(function ($user) use ($users){
            return $users
                    ->filter(function ($item) use ($user) {
                        return !$item->is($user);
                    })
                    ->map(function ($contact) use ($user) {
                        return $this->addContact($user, $contact);
                    });
                })
                ->flatten();
    }

    /**
     * Remove a contact.
     *
     * @param string $contact_id
     * @return Contact
     */
    public function removeContact(string $contact_id): Contact
    {
        $contact = Contact::find($contact_id);
        $contact->delete();

        return $contact;

    }
}


1		<?php
2
3		namespace App\Services;
4
5		use App\Interfaces\ContactServiceInterface;
6		use App\Models\Contact;
7		use App\Models\User;
8		use Illuminate\Contracts\Pagination\LengthAwarePaginator;
9		use Illuminate\Support\Collection;
10
11		class ContactService implements ContactServiceInterface
12		{
13		/**
14		* All contacts.
15		*
16		* @param User $user
17		* @return LengthAwarePaginator
18		*/
19	3	public function contacts(User $user): LengthAwarePaginator
20		{
21	3	return Contact::forUser($user->id)->with('source')->paginate();
22		}
23
24		/**
25		* Retrieve a contact.
26		*
27		* @param string $contact_id
28		* @return Contact
29		*/
30	1	public function contact(string $contact_id): Contact
31		{
32	1	return Contact::find($contact_id);
		0 ignored issues – show Bug Best Practice introduced 2020-12-04 05:52 UTC by Report Bug Copy Issue Report The expression `return App\Models\Contact::find($contact_id)` could return the type `null` which is incompatible with the type-hinted return `App\Models\Contact`. Consider adding an additional type-check to rule them out. Loading history...
33		}
34
35		/**
36		* Creates contact.
37		* @param User $user
38		* @param User $contact
39		* @return Contact
40		*/
41	11	public function addContact(User $user, User $contact): Contact
42		{
43	11	return Contact::updateOrCreate([
44	11	'user_id' => $user->id,
45	11	'source_type' => get_class($contact),
46	11	'source_id' => $contact->id,
47		], [
48	11	'name' => $contact->name,
		0 ignored issues – show Bug Best Practice introduced 2020-12-04 05:52 UTC by Report Bug Copy Issue Report The property `name` does not exist on `App\Models\User`. Since you implemented `__get`, consider adding a @property annotation. Loading history...
49		]);
50		}
51
52		/**
53		* Creates contact by user collection and returns contact.
54		*
55		* @param Collection $users
56		* @return Collection
57		*/
58	10	public function setContacts(Collection $users): Collection
59		{
60	10	return $users->map(function ($user) use ($users){
61		return $users
62	10	->filter(function ($item) use ($user) {
63	10	return !$item->is($user);
64	10	})
65	10	->map(function ($contact) use ($user) {
66	7	return $this->addContact($user, $contact);
67	10	});
68	10	})
69	10	->flatten();
70		}
71
72		/**
73		* Remove a contact.
74		*
75		* @param string $contact_id
76		* @return Contact
77		*/
78	1	public function removeContact(string $contact_id): Contact
79		{
80	1	$contact = Contact::find($contact_id);
81	1	$contact->delete();
82
83	1	return $contact;
		0 ignored issues – show Bug Best Practice introduced 2020-12-04 05:52 UTC by Report Bug Copy Issue Report The expression `return $contact` could return the type `null` which is incompatible with the type-hinted return `App\Models\Contact`. Consider adding an additional type-check to rule them out. Loading history...
84		}
85		}
86

swinn-io / server

Push — master ( 3bb9e9...5085bf )

ContactService::setContacts() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like