App\Notifications\MessageCreated

Complexity

Total Complexity

5

Size/Duplication

Total Lines	72
Duplicated Lines	0 %

Test Coverage

Coverage

26.32%

Importance

Changes	5
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	via()	0	3	1
A	toBroadcast()	0	4	1
A	toMail()	0	11	1
A	toArray()	0	3	1
A	__construct()	0	3	1

<?php

namespace App\Notifications;

use App\Http\Resources\MessageResource;
use App\Models\Message;
use Illuminate\Bus\Queueable;
use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Notifications\Messages\BroadcastMessage;
use Illuminate\Notifications\Messages\MailMessage;
use Illuminate\Notifications\Notification;

class MessageCreated extends Notification implements ShouldQueue
{
    use Queueable;

    /**
     * @var Message
     */
    public Message $message;

    /**
     * Create a new notification instance.
     *
     * @param Message $message
     * @return void
     */
    public function __construct(Message $message)
    {
        $this->message = $message;
    }

    /**
     * Get the notification's delivery channels.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function via($notifiable)
    {
        return $notifiable->notify_via;
    }

    /**
     * Get the array representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return array
     */
    public function toArray($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return (new MessageResource($this->message))->resolve();
    }

    /**
     * Get the broadcastable representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return BroadcastMessage
     */
    public function toBroadcast($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        return new BroadcastMessage(
            (new MessageResource($this->message))->resolve()
        );
    }

    /**
     * Get the mail representation of the notification.
     *
     * @param  mixed  $notifiable
     * @return \Illuminate\Notifications\Messages\MailMessage
     */
    public function toMail($notifiable)

The parameter $notifiable is not used and could be removed.

    {
        $body = json_encode($this->message->body);

The property body does not exist on App\Models\Message. Since you implemented __get, consider adding a @property annotation.

        $user = $this->message->user();

        return (new MailMessage)
            ->subject('New Message from: '.$user->name)

The property name does not seem to exist on Illuminate\Database\Eloquent\Relations\BelongsTo.

            ->greeting('Hello!')
            ->line("{$user->name} pinged you!")
            ->line("{$body}")
            ->line('Thank you for using our application!');
    }
}