App\Services\LoginService

Complexity

Total Complexity

6

Size/Duplication

Total Lines	107
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes	5
Bugs	0	Features	0

6 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	client()	0	12	1
A	callback()	0	5	1
A	createToken()	0	5	1
A	user()	0	18	1
A	redirect()	0	6	1

<?php

namespace App\Services;

use App\Interfaces\LoginServiceInterface;
use App\Models\User;
use Illuminate\Support\Arr;
use Laravel\Passport\Client;
use Laravel\Passport\ClientRepository;
use Laravel\Socialite\Contracts\User as UserContract;
use Laravel\Socialite\Facades\Socialite;
use Symfony\Component\HttpFoundation\RedirectResponse;

class LoginService implements LoginServiceInterface
{
    /**
     * Laravel Passport Client Repository.
     *
     * @var ClientRepository
     */
    private ClientRepository $clientRepository;

    /**
     * LoginService constructor.
     *
     * @param  ClientRepository  $repository
     */
    public function __construct(ClientRepository $repository)
    {
        $this->clientRepository = $repository;
    }

    /**
     * Redirect to OAuth authorization service URL.
     *
     * @param  string  $provider
     * @return RedirectResponse
     */
    public function redirect(string $provider): RedirectResponse
    {
        return Socialite::driver($provider)
            // Define custom scopes if needed under "services.{provider}"
            ->scopes(config("services.{$provider}.scopes") ?? '*')

The method scopes() does not exist on Laravel\Socialite\Contracts\Provider. It seems like you code against a sub-type of Laravel\Socialite\Contracts\Provider such as Laravel\Socialite\Two\AbstractProvider.

            ->redirect();
    }

    /**
     * Handle callback.
     *
     * @param  string  $provider
     * @param  array  $clientInfo
     * @return User
     */
    public function callback(string $provider, array $clientInfo): User
    {
        $profile = Socialite::driver($provider)->user();

        return $this->user($provider, $profile);
    }

    /**
     * Handle callback.
     *
     * @param  User  $user
     * @return string
     */
    public function createToken(User $user): string
    {
        $tokenName = config('app.name').' Token - '.now();

        return $user->createToken($tokenName)->accessToken;
    }

    /**
     * Create a new user or update existing one.
     *
     * @param  string  $provider
     * @param  UserContract  $userContract
     * @return User
     */
    public function user(string $provider, UserContract $userContract): User
    {
        return User::updateOrCreate([
            'provider_name'  => $provider,                       // GitHub, LinkedIn, Google, Apple
            'provider_id'    => $userContract->getId(),          // unsignedBigInteger, uuid
        ], [
            'name'           => $userContract->getName() ?? $userContract->getNickname(),
            /**
             * E-mails, tokens and profile will be synced.
             * E-mail is for e-mail notifications.
             * Tokens for retrieve data from authorization
             * server such as GitHub, Twitter or Google.
             */
            'email'          => $userContract->getEmail(),       // OAuth provider e-mail address
            'notify_via'     => ['broadcast'],                   // Default notification preference
            'access_token'   => $userContract->token,            // TOKEN

Accessing token on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            'refresh_token'  => $userContract->refreshToken,     // TOKEN - some providers have it

Accessing refreshToken on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

            'profile'        => $userContract->user,             // JSON profile data

Accessing user on the interface Laravel\Socialite\Contracts\User suggest that you code against a concrete implementation. How about adding an instanceof check?

        ]);
    }

    /**
     * Get or create client for user.
     *
     * @param  User  $user
     * @param  array  $clientInfo
     * @return Client
     */
    public function client(User $user, array $clientInfo): Client
    {
        $find = $this->clientRepository->forUser($user->id);

        return $find->first() ?? $this->clientRepository->create(
                $user->id,
                "{$user->provider_name}-{$user->provider_id}",

The property provider_name does not exist on App\Models\User. Since you implemented __get, consider adding a @property annotation.

The property provider_id does not exist on App\Models\User. Since you implemented __get, consider adding a @property annotation.

                Arr::get($clientInfo, 'redirect_uri'),
                $user->provider_name,

It seems like $user->provider_name can also be of type Illuminate\Database\Eloquent\Builder&Illuminate\Database\Eloquent\Relations\Relation and Illuminate\Database\Eloquent\Relations\Relation; however, parameter $provider of Laravel\Passport\ClientRepository::create() does only seem to accept null|string, maybe add an additional type check?

                false,
                false,
                false
            );
    }
}