Logger::getEntries() - Code Metrics - Inspection of "added tests for Logger classes; refinements" - sweetrdf/in-memory-store-sqlite - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — extract-store ( ec1a3e...70fc7f )

by Konrad

created 2021-03-17 09:57 UTC

Logger::getEntries() A

↳ Parent: Logger

Complexity

Conditions	4
Paths	3

Size

Total Lines	9
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	4

Importance

Changes

Metric	Value
cc	4
eloc	5
nc	3
nop	1
dl	0
loc	9
ccs	6
cts	6
cp	1
crap	4
rs	10
c	0
b	0
f	0

<?php

namespace sweetrdf\InMemoryStoreSqlite\Log;

use Exception;

final class Logger
{
    /**
     * @var array<string,array<integer,mixed>>
     */
    private array $entries = [];

    public function __construct()
    {
        $this->entries = [
            'error' => [],
            'warning' => [],
        ];
    }

    public function error(string $message, array $context = []): void
    {
        $this->log('error', $message, $context);
    }

    public function warning(string $message, array $context = []): void
    {
        $this->log('warning', $message, $context);
    }

    private function log($level, $message, array $context = []): void
    {
        if (!isset($this->entries[$level])) {
            $this->entries[$level] = [];
        }

        $this->entries[$level][] = ['message' => $message, 'context' => $context];
    }

    public function getEntries(?string $level = null): array
    {
        if (null !== $level && isset($this->entries[$level])) {
            return $this->entries[$level];
        } elseif (null == $level) {

            return $this->entries;
        }

        throw new Exception('Level '.$level.' not set.');
    }

    public function hasEntries(?string $level = null): bool
    {
        return 0 < \count($this->getEntries($level));
    }
}


1		<?php
2
3		namespace sweetrdf\InMemoryStoreSqlite\Log;
4
5		use Exception;
6
7		final class Logger
8		{
9		/**
10		* @var array<string,array<integer,mixed>>
11		*/
12		private array $entries = [];
13
14	111	public function __construct()
15		{
16	111	$this->entries = [
17		'error' => [],
18		'warning' => [],
19		];
20	111	}
21
22	24	public function error(string $message, array $context = []): void
23		{
24	24	$this->log('error', $message, $context);
25	24	}
26
27	5	public function warning(string $message, array $context = []): void
28		{
29	5	$this->log('warning', $message, $context);
30	5	}
31
32	24	private function log($level, $message, array $context = []): void
33		{
34	24	if (!isset($this->entries[$level])) {
35		$this->entries[$level] = [];
36		}
37
38	24	$this->entries[$level][] = ['message' => $message, 'context' => $context];
39	24	}
40
41	108	public function getEntries(?string $level = null): array
42		{
43	108	if (null !== $level && isset($this->entries[$level])) {
44	104	return $this->entries[$level];
45	9	} elseif (null == $level) {
		0 ignored issues – show Bug introduced 2021-03-12 09:14 UTC by Report Bug Copy Issue Report It seems like you are loosely comparing `$level` of type `null\|string` against `null`; this is ambiguous if the string can be empty. Consider using a strict comparison `===` instead. Loading history...
46	5	return $this->entries;
47		}
48
49	4	throw new Exception('Level '.$level.' not set.');
50		}
51
52	32	public function hasEntries(?string $level = null): bool
53		{
54	32	return 0 < \count($this->getEntries($level));
55		}
56		}
57

sweetrdf / in-memory-store-sqlite

Push — extract-store ( ec1a3e...70fc7f )

Logger::getEntries() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like