ContextProhibited::passes() - Code Metrics - swatty007/laravel-context-prohibited-rule - Measure and Improve Code Quality continuously with Scrutinizer

ContextProhibited::passes() A
last analyzed 2021-02-19 22:41 UTC

↳ Parent: ContextProhibited

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	12
ccs	6
cts	6
cp	1
rs	9.8666
c	0
b	0
f	0
cc	3
nc	3
nop	2
crap	3

<?php

namespace Swatty007\LaravelContextProhibitedRule\Rules;

use Illuminate\Contracts\Validation\Rule;
use Illuminate\Support\Str;

class ContextProhibited implements Rule
{
    /**
     * Dataset of context specific words we want to validate against
     *
     * @var array|false|string[]
     */
    protected $prohibitedWords = [];

    /**
     * Create a new rule instance.
     *
     */
    public function __construct()
    {
        // Assemble our set of context specific words
        if (!config('context-prohibited-rule.allow_application_name')) {
            array_push($this->prohibitedWords, Str::lower(Str::camel(config('app.name'))));
        }

        if (!config('context-prohibited-rule.allow_hostname')) {
            $hostname = Str::beforeLast(parse_url(config('app.url'), PHP_URL_HOST), '.');

            array_push($this->prohibitedWords, Str::lower($hostname));
        }

        $this->prohibitedWords = array_merge($this->prohibitedWords, config('context-prohibited-rule.prohibited_words'));

        // Remove and word, which is less then 3 chars from our list again
        // Otherwise this rule will be quite impossible to match...
        foreach ($this->prohibitedWords as $key => $word) {
            if (strlen($word) < config('context-prohibited-rule.min_length')) {
                unset($this->prohibitedWords[$key]);
            }
        }
    }

    /**
     * Determine if the validation rule passes.
     *
     * @param string $attribute
     * @param mixed $value
     * @return bool
     */
    public function passes($attribute, $value): bool
    {
        $value = strtolower($value);

        foreach ($this->prohibitedWords as $word) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (stripos($value, $word) !== false) {
                return false;
            }
        }

        return true;
    }

    public function message()
    {
        return __(
            'validation.context_prohibited',
            [
                'prohibited' => implode(',', $this->prohibitedWords)
            ]
        );
    }
}


1		<?php
2
3		namespace Swatty007\LaravelContextProhibitedRule\Rules;
4
5		use Illuminate\Contracts\Validation\Rule;
6		use Illuminate\Support\Str;
7
8		class ContextProhibited implements Rule
9		{
10		/**
11		* Dataset of context specific words we want to validate against
12		*
13		* @var array\|false\|string[]
14		*/
15		protected $prohibitedWords = [];
16
17		/**
18		* Create a new rule instance.
19		*
20		*/
21	14	public function __construct()
22		{
23		// Assemble our set of context specific words
24	14	if (!config('context-prohibited-rule.allow_application_name')) {
25	14	array_push($this->prohibitedWords, Str::lower(Str::camel(config('app.name'))));
26		}
27
28	14	if (!config('context-prohibited-rule.allow_hostname')) {
29	14	$hostname = Str::beforeLast(parse_url(config('app.url'), PHP_URL_HOST), '.');
		0 ignored issues – show Security Bug introduced 2021-02-18 23:30 UTC by Report Bug Copy Issue Report It seems like `parse_url(config('app.url'), PHP_URL_HOST)` targeting `parse_url()` can also be of type `false`; however, `Illuminate\Support\Str::beforeLast()` does only seem to accept `string`, did you maybe forget to handle an error condition? Loading history...
30	14	array_push($this->prohibitedWords, Str::lower($hostname));
31		}
32
33	14	$this->prohibitedWords = array_merge($this->prohibitedWords, config('context-prohibited-rule.prohibited_words'));
34
35		// Remove and word, which is less then 3 chars from our list again
36		// Otherwise this rule will be quite impossible to match...
37	14	foreach ($this->prohibitedWords as $key => $word) {
38	14	if (strlen($word) < config('context-prohibited-rule.min_length')) {
39	2	unset($this->prohibitedWords[$key]);
40		}
41		}
42	14	}
43
44		/**
45		* Determine if the validation rule passes.
46		*
47		* @param string $attribute
48		* @param mixed $value
49		* @return bool
50		*/
51	14	public function passes($attribute, $value): bool
52		{
53	14	$value = strtolower($value);
54
55	14	foreach ($this->prohibitedWords as $word) {
		0 ignored issues – show Bug introduced 2021-02-18 23:30 UTC by Report Bug Copy Issue Report The expression `$this->prohibitedWords` of type `array\|false` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
56	14	if (stripos($value, $word) !== false) {
57	12	return false;
58		}
59		}
60
61	10	return true;
62		}
63
64	12	public function message()
65		{
66	12	return __(
67	12	'validation.context_prohibited',
68		[
69	12	'prohibited' => implode(',', $this->prohibitedWords)
70		]
71		);
72		}
73		}
74

swatty007 / laravel-context-prohibited-rule

ContextProhibited::passes() A last analyzed 2021-02-19 22:41 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ContextProhibited::passes() A
last analyzed 2021-02-19 22:41 UTC